[PATCH] mtd: hyperbus: Fix build failure when only RPCIF_HYPERBUS is enabled

[PATCH] mtd: hyperbus: Fix build failure when only RPCIF_HYPERBUS is enabled

[Vignesh Raghavendra]

commit 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver") leads
to build failure[1] with COMPILE_TEST and RPCIF_HYPERBUS enabled. This
is because driver needs functions RENESAS_RPCIF which is only buildable
for CONFIG_ARCH_RENESAS.

Fix this by dropping COMPILE_TEST from RPCIF_HYPERBUS Kconfig entry.
This ensures driver can be built only when RENESAS_RPCIF is also
selected.

[1]:
rpc-if.c:(.text+0x20): undefined reference to `rpcif_disable_rpm' ld:
drivers/mtd/hyperbus/rpc-if.o: in function `rpcif_hb_prepare_read':
rpc-if.c:(.text+0xd6): undefined reference to `rpcif_prepare' ld:
drivers/mtd/hyperbus/rpc-if.o: in function `rpcif_hb_read16':
[...]

Fixes: 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver") leads
Reported-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
---

Based on mtd/next

Richard,

Could you please pull this into mtd/next?

 drivers/mtd/hyperbus/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/hyperbus/Kconfig b/drivers/mtd/hyperbus/Kconfig
index 35b3ab4c8b94..46c7e407e378 100644
--- a/drivers/mtd/hyperbus/Kconfig
+++ b/drivers/mtd/hyperbus/Kconfig
@@ -24,7 +24,7 @@ config HBMC_AM654
 
 config RPCIF_HYPERBUS
 	tristate "Renesas RPC-IF HyperBus driver"
-	depends on RENESAS_RPCIF || COMPILE_TEST
+	depends on RENESAS_RPCIF
 	depends on MTD_CFI_BE_BYTE_SWAP
 	help
 	  This option includes Renesas RPC-IF HyperBus support.
-- 
2.28.0

Re: [PATCH] mtd: hyperbus: Fix build failure when only RPCIF_HYPERBUS is enabled

[Richard Weinberger]

----- Ursprüngliche Mail -----
> Von: "Vignesh Raghavendra" <vigneshr@ti.com>
> An: "Vignesh Raghavendra" <vigneshr@ti.com>, "Miquel Raynal" <miquel.raynal@bootlin.com>, "richard" <richard@nod.at>
> CC: "Sergei Shtylyov" <sergei.shtylyov@gmail.com>, "linux-mtd" <linux-mtd@lists.infradead.org>, "linux-kernel"
> <linux-kernel@vger.kernel.org>
> Gesendet: Montag, 12. Oktober 2020 09:09:58
> Betreff: [PATCH] mtd: hyperbus: Fix build failure when only RPCIF_HYPERBUS is enabled

> commit 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver") leads
> to build failure[1] with COMPILE_TEST and RPCIF_HYPERBUS enabled. This
> is because driver needs functions RENESAS_RPCIF which is only buildable
> for CONFIG_ARCH_RENESAS.
> 
> Fix this by dropping COMPILE_TEST from RPCIF_HYPERBUS Kconfig entry.
> This ensures driver can be built only when RENESAS_RPCIF is also
> selected.
> 
> [1]:
> rpc-if.c:(.text+0x20): undefined reference to `rpcif_disable_rpm' ld:
> drivers/mtd/hyperbus/rpc-if.o: in function `rpcif_hb_prepare_read':
> rpc-if.c:(.text+0xd6): undefined reference to `rpcif_prepare' ld:
> drivers/mtd/hyperbus/rpc-if.o: in function `rpcif_hb_read16':
> [...]
> 
> Fixes: 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver") leads
> Reported-by: Richard Weinberger <richard@nod.at>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
> 
> Based on mtd/next
> 
> Richard,
> 
> Could you please pull this into mtd/next?

Applied! :-)

Thanks,
//richard