[PATCH] drivers/net: ks8842 Fix crash on received packet when in PIO mode.

[PATCH] drivers/net: ks8842 Fix crash on received packet when in PIO mode.

[Dennis Aberilla]

This patch fixes a kernel crash during packet reception due to not enough allocated bytes for the skb. This applies to the driver when running in PIO mode in an ISA bus setup.

Signed-off-by: Dennis Aberilla <denzzzhome@yahoo.com>


---
diff --git a/drivers/net/ks8842.c b/drivers/net/ks8842.c
index f0d8346..9069aee 100644
--- a/drivers/net/ks8842.c
+++ b/drivers/net/ks8842.c
@@ -662,7 +662,7 @@ static void ks8842_rx_frame(struct net_device *netdev,

   /* check the status */
   if ((status & RXSR_VALID) && !(status & RXSR_ERROR)) {
-     struct sk_buff *skb = netdev_alloc_skb_ip_align(netdev, len);
+     struct sk_buff *skb = netdev_alloc_skb_ip_align(netdev, len + 2);

      if (skb) {



--

|Dennis

Re: [PATCH] drivers/net: ks8842 Fix crash on received packet when in PIO mode.

[David Miller]

From: Dennis Aberilla <denzzzhome@yahoo.com>
Date: Wed, 18 May 2011 14:51:14 -0700 (PDT)

> diff --git a/drivers/net/ks8842.c b/drivers/net/ks8842.c
> index f0d8346..9069aee 100644
> --- a/drivers/net/ks8842.c
> +++ b/drivers/net/ks8842.c
> @@ -662,7 +662,7 @@ static void ks8842_rx_frame(struct net_device *netdev,
> 
>    /* check the status */
>    if ((status & RXSR_VALID) && !(status & RXSR_ERROR)) {
> -     struct sk_buff *skb = netdev_alloc_skb_ip_align(netdev, len);
> +     struct sk_buff *skb = netdev_alloc_skb_ip_align(netdev, len + 2);

Your patch has been corrupted by your email client, it has turned TAB
characters into spaces, amongst other things.  This makes your patch
unusable.

Please read Documentation/email-clients.txt, and use that information
to fix your email client, and then send the patch as a test email
to yourself and make sure that you can extract the patch and apply
it cleanly before you resend it here.

Thanks.

Re: [PATCH] drivers/net: ks8842 Fix crash on received packet when in PIO mode.

[David Miller]

BTW, you also sent this to the wrong list.

Networking patches must be sent to netdev@vger.kernel.org