From: Alan Stern <stern@rowland.harvard.edu>
To: Jonas Oberhauser <jonas.oberhauser@huaweicloud.com>
Cc: paulmck@kernel.org, parri.andrea@gmail.com, will@kernel.org,
peterz@infradead.org, boqun.feng@gmail.com, npiggin@gmail.com,
dhowells@redhat.com, j.alglave@ucl.ac.uk, luc.maranget@inria.fr,
akiyks@gmail.com, dlustig@nvidia.com, joel@joelfernandes.org,
urezki@gmail.com, quic_neeraju@quicinc.com, frederic@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 2/4] tools/memory-model: Define applicable tags on operation in tools/...
Date: Mon, 27 May 2024 11:59:55 -0400 [thread overview]
Message-ID: <2094aee7-4597-4f7e-b08f-9829f70aa8ff@rowland.harvard.edu> (raw)
In-Reply-To: <20240527152253.195956-3-jonas.oberhauser@huaweicloud.com>
On Mon, May 27, 2024 at 05:22:51PM +0200, Jonas Oberhauser wrote:
> Herd7 transforms reads, writes, and read-modify-writes by eliminating
> 'acquire tags from writes, 'release tags from reads, and 'acquire,
> 'release, and 'mb tags from failed read-modify-writes. We emulate this
> behavior by redefining Acquire, Release, and Mb sets in linux-kernel.bell
> to explicitly exclude those combinations.
>
> Herd7 furthermore adds 'noreturn tag to certain reads. Currently herd7
> does not allow specifying the 'noreturn tag manually, but such manual
> declaration (e.g., through a syntax __atomic_op{noreturn}) would add
> invalid 'noreturn tags to writes; in preparation, we already also exclude
> this combination.
>
> Signed-off-by: Jonas Oberhauser <jonas.oberhauser@huaweicloud.com>
> ---
> tools/memory-model/linux-kernel.bell | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/tools/memory-model/linux-kernel.bell b/tools/memory-model/linux-kernel.bell
> index 1b2444cdf8d1..08fa1ccb1328 100644
> --- a/tools/memory-model/linux-kernel.bell
> +++ b/tools/memory-model/linux-kernel.bell
> @@ -36,6 +36,13 @@ enum Barriers = 'wmb (*smp_wmb*) ||
> 'after-srcu-read-unlock (*smp_mb__after_srcu_read_unlock*)
> instructions F[Barriers]
>
> +(* Remove impossible tags, such as Acquire on a store or failed RMW *)
> +let FailedRMW = RMW \ (domain(rmw) | range(rmw))
> +let Acquire = Acquire \ W \ FailedRMW
> +let Release = Release \ R \ FailedRMW
> +let Mb = Mb \ FailedRMW
> +let Noreturn = Noreturn \ W
> +
> (* SRCU *)
> enum SRCU = 'srcu-lock || 'srcu-unlock || 'sync-srcu
> instructions SRCU[SRCU]
> @@ -82,4 +89,4 @@ let Plain = M \ Marked
> let carry-dep = (data ; [~ Srcu-unlock] ; rfi)*
> let addr = carry-dep ; addr
> let ctrl = carry-dep ; ctrl
> -let data = carry-dep ; data
> +let data = carry-dep ; data
> \ No newline at end of file
It looks like the final newline was accidentally deleted.
Alan
next prev parent reply other threads:[~2024-05-27 15:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 15:22 [RFC][PATCH 0/4] tools/memory-model: Define more of LKMM in tools/memory-model Jonas Oberhauser
2024-05-27 15:22 ` [RFC][PATCH 1/4] tools/memory-model: Legitimize current use of tags in LKMM macros Jonas Oberhauser
2024-05-27 15:58 ` Alan Stern
2024-05-27 15:22 ` [RFC][PATCH 2/4] tools/memory-model: Define applicable tags on operation in tools/ Jonas Oberhauser
2024-05-27 15:59 ` Alan Stern [this message]
2024-05-27 15:22 ` [RFC][PATCH 3/4] tools/memory-model: Define effect of Mb tags on RMWs " Jonas Oberhauser
2024-05-27 16:04 ` Alan Stern
2024-05-27 15:22 ` [RFC][PATCH 4/4] tools/memory-model: Distinguish between syntactic and semantic tags Jonas Oberhauser
2024-05-27 16:06 ` Alan Stern
2024-05-28 12:49 ` Jonas Oberhauser
2024-05-28 14:01 ` Alan Stern
2024-05-28 14:45 ` Jonas Oberhauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2094aee7-4597-4f7e-b08f-9829f70aa8ff@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=akiyks@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=dhowells@redhat.com \
--cc=dlustig@nvidia.com \
--cc=frederic@kernel.org \
--cc=j.alglave@ucl.ac.uk \
--cc=joel@joelfernandes.org \
--cc=jonas.oberhauser@huaweicloud.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.maranget@inria.fr \
--cc=npiggin@gmail.com \
--cc=parri.andrea@gmail.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=quic_neeraju@quicinc.com \
--cc=urezki@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®