From: Alan Stern <stern@rowland.harvard.edu>
To: Jonas Oberhauser <jonas.oberhauser@huaweicloud.com>
Cc: paulmck@kernel.org, parri.andrea@gmail.com, will@kernel.org,
peterz@infradead.org, boqun.feng@gmail.com, npiggin@gmail.com,
dhowells@redhat.com, j.alglave@ucl.ac.uk, luc.maranget@inria.fr,
akiyks@gmail.com, dlustig@nvidia.com, joel@joelfernandes.org,
urezki@gmail.com, quic_neeraju@quicinc.com, frederic@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 1/4] tools/memory-model: Legitimize current use of tags in LKMM macros
Date: Mon, 27 May 2024 11:58:01 -0400 [thread overview]
Message-ID: <aacd17e1-15b3-4bd9-9052-9c7e309fb2d8@rowland.harvard.edu> (raw)
In-Reply-To: <20240527152253.195956-2-jonas.oberhauser@huaweicloud.com>
On Mon, May 27, 2024 at 05:22:50PM +0200, Jonas Oberhauser wrote:
> The current macros in linux-kernel.def reference instructions such as
> __xchg{mb} or __cmpxchg{acquire}, which are invalid combinations of tags
> and instructions according to the declarations in linux-kernel.bell.
> This works with current herd7 because herd7 removes these tags anyways
> and does not actually enforce validity of combinations at all.
>
> If a future herd7 version no longer applies these hardcoded
> transformations, then all currently invalid combinations will actually
> appear on some instruction.
>
> We therefore adjust the declarations to make the resulting combinations
> valid, by adding the 'mb tag to the set of Accesses and allowing all
> Accesses to appear on all read, write, and RMW instructions.
>
> Signed-off-by: Jonas Oberhauser <jonas.oberhauser@huaweicloud.com>
> ---
> tools/memory-model/linux-kernel.bell | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/tools/memory-model/linux-kernel.bell b/tools/memory-model/linux-kernel.bell
> index ce068700939c..1b2444cdf8d1 100644
> --- a/tools/memory-model/linux-kernel.bell
> +++ b/tools/memory-model/linux-kernel.bell
> @@ -16,10 +16,11 @@
> enum Accesses = 'once (*READ_ONCE,WRITE_ONCE*) ||
> 'release (*smp_store_release*) ||
> 'acquire (*smp_load_acquire*) ||
> - 'noreturn (* R of non-return RMW *)
> -instructions R[{'once,'acquire,'noreturn}]
> -instructions W[{'once,'release}]
> -instructions RMW[{'once,'acquire,'release}]
> + 'noreturn (* R of non-return RMW *) ||
> + 'mb (*xchg(),compare_exchange(),...*)
It would be better to write cmpxchg() instead of compare_exchange().
Alan
> +instructions R[Accesses]
> +instructions W[Accesses]
> +instructions RMW[Accesses]
>
> enum Barriers = 'wmb (*smp_wmb*) ||
> 'rmb (*smp_rmb*) ||
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-05-27 15:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 15:22 [RFC][PATCH 0/4] tools/memory-model: Define more of LKMM in tools/memory-model Jonas Oberhauser
2024-05-27 15:22 ` [RFC][PATCH 1/4] tools/memory-model: Legitimize current use of tags in LKMM macros Jonas Oberhauser
2024-05-27 15:58 ` Alan Stern [this message]
2024-05-27 15:22 ` [RFC][PATCH 2/4] tools/memory-model: Define applicable tags on operation in tools/ Jonas Oberhauser
2024-05-27 15:59 ` Alan Stern
2024-05-27 15:22 ` [RFC][PATCH 3/4] tools/memory-model: Define effect of Mb tags on RMWs " Jonas Oberhauser
2024-05-27 16:04 ` Alan Stern
2024-05-27 15:22 ` [RFC][PATCH 4/4] tools/memory-model: Distinguish between syntactic and semantic tags Jonas Oberhauser
2024-05-27 16:06 ` Alan Stern
2024-05-28 12:49 ` Jonas Oberhauser
2024-05-28 14:01 ` Alan Stern
2024-05-28 14:45 ` Jonas Oberhauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aacd17e1-15b3-4bd9-9052-9c7e309fb2d8@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=akiyks@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=dhowells@redhat.com \
--cc=dlustig@nvidia.com \
--cc=frederic@kernel.org \
--cc=j.alglave@ucl.ac.uk \
--cc=joel@joelfernandes.org \
--cc=jonas.oberhauser@huaweicloud.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.maranget@inria.fr \
--cc=npiggin@gmail.com \
--cc=parri.andrea@gmail.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=quic_neeraju@quicinc.com \
--cc=urezki@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®