mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonas Oberhauser <jonas.oberhauser@huaweicloud.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: paulmck@kernel.org, parri.andrea@gmail.com, will@kernel.org,
	peterz@infradead.org, boqun.feng@gmail.com, npiggin@gmail.com,
	dhowells@redhat.com, j.alglave@ucl.ac.uk, luc.maranget@inria.fr,
	akiyks@gmail.com, dlustig@nvidia.com, joel@joelfernandes.org,
	urezki@gmail.com, quic_neeraju@quicinc.com, frederic@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 4/4] tools/memory-model: Distinguish between syntactic and semantic tags
Date: Tue, 28 May 2024 16:45:58 +0200	[thread overview]
Message-ID: <c366a946-fa00-44b2-88bd-c724b3b7a39e@huaweicloud.com> (raw)
In-Reply-To: <f9ea1b36-b345-4c94-a19f-4fa124d8f7c3@rowland.harvard.edu>



Am 5/28/2024 um 4:01 PM schrieb Alan Stern:
> On Tue, May 28, 2024 at 02:49:38PM +0200, Jonas Oberhauser wrote:
>>>> +let Mb = MB \ FailedRMW
>>>>>>    (* Compute marked and plain memory accesses *)
>>>> -let Marked = (~M) | IW | Once | Release | Acquire | domain(rmw) | range(rmw) |
>>>> +let Marked = (~M) | IW | ONCE | RELEASE | ACQUIRE | MB | domain(rmw) | range(rmw) |
>>>
>>> The new MB term isn't needed, because MB tags on memory accesses are
>>> filtered out unless the access also belongs to domain(rmw) | range(rmw).
>>>
>>> Alan
>>
>>
>> Thanks for all the notes.
>> I think on this one is needed though under the assumption that herd7 would
>> no longer know internally to replace the MB with ONCE in case
>> of failure.

> Hmmm, this raises another question: Shouldn't the R event for a failed
> cmpxchg_release count as marked?  

Yes.

> At the moment it's not clear how such
> events will be tagged.

If by "at the moment" you mean the current herd7, then (as mentioned in 
the cover letter) this patch does not work at all with the current herd7 
because IIUC in fact ACQUIRE and RELEASE tags will be replaced by Once 
in all cases (so smp_store_release would be a store Once ...).

However, in a hypothetical version of herd7 which just leaves all the 
syntactic tags intact, we would get R & RMW & RELEASE, which would not 
be in the Release set (by nature of failing and being a read) but would 
be Marked (by nature of having a syntactic RELEASE tag).

> Perhaps the best thing to do is add RMW to
> this list, which would make domain(rmw) and range(rmw) unnecessary.


That's also a good idea.

> And then we probably don't need to keep MB

That's correct, although as a failsafe I would probably keep it anyways 
- it doesn't harm, but it may prevent a gotcha.

Have fun,
   jonas


      reply	other threads:[~2024-05-28 14:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-27 15:22 [RFC][PATCH 0/4] tools/memory-model: Define more of LKMM in tools/memory-model Jonas Oberhauser
2024-05-27 15:22 ` [RFC][PATCH 1/4] tools/memory-model: Legitimize current use of tags in LKMM macros Jonas Oberhauser
2024-05-27 15:58   ` Alan Stern
2024-05-27 15:22 ` [RFC][PATCH 2/4] tools/memory-model: Define applicable tags on operation in tools/ Jonas Oberhauser
2024-05-27 15:59   ` Alan Stern
2024-05-27 15:22 ` [RFC][PATCH 3/4] tools/memory-model: Define effect of Mb tags on RMWs " Jonas Oberhauser
2024-05-27 16:04   ` Alan Stern
2024-05-27 15:22 ` [RFC][PATCH 4/4] tools/memory-model: Distinguish between syntactic and semantic tags Jonas Oberhauser
2024-05-27 16:06   ` Alan Stern
2024-05-28 12:49     ` Jonas Oberhauser
2024-05-28 14:01       ` Alan Stern
2024-05-28 14:45         ` Jonas Oberhauser [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c366a946-fa00-44b2-88bd-c724b3b7a39e@huaweicloud.com \
    --to=jonas.oberhauser@huaweicloud.com \
    --cc=akiyks@gmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dhowells@redhat.com \
    --cc=dlustig@nvidia.com \
    --cc=frederic@kernel.org \
    --cc=j.alglave@ucl.ac.uk \
    --cc=joel@joelfernandes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luc.maranget@inria.fr \
    --cc=npiggin@gmail.com \
    --cc=parri.andrea@gmail.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=quic_neeraju@quicinc.com \
    --cc=stern@rowland.harvard.edu \
    --cc=urezki@gmail.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®