* [PATCH] 9p: hide cachetag option for non-CONFIG_9P_FSCACHE
@ 2017-07-10 11:21 Arnd Bergmann
2017-07-11 15:28 ` David Howells
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-07-10 11:21 UTC (permalink / raw)
To: Al Viro
Cc: Arnd Bergmann, Eric Van Hensbergen, Ron Minnich,
Latchesar Ionkov, Ingo Molnar, Jens Axboe, David Howells,
Jan Kara, v9fs-developer, linux-kernel
show_options cannot print this option when it is disabled in Kconfig:
fs/9p/v9fs.c: In function 'v9fs_show_options':
fs/9p/v9fs.c:140:13: error: 'struct v9fs_session_info' has no member named 'cachetag'; did you mean 'cache'?
Fixes: ccb0055985b9 ("9p: Implement show_options")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
fs/9p/v9fs.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/9p/v9fs.c b/fs/9p/v9fs.c
index d69046650a36..8fb89ddc6cc7 100644
--- a/fs/9p/v9fs.c
+++ b/fs/9p/v9fs.c
@@ -137,8 +137,10 @@ int v9fs_show_options(struct seq_file *m, struct dentry *root)
seq_puts(m, ",nodevmap");
if (v9ses->cache)
seq_printf(m, ",%s", v9fs_cache_modes[v9ses->cache]);
+#ifdef CONFIG_9P_FSCACHE
if (v9ses->cachetag && v9ses->cache == CACHE_FSCACHE)
seq_printf(m, ",cachetag=%s", v9ses->cachetag);
+#endif
switch (v9ses->flags & V9FS_ACCESS_MASK) {
case V9FS_ACCESS_USER:
--
2.9.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] 9p: hide cachetag option for non-CONFIG_9P_FSCACHE
2017-07-10 11:21 [PATCH] 9p: hide cachetag option for non-CONFIG_9P_FSCACHE Arnd Bergmann
@ 2017-07-11 15:28 ` David Howells
0 siblings, 0 replies; 2+ messages in thread
From: David Howells @ 2017-07-11 15:28 UTC (permalink / raw)
To: Arnd Bergmann
Cc: dhowells, Al Viro, Eric Van Hensbergen, Ron Minnich,
Latchesar Ionkov, Ingo Molnar, Jens Axboe, Jan Kara,
v9fs-developer, linux-kernel
Arnd Bergmann <arnd@arndb.de> wrote:
> show_options cannot print this option when it is disabled in Kconfig:
>
> fs/9p/v9fs.c: In function 'v9fs_show_options':
> fs/9p/v9fs.c:140:13: error: 'struct v9fs_session_info' has no member named 'cachetag'; did you mean 'cache'?
>
> Fixes: ccb0055985b9 ("9p: Implement show_options")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: David Howells <dhowells@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-11 15:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-10 11:21 [PATCH] 9p: hide cachetag option for non-CONFIG_9P_FSCACHE Arnd Bergmann
2017-07-11 15:28 ` David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®