Re: [PATCH v2 6/9] arm64: dts: qcom: shikra-cqm-evk: Enable sound card support

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 9/11/26 1:16 AM, Mohammad Rafi Shaik wrote:
> Enable the sound card on the shikra-cqm-evk platform, including
> the PM4125 (Rouleur) headset codec, WSA885x external speaker path,
> and QAIF backend links.
> 
> Also enable the required LPASS macro and SoundWire nodes, along with
> the necessary pinctrl configurations for DMIC and I2S interfaces.
> 
> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
> ---

[...]
> +&gpr {
> +	status = "disabled";
> +};

Why?

> +
> +&i2c3 {
> +	status = "okay";
> +
> +	wsa8855: speaker@c {
> +		compatible = "qcom,wsa8855";
> +		reg = <0x0c>;
> +
> +		pinctrl-0 = <&wsa8855_spkr_sd_n>;
> +		pinctrl-names = "default";
> +
> +		powerdown-gpios = <&tlmm 2 GPIO_ACTIVE_LOW>;
> +		interrupt-parent = <&tlmm>;
> +		interrupts = <77 IRQ_TYPE_EDGE_FALLING>;
> +		vdd-1p8-supply = <&pm4125_l15>;
> +		vdd-io-supply = <&pm4125_l15>;
> +		qcom,battery-config = "1s";

[...]

> +&vamacro {
> +	pinctrl-0 = <&dmic01_default>, <&dmic23_default>, <&tx_swr_active>;
> +	pinctrl-names = "default";
> +
> +	qcom,dmic-sample-rate = <4800000>;
> +	status = "okay";
> +};

nit: please keep a \n before 'status' consistently

Konrad