mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joseph Salisbury <joseph.salisbury@oracle.com>
To: Chris Mason <clm@meta.com>, clm@fb.com
Cc: Peter Zijlstra <peterz@infradead.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Ingo Molnar <mingo@redhat.com>,
	dietmar.eggemann@arm.com, Steven Rostedt <rostedt@goodmis.org>,
	bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [External] : Re: [REGRESSION][v6.17-rc1]sched/fair: Bump sd->max_newidle_lb_cost when newidle balance fails
Date: Tue, 7 Oct 2025 16:22:56 -0400	[thread overview]
Message-ID: <22f0cf5c-ad9c-496e-a500-fee97daf160b@oracle.com> (raw)
In-Reply-To: <28340138-a00e-47bc-a36f-270a01ac83b4@meta.com>



On 10/6/25 17:23, Chris Mason wrote:
> On 10/6/25 4:23 PM, Joseph Salisbury wrote:
>> Hi Chris,
>>
>> During testing, we are seeing a ~6% performance regression with the
>> upstream stable v6.12.43 kernel (And Oracle UEK
>> 6.12.0-104.43.4.el9uek.x86_64 kernel) when running the Phoronix
>> pts/apache benchmark with 100 concurrent requests [0].  The regression
>> is seen with the following hardware:
>>
>> PROCESSOR: Intel Xeon Platinum 8167M Core Count: 8 Thread Count: 16
>> Extensions: SSE 4.2 + AVX512CD + AVX2 + AVX + RDRAND + FSGSBASE Cache
>> Size: 16 MB Microcode: 0x1 Core Family: Cascade Lake
>>
>> After performing a bisect, we found that the performance regression was
>> introduced by the following commit:
>>
>> Stable v6.12.43: fc4289233e4b ("sched/fair: Bump sd->max_newidle_lb_cost
>> when newidle balance fails")
>> Mainline v6.17-rc1: 155213a2aed4 ("sched/fair: Bump
>> sd->max_newidle_lb_cost when newidle balance fails")
>>
>> Reverting this commit causes the performance regression to not exist.
>>
>> I was hoping to get your feedback, since you are the patch author.  Do
>> you think gathering any additional data will help diagnose this issue?
> Hi everyone,
>
> Peter, we've had a collection of regression reports based on this
> change, so it sounds like we need to make it less aggressive, or maybe
> we need to make the degrading of the cost number more aggressive?
>
> Joe (and everyone else who has hit this), can I talk you into trying the
> drgn from
> https://urldefense.com/v3/__https://lore.kernel.org/lkml/2fbf24bc-e895-40de-9ff6-5c18b74b4300@meta.com/__;!!ACWV5N9M2RV99hQ!Pm-G5L97VLtQdDRHad16cdOnEwHxyKGHd8U1FSLtAY-oy2pNcbmCjTS1XRjq-ypIoQdJGkE_12KkAr0$
>
> I'm curious if it degrades at all or just gets stuck up high.
>
> -chris
Hi Chris,

Thanks for the quick response!

Yes, I will try out the drgn from the link you posted and provide feedback.

Thanks,

Joe

  parent reply	other threads:[~2025-10-07 20:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-06 20:23 Joseph Salisbury
2025-10-06 21:23 ` Chris Mason
2025-10-07 11:34   ` Peter Zijlstra
2025-10-10  1:04     ` [External] : " Joseph Salisbury
2025-10-10 17:09       ` Peter Zijlstra
2025-10-17 17:01         ` Joseph Salisbury
2025-10-30  7:29           ` Adam Li
2025-10-31 21:16             ` [External] : " Joseph Salisbury
2025-11-04 18:11             ` Joseph Salisbury
2025-10-30  7:22         ` Adam Li
2025-10-30  9:30           ` Peter Zijlstra
2025-10-30 20:53             ` Dietmar Eggemann
2025-10-31  2:46             ` Adam Li
2025-10-10  1:14     ` Joseph Salisbury
2025-10-07 20:22   ` Joseph Salisbury [this message]
2025-10-10 13:09   ` Hazem Mohamed Abuelfotoh
2025-10-27 18:36   ` Josh Don

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22f0cf5c-ad9c-496e-a500-fee97daf160b@oracle.com \
    --to=joseph.salisbury@oracle.com \
    --cc=bsegall@google.com \
    --cc=clm@fb.com \
    --cc=clm@meta.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®