From: Joseph Salisbury <joseph.salisbury@oracle.com>
To: Adam Li <adamli@os.amperecomputing.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: Chris Mason <clm@meta.com>,
clm@fb.com, Vincent Guittot <vincent.guittot@linaro.org>,
Juri Lelli <juri.lelli@redhat.com>,
Ingo Molnar <mingo@redhat.com>,
dietmar.eggemann@arm.com, Steven Rostedt <rostedt@goodmis.org>,
bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [External] : Re: [REGRESSION][v6.17-rc1]sched/fair: Bump sd->max_newidle_lb_cost when newidle balance fails
Date: Fri, 31 Oct 2025 17:16:30 -0400 [thread overview]
Message-ID: <5e236e56-5fbb-48a3-84a7-839f4ab08f6d@oracle.com> (raw)
In-Reply-To: <97d9d369-aebd-4471-99dd-177fa83adbe2@os.amperecomputing.com>
On 10/30/25 3:29 AM, Adam Li wrote:
> Hi Joseph,
>
> On 10/18/2025 1:01 AM, Joseph Salisbury wrote:
>>
>> On 10/10/25 13:09, Peter Zijlstra wrote:
>>> On Thu, Oct 09, 2025 at 09:04:40PM -0400, Joseph Salisbury wrote:
>>>
> [...]
>>> diff --git a/kernel/sched/features.h b/kernel/sched/features.h
>>> index 3c12d9f93331..5ded210701d0 100644
>>> --- a/kernel/sched/features.h
>>> +++ b/kernel/sched/features.h
>>> @@ -121,3 +121,8 @@ SCHED_FEAT(WA_BIAS, true)
>>> SCHED_FEAT(UTIL_EST, true)
>>> SCHED_FEAT(LATENCY_WARN, false)
>>> +
>>> +SCHED_FEAT(NI_TARGET, false)
>>> +SCHED_FEAT(NI_SPARE, false)
>>> +SCHED_FEAT(NI_RUNNABLE, false)
>>> +SCHED_FEAT(NI_RANDOM, false)
> [...]
>> Thanks for providing the patch!
>>
>> I performed the same testing with this patch applied to a v6.12 based kernel. The performance regression still exists and is slightly worse.
>> The drgn stats are attached in a file named 'apache_drgn_log_NewidleRework_From_Peter.log'.
>>
>>
> Just wondering, did you enable NI_TARGET feature?
> It is default false in Peter's patch.
> In my test 'NI_TARGET' can fix the regression caused by commit 155213a2aed4.
>
> Thanks,
> -adam
>
Hi Adam,
I did not try NI_TARGET. I will try changing this in Peter's patch and
re-test. I'll post the results.
next prev parent reply other threads:[~2025-10-31 21:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-06 20:23 Joseph Salisbury
2025-10-06 21:23 ` Chris Mason
2025-10-07 11:34 ` Peter Zijlstra
2025-10-10 1:04 ` [External] : " Joseph Salisbury
2025-10-10 17:09 ` Peter Zijlstra
2025-10-17 17:01 ` Joseph Salisbury
2025-10-30 7:29 ` Adam Li
2025-10-31 21:16 ` Joseph Salisbury [this message]
2025-11-04 18:11 ` [External] : " Joseph Salisbury
2025-10-30 7:22 ` Adam Li
2025-10-30 9:30 ` Peter Zijlstra
2025-10-30 20:53 ` Dietmar Eggemann
2025-10-31 2:46 ` Adam Li
2025-10-10 1:14 ` Joseph Salisbury
2025-10-07 20:22 ` [External] : " Joseph Salisbury
2025-10-10 13:09 ` Hazem Mohamed Abuelfotoh
2025-10-27 18:36 ` Josh Don
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e236e56-5fbb-48a3-84a7-839f4ab08f6d@oracle.com \
--to=joseph.salisbury@oracle.com \
--cc=adamli@os.amperecomputing.com \
--cc=bsegall@google.com \
--cc=clm@fb.com \
--cc=clm@meta.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®