From: Judith Mendez <jm@ti.com>
To: Bhavya Kapoor <b-kapoor@ti.com>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Cc: <conor+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<robh+dt@kernel.org>, <kristo@kernel.org>, <vigneshr@ti.com>,
<nm@ti.com>
Subject: Re: [PATCH 2/3] arm64: dts: ti: k3-j721s2-main: Add Itap Delay Value For DDR50 speed mode
Date: Tue, 5 Dec 2023 13:24:38 -0600 [thread overview]
Message-ID: <231e173e-2452-401a-8c11-5b555da59a2b@ti.com> (raw)
In-Reply-To: <20231201082045.790478-3-b-kapoor@ti.com>
Hi Bhavya,
On 12/1/23 2:20 AM, Bhavya Kapoor wrote:
> DDR50 speed mode is enabled for MMCSD in J721s2 but its Itap Delay
> Value is not present in the device tree. Thus, add Itap Delay Value
> for MMCSD High Speed DDR which is DDR50 speed mode for J721s2 SoC
> according to datasheet for J721s2.
>
> [+] Refer to : section 7.10.5.17.2 MMC1/2 - SD/SDIO Interface, in
> J721s2 datasheet
> - https://www.ti.com/lit/ds/symlink/tda4vl-q1.pdf
>
LGTM
Reviewed-by: Judith Mendez <jm@ti.com>
> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> index b03731b53a26..e1255956288b 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> @@ -766,6 +766,7 @@ main_sdhci1: mmc@4fb0000 {
> ti,itap-del-sel-sd-hs = <0x0>;
> ti,itap-del-sel-sdr12 = <0x0>;
> ti,itap-del-sel-sdr25 = <0x0>;
> + ti,itap-del-sel-ddr50 = <0x2>;
> ti,clkbuf-sel = <0x7>;
> ti,trm-icp = <0x8>;
> dma-coherent;
~ Judith
next prev parent reply other threads:[~2023-12-05 19:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 8:20 [PATCH 0/3] arm64: dts: ti: Add Itap Delay Value For High Speed DDR Bhavya Kapoor
2023-12-01 8:20 ` [PATCH 1/3] arm64: dts: ti: k3-j7200-main: Add Itap Delay Value For DDR52 speed mode Bhavya Kapoor
2023-12-05 19:22 ` Judith Mendez
2023-12-01 8:20 ` [PATCH 2/3] arm64: dts: ti: k3-j721s2-main: Add Itap Delay Value For DDR50 " Bhavya Kapoor
2023-12-05 19:24 ` Judith Mendez [this message]
2023-12-01 8:20 ` [PATCH 3/3] arm64: dts: ti: k3-j784s4-main: " Bhavya Kapoor
2023-12-05 19:25 ` Judith Mendez
2023-12-05 18:31 ` [PATCH 0/3] arm64: dts: ti: Add Itap Delay Value For High Speed DDR Kumar, Udit
2023-12-14 11:07 ` Bhavya Kapoor
2023-12-14 15:00 ` Kumar, Udit
2023-12-15 17:21 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=231e173e-2452-401a-8c11-5b555da59a2b@ti.com \
--to=jm@ti.com \
--cc=b-kapoor@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®