mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Palmer Dabbelt <palmer@dabbelt.com>,
	yamada.masahiro@socionext.com, mmarek@suse.com,
	will.deacon@arm.com, peterz@infradead.org, boqun.feng@gmail.com,
	mingo@redhat.com, tglx@linutronix.de, jason@lakedaemon.net,
	marc.zyngier@arm.com, gregkh@linuxfoundation.org,
	jslaby@suse.com, davem@davemloft.net, mchehab@kernel.org,
	sfr@canb.auug.org.au, fweisbec@gmail.com,
	viro@zeniv.linux.org.uk, mcgrof@kernel.org, dledford@redhat.com,
	bart.vanassche@sandisk.com, sstabellini@kernel.org,
	daniel.vetter@ffwll.ch, mpe@ellerman.id.au, msalter@redhat.com,
	nicolas.dichtel@6wind.com, james.hogan@imgtec.com,
	paul.gortmaker@windriver.com, linux@roeck-us.net,
	heiko.carstens@de.ibm.com, schwidefsky@de.ibm.com,
	linux-kernel@vger.kernel.org, patches@groups.riscv.org,
	akpm@linux-foundation.org
Cc: albert@sifive.com
Subject: Re: [PATCH 05/17] clocksource: New RISC-V SBI timer driver
Date: Mon, 31 Jul 2017 13:00:26 +0200	[thread overview]
Message-ID: <24a37ba4-df64-21c4-abec-18c0dbed0ab7@linaro.org> (raw)
In-Reply-To: <20170711013924.22085-6-palmer@dabbelt.com>

On 11/07/2017 03:39, Palmer Dabbelt wrote:
> The RISC-V ISA defines a per-hart real-time clock and timer, which is
> present on all systems.  The clock is accessed via the 'rdtime'
> pseudo-instruction (which reads a CSR), and the timer is set via an SBI
> call.
> 
> This driver attempts to split out the RISC-V ISA specific mechanisms of
> accessing the hardware from the clocksource driver by taking a pair of
> function pointers to issue the actual RISC-V specific instructions.
> 
> Signed-off-by: Palmer Dabbelt <palmer@dabbelt.com>
> ---

[ ... ]

> +#ifndef _LINUX_TIMER_RISCV_H
> +#define _LINUX_TIMER_RISCV_H
> +
> +/*
> + * All RISC-V systems have a timer attached to every hart.  These timers can be
> + * read by the 'rdcycle' pseudo instruction, and can use the SBI to setup
> + * events.  In order to abstract the architecture-specific timer reading and
> + * setting functions away from the clock event insertion code, we provide
> + * function pointers to the clockevent subsystem that perform two basic operations:
> + * rdtime() reads the timer on the current CPU, and next_event(delta) sets the
> + * next timer event to 'delta' cycles in the future.  As the timers are
> + * inherently a per-cpu resource, these callbacks perform operations on the
> + * current hart.  There is guaranteed to be exactly one timer per hart on all
> + * RISC-V systems.
> + */

Hi Palmer,

The driver code must be self contained (eg. setup and irq handling).

There are examples in the drivers/clocksource to stick on, for example
the jcore-pit.c or the mips-gic-timer.c drivers.

I don't see the point to setup callbacks at init time.

Thanks.

  -- Daniel


> +void timer_riscv_init(int cpu_id,
> +		      unsigned long riscv_timebase,
> +		      unsigned long long (*rdtime)(struct clocksource *),
> +		      int (*next_event)(unsigned long, struct clock_event_device *));
> +
> +/*
> + * Looks up the clocksource or clock_even_device that cooresponds the given
> + * hart.
> + */
> +struct clocksource *timer_riscv_source(int cpuid);
> +struct clock_event_device *timer_riscv_device(int cpu_id);
> +
> +#endif
> 


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

  reply	other threads:[~2017-07-31 11:00 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-11  1:39 RISC-V Linux Port v5 Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 01/17] lib: Add shared copies of some GCC library routines Palmer Dabbelt
2017-07-11  2:02   ` Stephen Rothwell
2017-07-11  2:03     ` Randy Dunlap
2017-07-11  2:09       ` [patches] " Palmer Dabbelt
2017-07-11  2:13         ` Randy Dunlap
2017-07-11  2:09     ` Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 02/17] pci: Add a generic, weakly-linked pcibios_align_resource Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 03/17] pci: Add a generic, weakly-linked pcibios_fixup_bus Palmer Dabbelt
2017-07-11 18:51   ` Luis R. Rodriguez
2017-07-11  1:39 ` [PATCH 04/17] MAINTAINERS: Add RISC-V Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 05/17] clocksource: New RISC-V SBI timer driver Palmer Dabbelt
2017-07-31 11:00   ` Daniel Lezcano [this message]
2017-08-01  1:14     ` Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 06/17] irqchip: RISC-V Local Interrupt Controller Driver Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 07/17] irqchip: New RISC-V PLIC Driver Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 08/17] tty: New RISC-V SBI console driver Palmer Dabbelt
2017-07-11  6:21   ` Michael Ellerman
2017-07-11 16:22     ` Palmer Dabbelt
2017-07-12 11:04       ` Michael Ellerman
2017-07-12 16:24         ` Palmer Dabbelt
2017-07-13 11:59           ` Michael Ellerman
2017-07-13 12:32             ` James Hogan
2017-07-13 21:50               ` Palmer Dabbelt
2017-07-14  5:07                 ` Michael Ellerman
2017-07-11  1:39 ` [PATCH 09/17] RISC-V: Init and Halt Code Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 10/17] RISC-V: Atomic and Locking Code Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 11/17] RISC-V: Generic library routines and assembly Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 12/17] RISC-V: ELF and module implementation Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 13/17] RISC-V: Task implementation Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 14/17] RISC-V: Device, timer, IRQs, and the SBI Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 15/17] RISC-V: Paging and MMU Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 16/17] RISC-V: User-facing API Palmer Dabbelt
2017-07-11 13:39   ` Christoph Hellwig
2017-07-11 14:01     ` James Hogan
2017-07-11 17:28       ` [patches] " Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 17/17] RISC-V: Build Infastructure Palmer Dabbelt
2017-07-11  6:31   ` Michael Ellerman
2017-07-11 16:22     ` Palmer Dabbelt
2017-07-12 10:44       ` Michael Ellerman
2017-07-11 18:39 ` RISC-V Linux Port v5 Luis R. Rodriguez
2017-07-11 19:50   ` Palmer Dabbelt
2017-07-12  1:31 RISC-V Linux Port v6 Palmer Dabbelt
2017-07-12  1:31 ` [PATCH 05/17] clocksource: New RISC-V SBI timer driver Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24a37ba4-df64-21c4-abec-18c0dbed0ab7@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=akpm@linux-foundation.org \
    --cc=albert@sifive.com \
    --cc=bart.vanassche@sandisk.com \
    --cc=boqun.feng@gmail.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=davem@davemloft.net \
    --cc=dledford@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=james.hogan@imgtec.com \
    --cc=jason@lakedaemon.net \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=marc.zyngier@arm.com \
    --cc=mcgrof@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mingo@redhat.com \
    --cc=mmarek@suse.com \
    --cc=mpe@ellerman.id.au \
    --cc=msalter@redhat.com \
    --cc=nicolas.dichtel@6wind.com \
    --cc=palmer@dabbelt.com \
    --cc=patches@groups.riscv.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=peterz@infradead.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=sfr@canb.auug.org.au \
    --cc=sstabellini@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=viro@zeniv.linux.org.uk \
    --cc=will.deacon@arm.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®