mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: sfr@canb.auug.org.au, yamada.masahiro@socionext.com,
	mmarek@suse.com, will.deacon@arm.com, peterz@infradead.org,
	boqun.feng@gmail.com, mingo@redhat.com,
	daniel.lezcano@linaro.org, tglx@linutronix.de,
	jason@lakedaemon.net, marc.zyngier@arm.com,
	gregkh@linuxfoundation.org, jslaby@suse.com, davem@davemloft.net,
	mchehab@kernel.org, fweisbec@gmail.com, viro@zeniv.linux.org.uk,
	mcgrof@kernel.org, dledford@redhat.com,
	bart.vanassche@sandisk.com, sstabellini@kernel.org,
	daniel.vetter@ffwll.ch, mpe@ellerman.id.au, msalter@redhat.com,
	nicolas.dichtel@6wind.com, james.hogan@imgtec.com,
	paul.gortmaker@windriver.com, linux@roeck-us.net,
	heiko.carstens@de.ibm.com, schwidefsky@de.ibm.com,
	linux-kernel@vger.kernel.org, patches@groups.riscv.org,
	akpm@linux-foundation.org, albert@sifive.com
Subject: Re: [patches] Re: [PATCH 01/17] lib: Add shared copies of some GCC library routines
Date: Mon, 10 Jul 2017 19:13:55 -0700	[thread overview]
Message-ID: <d46ee21b-a592-8058-8a76-5271f05cbf1f@infradead.org> (raw)
In-Reply-To: <mhng-7f0a7c72-1033-42db-a95c-528381a9984e@palmer-si-x1c4>

On 07/10/2017 07:09 PM, Palmer Dabbelt wrote:
> On Mon, 10 Jul 2017 19:03:44 PDT (-0700), rdunlap@infradead.org wrote:
>> On 07/10/2017 07:02 PM, Stephen Rothwell wrote:
>>> Hi Palmer,
>>>
>>> On Mon, 10 Jul 2017 18:39:08 -0700 Palmer Dabbelt <palmer@dabbelt.com> wrote:
>>>>
>>>> This patch adds a new copy of these library routine files, which are
>>>> functionally identical to the various other copies.  These are
>>>> availiable via Kconfig as CONFIG_LIB_$ROUTINE, which currently isn't
>>>
>>> Umm, the patch actually uses CONFIG_GENERIC_$ROUTINE.
>>>
>>>> +config GENERIC_ASHLDI3
>>>> +	def_bool n
>>>
>>> Just
>>> 	bool
>>> is the same.
>>>
>>
>> and several "default n" lines can (should) be removed from Kconfig.
> 
> I'm not much of a Kconfig hacker...  How does this look?
> 

Looks good.  Thanks.

> commit 4aaad1e6e8a70020dd95b8a13a4075af97cb858f
> Author: Palmer Dabbelt <palmer@dabbelt.com>
> Date:   Mon Jul 10 19:07:43 2017 -0700
> 
>     lib: Remove "default n" lines from Kconfig
> 
>     These lines aren't necessary, as the default is "n" anyway.
> 
>     Signed-off-by: Palmer Dabbelt <palmer@dabbelt.com>
> 
> diff --git a/lib/Kconfig b/lib/Kconfig
> index ee7d8bf0b7e1..78dec2408481 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -15,7 +15,6 @@ config BITREVERSE
> 
>  config HAVE_ARCH_BITREVERSE
>  	bool
> -	default n
>  	depends on BITREVERSE
>  	help
>  	  This option enables the use of hardware bit-reversal instructions on
> @@ -48,7 +47,6 @@ config GENERIC_IOMAP
> 
>  config GENERIC_IO
>  	bool
> -	default n
> 
>  config STMP_DEVICE
>  	bool
> @@ -199,7 +197,6 @@ config AUDIT_GENERIC
> 
>  config AUDIT_ARCH_COMPAT_GENERIC
>  	bool
> -	default n
> 
>  config AUDIT_COMPAT_GENERIC
>  	bool
> @@ -208,7 +205,6 @@ config AUDIT_COMPAT_GENERIC
> 
>  config RANDOM32_SELFTEST
>  	bool "PRNG perform self test on init"
> -	default n
>  	help
>  	  This option enables the 32 bit PRNG library functions to perform a
>  	  self test on initialization.
> @@ -405,12 +401,10 @@ config HAS_DMA
>  config DMA_NOOP_OPS
>  	bool
>  	depends on HAS_DMA && (!64BIT || ARCH_DMA_ADDR_T_64BIT)
> -	default n
> 
>  config DMA_VIRT_OPS
>  	bool
>  	depends on HAS_DMA && (!64BIT || ARCH_DMA_ADDR_T_64BIT)
> -	default n
> 
>  config CHECK_SIGNATURE
>  	bool
> 


-- 
~Randy

  reply	other threads:[~2017-07-11  2:14 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-11  1:39 RISC-V Linux Port v5 Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 01/17] lib: Add shared copies of some GCC library routines Palmer Dabbelt
2017-07-11  2:02   ` Stephen Rothwell
2017-07-11  2:03     ` Randy Dunlap
2017-07-11  2:09       ` [patches] " Palmer Dabbelt
2017-07-11  2:13         ` Randy Dunlap [this message]
2017-07-11  2:09     ` Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 02/17] pci: Add a generic, weakly-linked pcibios_align_resource Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 03/17] pci: Add a generic, weakly-linked pcibios_fixup_bus Palmer Dabbelt
2017-07-11 18:51   ` Luis R. Rodriguez
2017-07-11  1:39 ` [PATCH 04/17] MAINTAINERS: Add RISC-V Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 05/17] clocksource: New RISC-V SBI timer driver Palmer Dabbelt
2017-07-31 11:00   ` Daniel Lezcano
2017-08-01  1:14     ` Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 06/17] irqchip: RISC-V Local Interrupt Controller Driver Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 07/17] irqchip: New RISC-V PLIC Driver Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 08/17] tty: New RISC-V SBI console driver Palmer Dabbelt
2017-07-11  6:21   ` Michael Ellerman
2017-07-11 16:22     ` Palmer Dabbelt
2017-07-12 11:04       ` Michael Ellerman
2017-07-12 16:24         ` Palmer Dabbelt
2017-07-13 11:59           ` Michael Ellerman
2017-07-13 12:32             ` James Hogan
2017-07-13 21:50               ` Palmer Dabbelt
2017-07-14  5:07                 ` Michael Ellerman
2017-07-11  1:39 ` [PATCH 09/17] RISC-V: Init and Halt Code Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 10/17] RISC-V: Atomic and Locking Code Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 11/17] RISC-V: Generic library routines and assembly Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 12/17] RISC-V: ELF and module implementation Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 13/17] RISC-V: Task implementation Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 14/17] RISC-V: Device, timer, IRQs, and the SBI Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 15/17] RISC-V: Paging and MMU Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 16/17] RISC-V: User-facing API Palmer Dabbelt
2017-07-11 13:39   ` Christoph Hellwig
2017-07-11 14:01     ` James Hogan
2017-07-11 17:28       ` [patches] " Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 17/17] RISC-V: Build Infastructure Palmer Dabbelt
2017-07-11  6:31   ` Michael Ellerman
2017-07-11 16:22     ` Palmer Dabbelt
2017-07-12 10:44       ` Michael Ellerman
2017-07-11 18:39 ` RISC-V Linux Port v5 Luis R. Rodriguez
2017-07-11 19:50   ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d46ee21b-a592-8058-8a76-5271f05cbf1f@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=albert@sifive.com \
    --cc=bart.vanassche@sandisk.com \
    --cc=boqun.feng@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=davem@davemloft.net \
    --cc=dledford@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=james.hogan@imgtec.com \
    --cc=jason@lakedaemon.net \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=marc.zyngier@arm.com \
    --cc=mcgrof@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mingo@redhat.com \
    --cc=mmarek@suse.com \
    --cc=mpe@ellerman.id.au \
    --cc=msalter@redhat.com \
    --cc=nicolas.dichtel@6wind.com \
    --cc=palmer@dabbelt.com \
    --cc=patches@groups.riscv.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=peterz@infradead.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=sfr@canb.auug.org.au \
    --cc=sstabellini@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=viro@zeniv.linux.org.uk \
    --cc=will.deacon@arm.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®