[PATCH] gitignore: Don't ignore 'tags' directory

[PATCH] gitignore: Don't ignore 'tags' directory

[Li Zhijian]

LKP reported warnings [1] regarding files being ignored:
   tools/testing/selftests/arm64/tags/.gitignore: warning: ignored by one of the .gitignore files
   tools/testing/selftests/arm64/tags/Makefile: warning: ignored by one of the .gitignore files
   tools/testing/selftests/arm64/tags/tags_test.c: warning: ignored by one of the .gitignore files

These warnings were generated by ./scripts/misc-check. Although these files
are tracked by Git and the warnings are false positives, adjusting the
.gitignore entries will prevent these warnings and ensure a smoother script
execution.

[1] https://lore.kernel.org/linux-kselftest/202411251308.Vjm5MzVC-lkp@intel.com/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
---
 .gitignore | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.gitignore b/.gitignore
index 56972adb5031..e63dbba823cd 100644
--- a/.gitignore
+++ b/.gitignore
@@ -130,6 +130,9 @@ series
 tags
 TAGS
 
+# don't ignore 'tags' directory
+!tags/
+
 # cscope files
 cscope.*
 ncscope.*
-- 
2.44.0

Re: [PATCH] gitignore: Don't ignore 'tags' directory

[Masahiro Yamada]

On Mon, Nov 25, 2024 at 4:23 PM Li Zhijian <lizhijian@fujitsu.com> wrote:
>
> LKP reported warnings [1] regarding files being ignored:
>    tools/testing/selftests/arm64/tags/.gitignore: warning: ignored by one of the .gitignore files
>    tools/testing/selftests/arm64/tags/Makefile: warning: ignored by one of the .gitignore files
>    tools/testing/selftests/arm64/tags/tags_test.c: warning: ignored by one of the .gitignore files
>
> These warnings were generated by ./scripts/misc-check. Although these files
> are tracked by Git and the warnings are false positives, adjusting the
> .gitignore entries will prevent these warnings and ensure a smoother script
> execution.

You do not need to mention a special tool because you can see them
when building the kernel with W=1.

You can say "Building the kernel with W=1 shows ..."



>
> [1] https://lore.kernel.org/linux-kselftest/202411251308.Vjm5MzVC-lkp@intel.com/
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
>  .gitignore | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index 56972adb5031..e63dbba823cd 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -130,6 +130,9 @@ series
>  tags
>  TAGS

Unfortunately, GIT does not support "only match to regular files",
but you can make the intention clearer:


# ctags files
tags
!tags/
TAGS



You can add "!tags/" right below "tags".
Then, your comment is unnecessary.


-- 
Best Regards
Masahiro Yamada

Re: [PATCH] gitignore: Don't ignore 'tags' directory

[Zhijian Li (Fujitsu)]

On 25/11/2024 16:21, Masahiro Yamada wrote:
> On Mon, Nov 25, 2024 at 4:23 PM Li Zhijian <lizhijian@fujitsu.com> wrote:
>>
>> LKP reported warnings [1] regarding files being ignored:
>>     tools/testing/selftests/arm64/tags/.gitignore: warning: ignored by one of the .gitignore files
>>     tools/testing/selftests/arm64/tags/Makefile: warning: ignored by one of the .gitignore files
>>     tools/testing/selftests/arm64/tags/tags_test.c: warning: ignored by one of the .gitignore files
>>
>> These warnings were generated by ./scripts/misc-check. Although these files
>> are tracked by Git and the warnings are false positives, adjusting the
>> .gitignore entries will prevent these warnings and ensure a smoother script
>> execution.
> 
> You do not need to mention a special tool because you can see them
> when building the kernel with W=1.
> 
> You can say "Building the kernel with W=1 shows ..."
> 
> 
> 
>>
>> [1] https://lore.kernel.org/linux-kselftest/202411251308.Vjm5MzVC-lkp@intel.com/
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
>> ---
>>   .gitignore | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/.gitignore b/.gitignore
>> index 56972adb5031..e63dbba823cd 100644
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -130,6 +130,9 @@ series
>>   tags
>>   TAGS
> 
> Unfortunately, GIT does not support "only match to regular files",
> but you can make the intention clearer:
> 
> 
> # ctags files
> tags
> !tags/
> TAGS
> 
> 
> 
> You can add "!tags/" right below "tags".> Then, your comment is unnecessary.

Thanks for your quickly review, i will update it soon

Thanks
Zhijian

> 
>