Re: accel/amdxdna: Fix incorrect command state for timed out job

[Lizhi Hou <lizhi.hou@amd.com>]

On 10/29/25 11:54, Markus Elfring wrote:
>>> https://elixir.bootlin.com/linux/v6.18-rc3/C/ident/amdxdna_cmd_set_state
>> Sure. amdxdna_cmd_set_state() updates the return code to command buffer. So application which issues the command will be able to get the return code.
>>
>> The function return value "ret" is used by mailbox receiving kernel thread to deal with the error.
> I miss a clearer answer for the indicated function call incidence.
>
> Can it be helpful to determine the state value before it would be passed to a concrete call?

aie2_sched_resp_handler() is called either after get the firmware 
response through mailbox or the request is timed out/ canceled. So in 
this handler, it based on the response to set the state field in command 
buffer.

What do you mean here for "determine the state value before it would be 
passed to a concrete call?". What is your concern here? Maybe you can 
provide a simple patch if you think there is anything can be improved?


Thanks,

Lizhi

>
> Regards,
> Markus