From: Lizhi Hou <lizhi.hou@amd.com>
To: Markus Elfring <Markus.Elfring@web.de>,
<dri-devel@lists.freedesktop.org>,
Jeffrey Hugo <quic_jhugo@quicinc.com>,
Maciej Falkowski <maciej.falkowski@linux.intel.com>,
Oded Gabbay <ogabbay@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Mario Limonciello <mario.limonciello@amd.com>,
Max Zhen <max.zhen@amd.com>, Sonal Santan <sonal.santan@amd.com>
Subject: Re: accel/amdxdna: Fix incorrect command state for timed out job
Date: Tue, 28 Oct 2025 14:00:12 -0700 [thread overview]
Message-ID: <b2cf67a4-6795-d743-e90b-db10f636db2e@amd.com> (raw)
In-Reply-To: <3dd7e061-8e6f-4d3d-b56c-7005da8197f6@web.de>
On 10/28/25 13:43, Markus Elfring wrote:
>>>> When a command times out, mark it as ERT_CMD_STATE_TIMEOUT. Any other
>>>> commands that are canceled due to this timeout should be marked as
>>>> ERT_CMD_STATE_ABORT.
>>> Would it become helpful to use additional labels for the same state settings?
>>> https://elixir.bootlin.com/linux/v6.18-rc3/source/drivers/accel/amdxdna/aie2_ctx.c#L197-L226
>> I do not fully understand your comment. Could you explain more?
> Do you propose to use the same state settings in a few if branches?
What are the same state settings?
> How do you think about to avoid duplicate statements accordingly?
What are the duplicate statements?
Sorry that I am still a little confused.
The code change is to distinguish between the job which is timed out
and the job is aborted.
Thanks,
Lizhi
>
> Regards,
> Markus
next prev parent reply other threads:[~2025-10-28 21:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 17:54 [PATCH] " Lizhi Hou
2025-10-28 20:30 ` Markus Elfring
2025-10-28 20:39 ` Lizhi Hou
2025-10-28 20:43 ` Markus Elfring
2025-10-28 21:00 ` Lizhi Hou [this message]
2025-10-29 7:53 ` Markus Elfring
2025-10-29 18:38 ` Lizhi Hou
2025-10-29 18:54 ` Markus Elfring
2025-10-29 19:17 ` Lizhi Hou
2025-10-29 19:25 ` Markus Elfring
2025-10-29 10:40 ` Markus Elfring
2025-10-29 18:43 ` Lizhi Hou
2025-10-29 14:28 ` [PATCH] " Mario Limonciello
2025-10-29 19:05 ` Lizhi Hou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2cf67a4-6795-d743-e90b-db10f636db2e@amd.com \
--to=lizhi.hou@amd.com \
--cc=Markus.Elfring@web.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.falkowski@linux.intel.com \
--cc=mario.limonciello@amd.com \
--cc=max.zhen@amd.com \
--cc=ogabbay@kernel.org \
--cc=quic_jhugo@quicinc.com \
--cc=sonal.santan@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®