From: Lizhi Hou <lizhi.hou@amd.com>
To: Markus Elfring <Markus.Elfring@web.de>,
<dri-devel@lists.freedesktop.org>,
Jeffrey Hugo <quic_jhugo@quicinc.com>,
Maciej Falkowski <maciej.falkowski@linux.intel.com>,
Oded Gabbay <ogabbay@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Mario Limonciello <mario.limonciello@amd.com>,
Max Zhen <max.zhen@amd.com>, Sonal Santan <sonal.santan@amd.com>
Subject: Re: accel/amdxdna: Fix incorrect command state for timed out job
Date: Wed, 29 Oct 2025 11:38:51 -0700 [thread overview]
Message-ID: <e4c8b7be-588d-b0b7-00ca-e60cbde034a6@amd.com> (raw)
In-Reply-To: <6238912a-8733-4b2c-a155-82bb081e6063@web.de>
On 10/29/25 00:53, Markus Elfring wrote:
>> What are the duplicate statements?
>>
>> Sorry that I am still a little confused.
>>
>>
>> The code change is to distinguish between the job which is timed out and the job is aborted.
> Would you like to clarify the usage incidence for amdxdna_cmd_set_state() calls
> in combination with assignments to the variable “ret” (according to the implementation
> of the affected function “aie2_sched_resp_handler”)?
> https://elixir.bootlin.com/linux/v6.18-rc3/C/ident/amdxdna_cmd_set_state
Sure. amdxdna_cmd_set_state() updates the return code to command buffer.
So application which issues the command will be able to get the return code.
The function return value "ret" is used by mailbox receiving kernel
thread to deal with the error.
Thanks,
Lizhi
>
> Regards,
> Markus
next prev parent reply other threads:[~2025-10-29 18:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 17:54 [PATCH] " Lizhi Hou
2025-10-28 20:30 ` Markus Elfring
2025-10-28 20:39 ` Lizhi Hou
2025-10-28 20:43 ` Markus Elfring
2025-10-28 21:00 ` Lizhi Hou
2025-10-29 7:53 ` Markus Elfring
2025-10-29 18:38 ` Lizhi Hou [this message]
2025-10-29 18:54 ` Markus Elfring
2025-10-29 19:17 ` Lizhi Hou
2025-10-29 19:25 ` Markus Elfring
2025-10-29 10:40 ` Markus Elfring
2025-10-29 18:43 ` Lizhi Hou
2025-10-29 14:28 ` [PATCH] " Mario Limonciello
2025-10-29 19:05 ` Lizhi Hou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4c8b7be-588d-b0b7-00ca-e60cbde034a6@amd.com \
--to=lizhi.hou@amd.com \
--cc=Markus.Elfring@web.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.falkowski@linux.intel.com \
--cc=mario.limonciello@amd.com \
--cc=max.zhen@amd.com \
--cc=ogabbay@kernel.org \
--cc=quic_jhugo@quicinc.com \
--cc=sonal.santan@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®