From: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: ipq5332: Move PHYs and PERST# to Root Port node
Date: Tue, 9 Jun 2026 10:55:23 +0530 [thread overview]
Message-ID: <26374aa0-1db0-4d90-9cec-b546df598155@oss.qualcomm.com> (raw)
In-Reply-To: <c59579b0-8c88-444d-947b-615a623f42ce@oss.qualcomm.com>
On 6/8/2026 3:52 PM, Konrad Dybcio wrote:
> On 6/2/26 6:34 PM, Kathiravan Thirumoorthy wrote:
>> Follow the new binding style by defining PHYs and PERST# (now RESET#)
>> under the Root Port node. Avoid mixing styles and move these properties
>> to the RP node.
>>
>> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
>> ---
> [...]
>
>>
>> - pcie@0 {
>> + pcie1_port0: pcie@0 {
>> device_type = "pci";
>> reg = <0x0 0x0 0x0 0x0 0x0>;
>>
>> #address-cells = <3>;
>> #size-cells = <2>;
>> ranges;
>> + phys = <&pcie1_phy>;
> nit: other socs (like hamoa) do it like this:
>
> pcie3_port0: pcie@0 {
> device_type = "pci";
> compatible = "pciclass,0604";
> reg = <0x0 0x0 0x0 0x0 0x0>;
> bus-range = <0x01 0xff>;
>
> phys = <&pcie3_phy>;
>
> #address-cells = <3>;
> #size-cells = <2>;
> ranges;
> };
Ack. Let me add the 'bus-range' property and move the 'phys' next to it.
> Konrad
next prev parent reply other threads:[~2026-06-09 5:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 16:34 [PATCH 0/2] Move PHYs and PERST# properties to PCIe RP node Kathiravan Thirumoorthy
2026-06-02 16:34 ` [PATCH 1/2] arm64: dts: qcom: ipq5332: Move PHYs and PERST# to Root Port node Kathiravan Thirumoorthy
2026-06-07 20:11 ` Dmitry Baryshkov
2026-06-08 10:22 ` Konrad Dybcio
2026-06-09 5:25 ` Kathiravan Thirumoorthy [this message]
2026-06-09 5:35 ` Kathiravan Thirumoorthy
2026-06-02 16:34 ` [PATCH 2/2] arm64: dts: qcom: ipq5424: " Kathiravan Thirumoorthy
2026-06-07 20:22 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26374aa0-1db0-4d90-9cec-b546df598155@oss.qualcomm.com \
--to=kathiravan.thirumoorthy@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®