Re: [PATCH 1/2] arm64: dts: qcom: ipq5332: Move PHYs and PERST# to Root Port node

[Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>]

On 6/9/2026 10:55 AM, Kathiravan Thirumoorthy wrote:
>
> On 6/8/2026 3:52 PM, Konrad Dybcio wrote:
>> On 6/2/26 6:34 PM, Kathiravan Thirumoorthy wrote:
>>> Follow the new binding style by defining PHYs and PERST# (now RESET#)
>>> under the Root Port node. Avoid mixing styles and move these properties
>>> to the RP node.
>>>
>>> Signed-off-by: Kathiravan Thirumoorthy 
>>> <kathiravan.thirumoorthy@oss.qualcomm.com>
>>> ---
>> [...]
>>
>>>   -            pcie@0 {
>>> +            pcie1_port0: pcie@0 {
>>>                   device_type = "pci";
>>>                   reg = <0x0 0x0 0x0 0x0 0x0>;
>>>                     #address-cells = <3>;
>>>                   #size-cells = <2>;
>>>                   ranges;
>>> +                phys = <&pcie1_phy>;
>> nit: other socs (like hamoa) do it like this:
>>
>> pcie3_port0: pcie@0 {
>>     device_type = "pci";
>>     compatible = "pciclass,0604";
>>     reg = <0x0 0x0 0x0 0x0 0x0>;
>>     bus-range = <0x01 0xff>;
>>
>>     phys = <&pcie3_phy>;
>>
>>     #address-cells = <3>;
>>     #size-cells = <2>;
>>     ranges;
>> };
>
> Ack. Let me add the 'bus-range' property and move the 'phys' next to it.

Just checked the history, it is dropped due to default values. Given 
that, let me move the 'phys' before #address-cells property.

>
>> Konrad