From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linaro-kernel@lists.linaro.org, patches@linaro.org,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, srivatsa.bhat@linux.vnet.ibm.com,
l.majewski@samsung.com
Subject: Re: [PATCH 08/10] cpufreq: Fix broken usage of governor->owner's refcount
Date: Sun, 04 Aug 2013 00:06:40 +0200 [thread overview]
Message-ID: <2637835.0QndCQ8FcY@vostro.rjw.lan> (raw)
In-Reply-To: <CAKohpokdWMjeZ=GKt4SaJDaA4Dn-WODpE_Mn+VEBpxB=VNAuyw@mail.gmail.com>
On Saturday, August 03, 2013 06:57:11 PM Viresh Kumar wrote:
> On 3 August 2013 17:38, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > On Saturday, August 03, 2013 05:19:26 PM Viresh Kumar wrote:
> >> Governor's owner refcount usage was broken. We should increment refcount only
> >> when CPUFREQ_GOV_POLICY_INIT event has come and should decrement only if
> >> CPUFREQ_GOV_POLICY_EXIT has come.
> >>
> >> Lets fix it.
> >
> > OK, and what happens if we don't fix it?
>
> What about this changelog:
>
> Subject: [PATCH 08/10] cpufreq: Fix broken usage of governor->owner's
> refcount
>
> Governor's owner refcount usage was broken. We should increment refcount only
> when CPUFREQ_GOV_POLICY_INIT event has come and should decrement only if
> CPUFREQ_GOV_POLICY_EXIT has come.
>
> Currently there can be situations where governor is in use but we have allowed
> it to be unloaded. And that may cause in undefined behavior.
"it to be unloaded which may result in undefined behavior."
>
> Lets fix it.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Apart from the above looks good.
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2013-08-03 21:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-03 11:49 [PATCH 00/10] CPUFreq: Fixes & Cleanups for 3.12 Viresh Kumar
2013-08-03 11:49 ` [PATCH 01/10] cpufreq: Cleanup header files included in core Viresh Kumar
2013-08-03 17:15 ` Viresh Kumar
2013-08-03 21:42 ` Rafael J. Wysocki
2013-08-03 11:49 ` [PATCH 02/10] cpufreq: Re-arrange declarations in cpufreq.h Viresh Kumar
2013-08-03 17:13 ` Viresh Kumar
2013-08-03 21:43 ` Rafael J. Wysocki
2013-08-03 11:49 ` [PATCH 03/10] cpufreq: Give consistent names for struct cpufreq_policy * Viresh Kumar
2013-08-06 13:38 ` Viresh Kumar
2013-08-06 14:02 ` Rafael J. Wysocki
2013-08-03 11:49 ` [PATCH 04/10] cpufreq: Use sizeof(*ptr) form for finding size of a struct Viresh Kumar
2013-08-03 11:49 ` [PATCH 05/10] cpufreq: Pass policy to cpufreq_add_policy_cpu() Viresh Kumar
2013-08-03 11:49 ` [PATCH 06/10] cpufreq: Store cpufreq policies in a list Viresh Kumar
2013-08-03 11:49 ` [PATCH 07/10] cpufreq: Use cpufreq_policy_list for iterating over policies Viresh Kumar
2013-08-03 11:49 ` [PATCH 08/10] cpufreq: Fix broken usage of governor->owner's refcount Viresh Kumar
2013-08-03 12:08 ` Rafael J. Wysocki
2013-08-03 13:27 ` Viresh Kumar
2013-08-03 22:06 ` Rafael J. Wysocki [this message]
2013-08-03 11:49 ` [PATCH 09/10] cpufreq: Don't use cpufreq_driver->owner's refcount to protect critical sections Viresh Kumar
2013-08-03 11:49 ` [PATCH 10/10] cpufreq: Remove struct cpufreq_driver's owner field Viresh Kumar
2013-08-03 12:07 ` [PATCH 00/10] CPUFreq: Fixes & Cleanups for 3.12 Rafael J. Wysocki
2013-08-03 13:28 ` Viresh Kumar
2013-08-03 22:02 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2637835.0QndCQ8FcY@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=cpufreq@vger.kernel.org \
--cc=l.majewski@samsung.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®