mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Werner Sembach <wse@tuxedocomputers.com>
To: "Armin Wolf" <W_Armin@gmx.de>,
	"Mohamed Jouini" <amad3v@gmail.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Christoffer Sandberg" <cs@tuxedo.de>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] platform/x86: uniwill-laptop: Map the screen rotation key
Date: Wed, 30 Sep 2026 01:22:28 +0200	[thread overview]
Message-ID: <263ec1ec-181a-4f96-92f4-25674559e961@tuxedocomputers.com> (raw)
In-Reply-To: <94e5619d-02eb-4b55-bfcb-67964ee1def3@gmx.de>


Am 26.09.26 um 01:52 schrieb Armin Wolf:
> Am 25.09.26 um 23:16 schrieb Mohamed Jouini:
>
>> The PCSpecialist Recoil 16 AMD / TUXEDO Stellaris 16 Gen7 chassis has an
>> "Sc" key next to F12, meant to rotate the lay-flat screen by 180 degrees.
>> It reports WMI event 0xD0, which is currently reported as KEY_UNKNOWN.
>> Map it to KEY_ROTATE_DISPLAY.
>
> Unless Tuxedo know more about this event code:
don't have the device at hand so pulled christoffer in the loop
>
> Reviewed-by: Armin Wolf <W_Armin@gmx.de>
>
>> Signed-off-by: Mohamed Jouini <amad3v@gmail.com>
>> ---
>>   drivers/platform/x86/uniwill/uniwill-acpi.c | 3 +++
>>   drivers/platform/x86/uniwill/uniwill-wmi.h  | 3 +++
>>   2 files changed, 6 insertions(+)
>>
>> diff --git a/drivers/platform/x86/uniwill/uniwill-acpi.c 
>> b/drivers/platform/x86/uniwill/uniwill-acpi.c
>> index 0932e5937..f99c5e9ac 100644
>> --- a/drivers/platform/x86/uniwill/uniwill-acpi.c
>> +++ b/drivers/platform/x86/uniwill/uniwill-acpi.c
>> @@ -519,6 +519,9 @@ static const struct key_entry uniwill_keymap[] = {
>>       /* Reported when the user wants to toggle the webcam */
>>       { KE_IGNORE,    UNIWILL_OSD_WEBCAM_TOGGLE,              { KEY_UNKNOWN }},
>>   +    /* Reported when the user wants to rotate the (lay-flat) screen by 180 
>> degrees */
>> +    { KE_KEY,       UNIWILL_OSD_ROTATE_SCREEN,              { 
>> KEY_ROTATE_DISPLAY }},
>> +
>>       { KE_END }
>>   };
>>   diff --git a/drivers/platform/x86/uniwill/uniwill-wmi.h 
>> b/drivers/platform/x86/uniwill/uniwill-wmi.h
>> index b25b2f312..1b6f650c4 100644
>> --- a/drivers/platform/x86/uniwill/uniwill-wmi.h
>> +++ b/drivers/platform/x86/uniwill/uniwill-wmi.h
>> @@ -117,6 +117,9 @@
>>     #define UNIWILL_OSD_WEBCAM_TOGGLE        0xCF
>>   +/* "Sc" key next to F12 on the PCSpecialist Recoil 16 / Stellaris 16 Gen7 */
>> +#define UNIWILL_OSD_ROTATE_SCREEN        0xD0
>> +
>>   #define UNIWILL_OSD_KBD_BACKLIGHT_CHANGED    0xF0
>>     struct device;

  reply	other threads:[~2026-09-29 23:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-25 21:16 [PATCH 0/3] platform/x86: uniwill-laptop: Support the PCSpecialist Recoil 16 AMD Mohamed Jouini
2026-09-25 21:16 ` [PATCH 1/3] platform/x86: uniwill-laptop: Add " Mohamed Jouini
2026-09-25 23:44   ` Armin Wolf
2026-09-26  0:24     ` Am Dev
2026-09-25 21:16 ` [PATCH 2/3] platform/x86: uniwill-laptop: Add platform profile support Mohamed Jouini
2026-09-25 23:54   ` Armin Wolf
2026-09-26  0:33     ` Am Dev
2026-09-25 21:16 ` [PATCH 3/3] platform/x86: uniwill-laptop: Map the screen rotation key Mohamed Jouini
2026-09-25 23:52   ` Armin Wolf
2026-09-29 23:22     ` Werner Sembach [this message]
2026-10-01  9:01       ` Christoffer Sandberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=263ec1ec-181a-4f96-92f4-25674559e961@tuxedocomputers.com \
    --to=wse@tuxedocomputers.com \
    --cc=W_Armin@gmx.de \
    --cc=amad3v@gmail.com \
    --cc=cs@tuxedo.de \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®