* [PATCH] afs: remove redundant assignment of dvnode to itself
@ 2017-11-20 13:58 Colin King
2017-11-20 22:20 ` David Howells
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-11-20 13:58 UTC (permalink / raw)
To: David Howells, linux-afs, linux-kernel; +Cc: kernel-janitors
From: Colin Ian King <colin.king@canonical.com>
The assignment of dvnode to itself is redundant and can be removed.
Cleans up warning detected by cppcheck:
fs/afs/dir.c:975: (warning) Redundant assignment of 'dvnode' to itself.
Fixes: d2ddc776a458 ("afs: Overhaul volume and server record caching and fileserver rotation")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/afs/dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/afs/dir.c b/fs/afs/dir.c
index ab618d32554c..a5e121e55e57 100644
--- a/fs/afs/dir.c
+++ b/fs/afs/dir.c
@@ -972,7 +972,7 @@ static int afs_create(struct inode *dir, struct dentry *dentry, umode_t mode,
struct afs_fs_cursor fc;
struct afs_file_status newstatus;
struct afs_callback newcb;
- struct afs_vnode *dvnode = dvnode = AFS_FS_I(dir);
+ struct afs_vnode *dvnode = AFS_FS_I(dir);
struct afs_fid newfid;
struct key *key;
int ret;
--
2.14.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] afs: remove redundant assignment of dvnode to itself
2017-11-20 13:58 [PATCH] afs: remove redundant assignment of dvnode to itself Colin King
@ 2017-11-20 22:20 ` David Howells
0 siblings, 0 replies; 2+ messages in thread
From: David Howells @ 2017-11-20 22:20 UTC (permalink / raw)
To: Colin King; +Cc: dhowells, linux-afs, linux-kernel, kernel-janitors
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The assignment of dvnode to itself is redundant and can be removed.
> Cleans up warning detected by cppcheck:
>
> fs/afs/dir.c:975: (warning) Redundant assignment of 'dvnode' to itself.
>
> Fixes: d2ddc776a458 ("afs: Overhaul volume and server record caching and fileserver rotation")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
David
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-20 22:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-20 13:58 [PATCH] afs: remove redundant assignment of dvnode to itself Colin King
2017-11-20 22:20 ` David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®