* [PATCH] drm/shmem-helper: Revert accidental non-GPL export
@ 2023-02-27 9:04 Asahi Lina
2023-02-27 9:07 ` Thomas Zimmermann
2023-02-28 9:14 ` Thomas Zimmermann
0 siblings, 2 replies; 4+ messages in thread
From: Asahi Lina @ 2023-02-27 9:04 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter, Javier Martinez Canillas
Cc: Noralf Trønnes, Rob Herring, Alyssa Rosenzweig,
Dmitry Osipenko, dri-devel, linux-kernel, Asahi Lina
The referenced commit added a wrapper for drm_gem_shmem_get_pages_sgt(),
but in the process it accidentally changed the export type from GPL to
non-GPL. Switch it back to GPL.
Reported-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Fixes: ddddedaa0db9 ("drm/shmem-helper: Fix locking for drm_gem_shmem_get_pages_sgt()")
Signed-off-by: Asahi Lina <lina@asahilina.net>
---
drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
index 7e5c6a8d0212..75185a960fc4 100644
--- a/drivers/gpu/drm/drm_gem_shmem_helper.c
+++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
@@ -744,7 +744,7 @@ struct sg_table *drm_gem_shmem_get_pages_sgt(struct drm_gem_shmem_object *shmem)
return sgt;
}
-EXPORT_SYMBOL(drm_gem_shmem_get_pages_sgt);
+EXPORT_SYMBOL_GPL(drm_gem_shmem_get_pages_sgt);
/**
* drm_gem_shmem_prime_import_sg_table - Produce a shmem GEM object from
---
base-commit: f3a2439f20d918930cc4ae8f76fe1c1afd26958f
change-id: 20230227-shmem-export-fix-85fde1351104
Thank you,
~~ Lina
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/shmem-helper: Revert accidental non-GPL export
2023-02-27 9:04 [PATCH] drm/shmem-helper: Revert accidental non-GPL export Asahi Lina
@ 2023-02-27 9:07 ` Thomas Zimmermann
2023-02-27 9:13 ` Javier Martinez Canillas
2023-02-28 9:14 ` Thomas Zimmermann
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Zimmermann @ 2023-02-27 9:07 UTC (permalink / raw)
To: Asahi Lina, Maarten Lankhorst, Maxime Ripard, David Airlie,
Daniel Vetter, Javier Martinez Canillas
Cc: Noralf Trønnes, Rob Herring, Alyssa Rosenzweig,
Dmitry Osipenko, dri-devel, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1604 bytes --]
Hi
Am 27.02.23 um 10:04 schrieb Asahi Lina:
> The referenced commit added a wrapper for drm_gem_shmem_get_pages_sgt(),
> but in the process it accidentally changed the export type from GPL to
> non-GPL. Switch it back to GPL.
>
> Reported-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> Fixes: ddddedaa0db9 ("drm/shmem-helper: Fix locking for drm_gem_shmem_get_pages_sgt()")
> Signed-off-by: Asahi Lina <lina@asahilina.net>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Thanks a lot. I'll add your patch to drm-misc-fixes ASAP.
Best regards
Thomas
> ---
> drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
> index 7e5c6a8d0212..75185a960fc4 100644
> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c
> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
> @@ -744,7 +744,7 @@ struct sg_table *drm_gem_shmem_get_pages_sgt(struct drm_gem_shmem_object *shmem)
>
> return sgt;
> }
> -EXPORT_SYMBOL(drm_gem_shmem_get_pages_sgt);
> +EXPORT_SYMBOL_GPL(drm_gem_shmem_get_pages_sgt);
>
> /**
> * drm_gem_shmem_prime_import_sg_table - Produce a shmem GEM object from
>
> ---
> base-commit: f3a2439f20d918930cc4ae8f76fe1c1afd26958f
> change-id: 20230227-shmem-export-fix-85fde1351104
>
> Thank you,
> ~~ Lina
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/shmem-helper: Revert accidental non-GPL export
2023-02-27 9:07 ` Thomas Zimmermann
@ 2023-02-27 9:13 ` Javier Martinez Canillas
0 siblings, 0 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2023-02-27 9:13 UTC (permalink / raw)
To: Thomas Zimmermann, Asahi Lina, Maarten Lankhorst, Maxime Ripard,
David Airlie, Daniel Vetter
Cc: Noralf Trønnes, Rob Herring, Alyssa Rosenzweig,
Dmitry Osipenko, dri-devel, linux-kernel
Thomas Zimmermann <tzimmermann@suse.de> writes:
> Hi
>
> Am 27.02.23 um 10:04 schrieb Asahi Lina:
>> The referenced commit added a wrapper for drm_gem_shmem_get_pages_sgt(),
>> but in the process it accidentally changed the export type from GPL to
>> non-GPL. Switch it back to GPL.
>>
>> Reported-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>> Fixes: ddddedaa0db9 ("drm/shmem-helper: Fix locking for drm_gem_shmem_get_pages_sgt()")
>> Signed-off-by: Asahi Lina <lina@asahilina.net>
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> Thanks a lot. I'll add your patch to drm-misc-fixes ASAP.
>
Thanks for fixing this and sorry that I missed it during review.
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/shmem-helper: Revert accidental non-GPL export
2023-02-27 9:04 [PATCH] drm/shmem-helper: Revert accidental non-GPL export Asahi Lina
2023-02-27 9:07 ` Thomas Zimmermann
@ 2023-02-28 9:14 ` Thomas Zimmermann
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Zimmermann @ 2023-02-28 9:14 UTC (permalink / raw)
To: Asahi Lina, Maarten Lankhorst, Maxime Ripard, David Airlie,
Daniel Vetter, Javier Martinez Canillas
Cc: Noralf Trønnes, Rob Herring, Alyssa Rosenzweig,
Dmitry Osipenko, dri-devel, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1488 bytes --]
Added to drm-misc-next-fixes.
Am 27.02.23 um 10:04 schrieb Asahi Lina:
> The referenced commit added a wrapper for drm_gem_shmem_get_pages_sgt(),
> but in the process it accidentally changed the export type from GPL to
> non-GPL. Switch it back to GPL.
>
> Reported-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> Fixes: ddddedaa0db9 ("drm/shmem-helper: Fix locking for drm_gem_shmem_get_pages_sgt()")
> Signed-off-by: Asahi Lina <lina@asahilina.net>
> ---
> drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
> index 7e5c6a8d0212..75185a960fc4 100644
> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c
> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
> @@ -744,7 +744,7 @@ struct sg_table *drm_gem_shmem_get_pages_sgt(struct drm_gem_shmem_object *shmem)
>
> return sgt;
> }
> -EXPORT_SYMBOL(drm_gem_shmem_get_pages_sgt);
> +EXPORT_SYMBOL_GPL(drm_gem_shmem_get_pages_sgt);
>
> /**
> * drm_gem_shmem_prime_import_sg_table - Produce a shmem GEM object from
>
> ---
> base-commit: f3a2439f20d918930cc4ae8f76fe1c1afd26958f
> change-id: 20230227-shmem-export-fix-85fde1351104
>
> Thank you,
> ~~ Lina
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-28 9:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-27 9:04 [PATCH] drm/shmem-helper: Revert accidental non-GPL export Asahi Lina
2023-02-27 9:07 ` Thomas Zimmermann
2023-02-27 9:13 ` Javier Martinez Canillas
2023-02-28 9:14 ` Thomas Zimmermann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®