* [PATCH] drm: exynos: constify mixer_match_types and *_mxr_drv_data. @ 2017-06-19 10:12 ` Arvind Yadav 2017-06-19 10:37 ` Andrzej Hajda 0 siblings, 1 reply; 2+ messages in thread From: Arvind Yadav @ 2017-06-19 10:12 UTC (permalink / raw) To: inki.dae, jy0922.shim, sw0312.kim, kyungmin.park, airlied, kgene, krzk, javier Cc: dri-devel, linux-arm-kernel, linux-samsung-soc, linux-kernel File size before: text data bss dec hex filename 9983 1424 0 11407 2c8f drivers/gpu/drm/exynos/exynos_mixer.o File size after constify: text data bss dec hex filename 11231 176 0 11407 2c8f drivers/gpu/drm/exynos/exynos_mixer.o Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- drivers/gpu/drm/exynos/exynos_mixer.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c index 25edb63..778cae2 100644 --- a/drivers/gpu/drm/exynos/exynos_mixer.c +++ b/drivers/gpu/drm/exynos/exynos_mixer.c @@ -1097,28 +1097,28 @@ static int mixer_atomic_check(struct exynos_drm_crtc *crtc, .atomic_check = mixer_atomic_check, }; -static struct mixer_drv_data exynos5420_mxr_drv_data = { +static const struct mixer_drv_data exynos5420_mxr_drv_data = { .version = MXR_VER_128_0_0_184, .is_vp_enabled = 0, }; -static struct mixer_drv_data exynos5250_mxr_drv_data = { +static const struct mixer_drv_data exynos5250_mxr_drv_data = { .version = MXR_VER_16_0_33_0, .is_vp_enabled = 0, }; -static struct mixer_drv_data exynos4212_mxr_drv_data = { +static const struct mixer_drv_data exynos4212_mxr_drv_data = { .version = MXR_VER_0_0_0_16, .is_vp_enabled = 1, }; -static struct mixer_drv_data exynos4210_mxr_drv_data = { +static const struct mixer_drv_data exynos4210_mxr_drv_data = { .version = MXR_VER_0_0_0_16, .is_vp_enabled = 1, .has_sclk = 1, }; -static struct of_device_id mixer_match_types[] = { +static const struct of_device_id mixer_match_types[] = { { .compatible = "samsung,exynos4210-mixer", .data = &exynos4210_mxr_drv_data, -- 1.9.1 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: exynos: constify mixer_match_types and *_mxr_drv_data. 2017-06-19 10:12 ` [PATCH] drm: exynos: constify mixer_match_types and *_mxr_drv_data Arvind Yadav @ 2017-06-19 10:37 ` Andrzej Hajda 0 siblings, 0 replies; 2+ messages in thread From: Andrzej Hajda @ 2017-06-19 10:37 UTC (permalink / raw) To: Arvind Yadav, inki.dae, jy0922.shim, sw0312.kim, kyungmin.park, airlied, kgene, krzk, javier Cc: dri-devel, linux-arm-kernel, linux-samsung-soc, linux-kernel On 19.06.2017 12:12, Arvind Yadav wrote: > File size before: > text data bss dec hex filename > 9983 1424 0 11407 2c8f drivers/gpu/drm/exynos/exynos_mixer.o > > File size after constify: > text data bss dec hex filename > 11231 176 0 11407 2c8f drivers/gpu/drm/exynos/exynos_mixer.o > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> -- Regards Andrzej > --- > drivers/gpu/drm/exynos/exynos_mixer.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c > index 25edb63..778cae2 100644 > --- a/drivers/gpu/drm/exynos/exynos_mixer.c > +++ b/drivers/gpu/drm/exynos/exynos_mixer.c > @@ -1097,28 +1097,28 @@ static int mixer_atomic_check(struct exynos_drm_crtc *crtc, > .atomic_check = mixer_atomic_check, > }; > > -static struct mixer_drv_data exynos5420_mxr_drv_data = { > +static const struct mixer_drv_data exynos5420_mxr_drv_data = { > .version = MXR_VER_128_0_0_184, > .is_vp_enabled = 0, > }; > > -static struct mixer_drv_data exynos5250_mxr_drv_data = { > +static const struct mixer_drv_data exynos5250_mxr_drv_data = { > .version = MXR_VER_16_0_33_0, > .is_vp_enabled = 0, > }; > > -static struct mixer_drv_data exynos4212_mxr_drv_data = { > +static const struct mixer_drv_data exynos4212_mxr_drv_data = { > .version = MXR_VER_0_0_0_16, > .is_vp_enabled = 1, > }; > > -static struct mixer_drv_data exynos4210_mxr_drv_data = { > +static const struct mixer_drv_data exynos4210_mxr_drv_data = { > .version = MXR_VER_0_0_0_16, > .is_vp_enabled = 1, > .has_sclk = 1, > }; > > -static struct of_device_id mixer_match_types[] = { > +static const struct of_device_id mixer_match_types[] = { > { > .compatible = "samsung,exynos4210-mixer", > .data = &exynos4210_mxr_drv_data, ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-19 10:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170619101327epcas2p27bb709ee46519fade54663884ef74c88@epcas2p2.samsung.com>
2017-06-19 10:12 ` [PATCH] drm: exynos: constify mixer_match_types and *_mxr_drv_data Arvind Yadav
2017-06-19 10:37 ` Andrzej Hajda
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®