mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Vikram Sharma <quic_vikramsa@quicinc.com>,
	rfoss@kernel.org, todor.too@gmail.com, mchehab@kernel.org,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	akapatra@quicinc.com, hariramp@quicinc.com, andersson@kernel.org,
	konradybcio@kernel.org, hverkuil-cisco@xs4all.nl,
	cros-qcom-dts-watchers@chromium.org, catalin.marinas@arm.com,
	will@kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@quicinc.com
Subject: Re: [PATCH v4 5/6] arm64: dts: qcom: sc7280: Add support for camss
Date: Thu, 31 Oct 2024 18:09:04 +0000	[thread overview]
Message-ID: <299befa1-63f9-4fff-8d5a-0753ae620c11@linaro.org> (raw)
In-Reply-To: <20241030105347.2117034-6-quic_vikramsa@quicinc.com>

On 30/10/2024 10:53, Vikram Sharma wrote:
> Add changes to support the camera subsystem on the SC7280.
> 
> Signed-off-by: Suresh Vankadara <quic_svankada@quicinc.com>
> Signed-off-by: Trishansh Bhardwaj <quic_tbhardwa@quicinc.com>
> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
> ---
>   arch/arm64/boot/dts/qcom/sc7280.dtsi | 175 +++++++++++++++++++++++++++
>   1 file changed, 175 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 55db1c83ef55..690051708dec 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -4426,6 +4426,181 @@ cci1_i2c1: i2c-bus@1 {
>   			};
>   		};
>   
> +		camss: camss@acaf000 {
> +			compatible = "qcom,sc7280-camss";
> +
> +			clocks = <&camcc CAM_CC_CAMNOC_AXI_CLK>,


Order of declaration of the nodes needs to conform to

Documentation/devicetree/bindings/dts-coding-style.rst

i.e. reg should come first after compatible

---
bod

  reply	other threads:[~2024-10-31 18:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30 10:53 [PATCH v4 0/6] media: qcom: camss: Add sc7280 support Vikram Sharma
2024-10-30 10:53 ` [PATCH v4 1/6] media: dt-bindings: media: camss: Add qcom,sc7280-camss binding Vikram Sharma
2024-10-30 11:10   ` Vladimir Zapolskiy
2024-11-01 10:09   ` Krzysztof Kozlowski
2024-10-30 10:53 ` [PATCH v4 2/6] media: qcom: camss: Sort CAMSS version enums and compatible strings Vikram Sharma
2024-10-30 10:53 ` [PATCH v4 3/6] media: qcom: camss: Add support for camss driver on SC7280 Vikram Sharma
2024-10-30 11:15   ` Vladimir Zapolskiy
2024-10-31 17:58   ` Bryan O'Donoghue
2024-10-30 10:53 ` [PATCH v4 4/6] media: qcom: camss: Restructure camss_link_entities Vikram Sharma
2024-10-30 11:17   ` Vladimir Zapolskiy
2024-10-30 10:53 ` [PATCH v4 5/6] arm64: dts: qcom: sc7280: Add support for camss Vikram Sharma
2024-10-31 18:09   ` Bryan O'Donoghue [this message]
2024-10-30 10:53 ` [PATCH v4 6/6] arm64: dts: qcom: qcs6490-rb3gen2-vision-mezzanine: Add vision mezzanine Vikram Sharma
2024-10-30 11:29   ` Vladimir Zapolskiy
2024-11-01 15:27 ` [PATCH v4 0/6] media: qcom: camss: Add sc7280 support Luca Weiss
     [not found]   ` <1f173036-279d-4802-bf04-cfa2d8066e68@quicinc.com>
2024-11-05 12:40     ` Luca Weiss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=299befa1-63f9-4fff-8d5a-0753ae620c11@linaro.org \
    --to=bryan.odonoghue@linaro.org \
    --cc=akapatra@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hariramp@quicinc.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=kernel@quicinc.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=quic_vikramsa@quicinc.com \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=todor.too@gmail.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®