From: "Mario Limonciello (AMD)" <superm1@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Yazen Ghannam <yazen.ghannam@amd.com>,
Jean Delvare <jdelvare@suse.com>,
linux-kernel@vger.kernel.org, Jean Delvare <jdelvare@suse.de>
Subject: Re: [PATCH v6 3/5] firmware: dmi: Add missing DMI entry types
Date: Wed, 1 Apr 2026 08:16:17 -0500 [thread overview]
Message-ID: <2a4faf87-8c1c-4ea4-92ea-8619ae51b27d@kernel.org> (raw)
In-Reply-To: <20260401110326.GAacz7fomOcX8eeo1V@fat_crate.local>
On 4/1/26 06:03, Borislav Petkov wrote:
> On Sat, Mar 07, 2026 at 08:10:22AM -0600, Mario Limonciello (AMD) wrote:
>> Type 43 through type 46 entry types are missing from the
>> definitions in the dmi_entry_type enum.
>>
>> Link: https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.7.1.pdf
>> Suggested-by: Yazen Ghannam <yazen.ghannam@amd.com>
>> Reviewed-by: Jean Delvare <jdelvare@suse.de>
>> Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>
>> Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
>> ---
>> v4:
>> * Add tag (Yazen)
>> * Correct text (Yazen)
>> v3:
>> * Add tag (Jean)
>> ---
>> include/linux/dmi.h | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/include/linux/dmi.h b/include/linux/dmi.h
>> index 32b2529a73301..2eedf44e68012 100644
>> --- a/include/linux/dmi.h
>> +++ b/include/linux/dmi.h
>> @@ -70,6 +70,10 @@ enum dmi_entry_type {
>> DMI_ENTRY_ADDITIONAL,
>> DMI_ENTRY_ONBOARD_DEV_EXT,
>> DMI_ENTRY_MGMT_CONTROLLER_HOST,
>> + DMI_ENTRY_TPM_DEVICE,
>> + DMI_ENTRY_PROCESSOR_ADDITIONAL,
>> + DMI_ENTRY_FIRMWARE_INVENTORY,
>> + DMI_ENTRY_STRING_PROPERTY,
>> DMI_ENTRY_INACTIVE = 126,
>> DMI_ENTRY_END_OF_TABLE = 127,
>> };
>> --
>
> Is there any particular reason this is a separate patch and not part of patch
> 1?
>
They are two separate logical problems (indexing error and missing
entries). I was trying to stick to one commit; one issue.
next prev parent reply other threads:[~2026-04-01 13:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-07 14:10 [PATCH v6 0/5] Print AGESA version at bootup Mario Limonciello (AMD)
2026-03-07 14:10 ` [PATCH v6 1/5] firmware: dmi: Correct an indexing error in dmi.h Mario Limonciello (AMD)
2026-04-01 19:34 ` [tip: x86/platform] " tip-bot2 for Mario Limonciello (AMD)
2026-03-07 14:10 ` [PATCH v6 2/5] firmware: dmi: Adjust dmi_decode() to use enums Mario Limonciello (AMD)
2026-04-01 19:34 ` [tip: x86/platform] " tip-bot2 for Mario Limonciello (AMD)
2026-03-07 14:10 ` [PATCH v6 3/5] firmware: dmi: Add missing DMI entry types Mario Limonciello (AMD)
2026-04-01 11:03 ` Borislav Petkov
2026-04-01 13:16 ` Mario Limonciello (AMD) [this message]
2026-04-01 18:49 ` Borislav Petkov
2026-03-07 14:10 ` [PATCH v6 4/5] firmware: dmi: Add pr_fmt() for dmi_scan.c Mario Limonciello (AMD)
2026-04-01 19:34 ` [tip: x86/platform] " tip-bot2 for Mario Limonciello (AMD)
2026-03-07 14:10 ` [PATCH v6 5/5] x86/CPU/AMD: Print AGESA string from DMI additional information entry Mario Limonciello (AMD)
2026-04-01 9:17 ` Jean Delvare
2026-04-01 10:29 ` Borislav Petkov
2026-04-01 11:45 ` Borislav Petkov
2026-04-01 13:14 ` Mario Limonciello (AMD)
2026-04-01 18:52 ` Borislav Petkov
2026-04-01 19:34 ` [tip: x86/platform] " tip-bot2 for Yazen Ghannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a4faf87-8c1c-4ea4-92ea-8619ae51b27d@kernel.org \
--to=superm1@kernel.org \
--cc=bp@alien8.de \
--cc=jdelvare@suse.com \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome