Re: [PATCH v6 5/5] x86/CPU/AMD: Print AGESA string from DMI additional information entry

["Mario Limonciello (AMD)" <superm1@kernel.org>]

On 4/1/26 06:45, Borislav Petkov wrote:
> On Wed, Apr 01, 2026 at 12:29:08PM +0200, Borislav Petkov wrote:
>> On Wed, Apr 01, 2026 at 11:17:01AM +0200, Jean Delvare wrote:
>>> Isn't "V9" going to become "V10" at some point in the future, and then
>>> the AGESA string will no longer be displayed until the code is
>>> adjusted? Or will AMD move the information to a more appropriate place
>>> by then?
>>>
>>> Also, I know this was discussed before, but the current print strategy
>>> omits "V9". Is this not something we are going to regret once more
>>> versions are available and we may have to differentiate between them?
>>
>> Right, I think we should not be silly and simply dump the string that starts
>> with "AGESA" and that's it.
> 
> IOW, this:
> 
>                  if (!strncmp(string_ptr, "AGESA", 5)) {
>                          pr_info("AGESA: %s\n", string_ptr);
>                          break;
>                  }
> 
> Mario, what's that additional "dance" you're doing there? Do we have other
> strings which start with "AGESA"?
> 

Right we did talk about this a little on the last iteration too [1].
The string_ptr + 9 will fail if we ever had a V10.

Link: 
https://lore.kernel.org/all/20260126154037.GBaXeK9bxgPMdE2lFr@fat_crate.local/ 
[1]

If you guys would prefer to stick to the simple strncmp() + pr_info() 
the whole thing that's fine by me.

Do you want me to send out a new patch series, or will you just adjust 
while committing?