From: Hongyan Xia <hongyan.xia2@arm.com>
To: Qais Yousef <qyousef@layalina.io>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
linux-kernel@vger.kernel.org, Lukasz Luba <lukasz.luba@arm.com>,
Wei Wang <wvw@google.com>, Xuewen Yan <xuewen.yan94@gmail.com>,
Hank <han.lin@mediatek.com>,
Jonathan JMChen <Jonathan.JMChen@mediatek.com>,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH v2 1/3] sched/uclamp: Set max_spare_cap_cpu even if max_spare_cap is 0
Date: Wed, 7 Jun 2023 12:50:08 +0100 [thread overview]
Message-ID: <2a9ed73a-256c-4ace-6b26-e30ac69cbdbc@arm.com> (raw)
In-Reply-To: <20230211172829.f2igueizqpwijjjz@airbuntu>
Hi Qais,
On 2023-02-11 17:28, Qais Yousef wrote:
> On 02/07/23 10:45, Vincent Guittot wrote:
>> [...]
>
> Isn't it better to go back to v1 form then? The inconsistent type paired with
> the cast isn't getting too ugly for me :(
>
> I don't think we can convert cpu_cap to long without having to do more work as
> it is used with 'util'.
Sorry if I'm missing something obvious, but why can't we convert util to
long? The only place I see which mixes with util is
lsub_positive(&cpu_cap, util);
but at this point both cpu_cap and util should have sane values (top bit
not set) so doing clamped subtraction should just work fine?
Hongyan
next prev parent reply other threads:[~2023-06-07 11:50 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-05 22:43 [PATCH v2 0/3] Fix a couple of corner cases in feec() when using uclamp_max Qais Yousef
2023-02-05 22:43 ` [PATCH v2 1/3] sched/uclamp: Set max_spare_cap_cpu even if max_spare_cap is 0 Qais Yousef
2023-02-07 9:45 ` Vincent Guittot
2023-02-09 18:02 ` Dietmar Eggemann
2023-02-11 17:50 ` Qais Yousef
2023-02-14 12:47 ` Dietmar Eggemann
2023-02-14 18:09 ` Qais Yousef
2023-02-21 12:20 ` Dietmar Eggemann
2023-02-23 15:12 ` Qais Yousef
2023-05-22 8:30 ` Lukasz Luba
[not found] ` <20230531182243.r4d5teuijiadwp2c@airbuntu>
2023-06-05 11:29 ` Dietmar Eggemann
2023-06-30 11:30 ` Qais Yousef
2023-06-05 13:07 ` Lukasz Luba
2023-06-07 14:52 ` Hongyan Xia
2023-06-30 11:41 ` Qais Yousef
2023-02-11 17:28 ` Qais Yousef
2023-02-20 17:02 ` Vincent Guittot
2023-02-21 12:05 ` Qais Yousef
2023-02-22 10:59 ` Vincent Guittot
2023-02-23 15:13 ` Qais Yousef
2023-06-07 11:50 ` Hongyan Xia [this message]
2023-06-30 11:44 ` Qais Yousef
2023-07-17 21:49 ` Qais Yousef
2023-02-05 22:43 ` [PATCH v2 2/3] sched/uclamp: Ignore (util == 0) optimization in feec() when p_util_max = 0 Qais Yousef
2023-02-07 10:04 ` Vincent Guittot
2023-02-08 11:52 ` Dietmar Eggemann
2023-02-11 18:01 ` Qais Yousef
2023-02-14 12:47 ` Dietmar Eggemann
2023-02-14 18:10 ` Qais Yousef
2023-02-20 17:24 ` Vincent Guittot
2023-02-05 22:43 ` [PATCH v2 3/3] sched/tp: Add new tracepoint to track compute energy computation Qais Yousef
2023-02-20 11:22 ` Lukasz Luba
2023-02-21 12:08 ` Qais Yousef
2023-02-21 12:10 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a9ed73a-256c-4ace-6b26-e30ac69cbdbc@arm.com \
--to=hongyan.xia2@arm.com \
--cc=Jonathan.JMChen@mediatek.com \
--cc=dietmar.eggemann@arm.com \
--cc=han.lin@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=qyousef@layalina.io \
--cc=vincent.guittot@linaro.org \
--cc=wvw@google.com \
--cc=xuewen.yan94@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome