* [PATCH] clk: qcom: Fix default entries for Glymur EVACC and GPUCC
@ 2026-09-15 6:58 Taniya Das
2026-09-15 9:41 ` Abel Vesa
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Taniya Das @ 2026-09-15 6:58 UTC (permalink / raw)
To: Bjorn Andersson, Abel Vesa, Stephen Boyd, Brian Masney,
Jerome Brunet, Konrad Dybcio
Cc: Ajit Pandey, Imran Shaik, Jagadeesh Kona, linux-arm-msm,
linux-clk, linux-kernel, Taniya Das
The EVA clock controller (CLK_GLYMUR_EVACC) config carried a duplicate
'default m if ARCH_QCOM' line, one of them misplaced before the 'select'
statement, while the graphics clock controller (CLK_GLYMUR_GPUCC) config
was missing the 'default m if ARCH_QCOM' line altogether.
Drop the duplicate on EVACC and add the missing default on GPUCC so both
Qualcomm Glymur clock controllers follow the same
depends on / select / default / help ordering used by the other entries.
Fixes: e291ec812dec ("clk: qcom: Add EVA clock controller driver for Glymur SoC")
Fixes: 67e645285dd0 ("clk: qcom: Add support for GPUCC and GXCLK for Glymur")
Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
---
Fix Kconfig ordering/consistency issues for the Qualcomm Glymur clock
controllers: the EVA clock controller (CLK_GLYMUR_EVACC) carried a
duplicate 'default m if ARCH_QCOM' line, one of them misplaced before the
'select' statement, and the graphics clock controller (CLK_GLYMUR_GPUCC)
was missing the 'default m if ARCH_QCOM' line altogether.
With this change both entries follow the same
depends on / select / default / help ordering used by the other Glymur
clock controller Kconfig entries.
---
drivers/clk/qcom/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
index 6ef083f5d9e251d2d2c5592a3f3dd51845dc743b..b3ffe1dced017e6f4bd3f0fa9c11bed5948391fc 100644
--- a/drivers/clk/qcom/Kconfig
+++ b/drivers/clk/qcom/Kconfig
@@ -104,7 +104,6 @@ config CLK_GLYMUR_DISPCC
config CLK_GLYMUR_EVACC
tristate "Glymur EVA Clock Controller"
depends on ARM64 || COMPILE_TEST
- default m if ARCH_QCOM
select CLK_GLYMUR_GCC
default m if ARCH_QCOM
help
@@ -127,6 +126,7 @@ config CLK_GLYMUR_GPUCC
tristate "Glymur Graphics Clock Controller"
depends on ARM64 || COMPILE_TEST
select CLK_GLYMUR_GCC
+ default m if ARCH_QCOM
help
Support for the graphics clock controller on Glymur devices.
Say Y if you want to support graphics controller devices and
---
base-commit: 1a1de54f7369cd2b5bac0f265910e60ad3a6b4c3
change-id: 20260915-kconfig_updates-39a684a748d0
Best regards,
--
Taniya Das <taniya.das@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] clk: qcom: Fix default entries for Glymur EVACC and GPUCC
2026-09-15 6:58 [PATCH] clk: qcom: Fix default entries for Glymur EVACC and GPUCC Taniya Das
@ 2026-09-15 9:41 ` Abel Vesa
2026-09-16 9:00 ` Pankaj Patil
2026-09-16 9:10 ` Pankaj Patil
2 siblings, 0 replies; 5+ messages in thread
From: Abel Vesa @ 2026-09-15 9:41 UTC (permalink / raw)
To: Taniya Das
Cc: Bjorn Andersson, Abel Vesa, Stephen Boyd, Brian Masney,
Jerome Brunet, Konrad Dybcio, Ajit Pandey, Imran Shaik,
Jagadeesh Kona, linux-arm-msm, linux-clk, linux-kernel
On 26-09-15 12:28:22, Taniya Das wrote:
> The EVA clock controller (CLK_GLYMUR_EVACC) config carried a duplicate
> 'default m if ARCH_QCOM' line, one of them misplaced before the 'select'
> statement, while the graphics clock controller (CLK_GLYMUR_GPUCC) config
> was missing the 'default m if ARCH_QCOM' line altogether.
>
> Drop the duplicate on EVACC and add the missing default on GPUCC so both
> Qualcomm Glymur clock controllers follow the same
> depends on / select / default / help ordering used by the other entries.
>
> Fixes: e291ec812dec ("clk: qcom: Add EVA clock controller driver for Glymur SoC")
> Fixes: 67e645285dd0 ("clk: qcom: Add support for GPUCC and GXCLK for Glymur")
> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] clk: qcom: Fix default entries for Glymur EVACC and GPUCC
2026-09-15 6:58 [PATCH] clk: qcom: Fix default entries for Glymur EVACC and GPUCC Taniya Das
2026-09-15 9:41 ` Abel Vesa
@ 2026-09-16 9:00 ` Pankaj Patil
2026-09-16 9:10 ` Pankaj Patil
2 siblings, 0 replies; 5+ messages in thread
From: Pankaj Patil @ 2026-09-16 9:00 UTC (permalink / raw)
To: Taniya Das, Bjorn Andersson, Abel Vesa, Stephen Boyd,
Brian Masney, Jerome Brunet, Konrad Dybcio
Cc: Ajit Pandey, Imran Shaik, Jagadeesh Kona, linux-arm-msm,
linux-clk, linux-kernel
On 9/15/2026 12:28 PM, Taniya Das wrote:
> The EVA clock controller (CLK_GLYMUR_EVACC) config carried a duplicate
> 'default m if ARCH_QCOM' line, one of them misplaced before the 'select'
> statement, while the graphics clock controller (CLK_GLYMUR_GPUCC) config
> was missing the 'default m if ARCH_QCOM' line altogether.
>
> Drop the duplicate on EVACC and add the missing default on GPUCC so both
> Qualcomm Glymur clock controllers follow the same
> depends on / select / default / help ordering used by the other entries.
>
> Fixes: e291ec812dec ("clk: qcom: Add EVA clock controller driver for Glymur SoC")
> Fixes: 67e645285dd0 ("clk: qcom: Add support for GPUCC and GXCLK for Glymur")
> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
> ---
Reviewed-by: Pankaj Patil <pankaj.patil@oss.qualcomm.com>
> Fix Kconfig ordering/consistency issues for the Qualcomm Glymur clock
> controllers: the EVA clock controller (CLK_GLYMUR_EVACC) carried a
> duplicate 'default m if ARCH_QCOM' line, one of them misplaced before the
> 'select' statement, and the graphics clock controller (CLK_GLYMUR_GPUCC)
> was missing the 'default m if ARCH_QCOM' line altogether.
>
> With this change both entries follow the same
> depends on / select / default / help ordering used by the other Glymur
> clock controller Kconfig entries.
[...]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] clk: qcom: Fix default entries for Glymur EVACC and GPUCC
2026-09-15 6:58 [PATCH] clk: qcom: Fix default entries for Glymur EVACC and GPUCC Taniya Das
2026-09-15 9:41 ` Abel Vesa
2026-09-16 9:00 ` Pankaj Patil
@ 2026-09-16 9:10 ` Pankaj Patil
2026-09-16 22:06 ` Bjorn Andersson
2 siblings, 1 reply; 5+ messages in thread
From: Pankaj Patil @ 2026-09-16 9:10 UTC (permalink / raw)
To: Taniya Das, Bjorn Andersson, Abel Vesa, Stephen Boyd,
Brian Masney, Jerome Brunet, Konrad Dybcio
Cc: Ajit Pandey, Imran Shaik, Jagadeesh Kona, linux-arm-msm,
linux-clk, linux-kernel
On 9/15/2026 12:28 PM, Taniya Das wrote:
> The EVA clock controller (CLK_GLYMUR_EVACC) config carried a duplicate
> 'default m if ARCH_QCOM' line, one of them misplaced before the 'select'
> statement, while the graphics clock controller (CLK_GLYMUR_GPUCC) config
> was missing the 'default m if ARCH_QCOM' line altogether.
>
> Drop the duplicate on EVACC and add the missing default on GPUCC so both
> Qualcomm Glymur clock controllers follow the same
> depends on / select / default / help ordering used by the other entries.
>
> Fixes: e291ec812dec ("clk: qcom: Add EVA clock controller driver for Glymur SoC")
> Fixes: 67e645285dd0 ("clk: qcom: Add support for GPUCC and GXCLK for Glymur")
> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
> ---
> Fix Kconfig ordering/consistency issues for the Qualcomm Glymur clock
> controllers: the EVA clock controller (CLK_GLYMUR_EVACC) carried a
> duplicate 'default m if ARCH_QCOM' line, one of them misplaced before the
> 'select' statement, and the graphics clock controller (CLK_GLYMUR_GPUCC)
> was missing the 'default m if ARCH_QCOM' line altogether.
>
> With this change both entries follow the same
> depends on / select / default / help ordering used by the other Glymur
> clock controller Kconfig entries.
Fix was posted by Sivansh and has been reviewed, should get picked up.
https://lore.kernel.org/all/20260821045214.2623299-2-sivansh.gupta@oss.qualcomm.com/
> ---
> drivers/clk/qcom/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index 6ef083f5d9e251d2d2c5592a3f3dd51845dc743b..b3ffe1dced017e6f4bd3f0fa9c11bed5948391fc 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -104,7 +104,6 @@ config CLK_GLYMUR_DISPCC
> config CLK_GLYMUR_EVACC
> tristate "Glymur EVA Clock Controller"
> depends on ARM64 || COMPILE_TEST
> - default m if ARCH_QCOM
> select CLK_GLYMUR_GCC
> default m if ARCH_QCOM
> help
> @@ -127,6 +126,7 @@ config CLK_GLYMUR_GPUCC
> tristate "Glymur Graphics Clock Controller"
> depends on ARM64 || COMPILE_TEST
> select CLK_GLYMUR_GCC
> + default m if ARCH_QCOM
> help
> Support for the graphics clock controller on Glymur devices.
> Say Y if you want to support graphics controller devices and
>
> ---
> base-commit: 1a1de54f7369cd2b5bac0f265910e60ad3a6b4c3
> change-id: 20260915-kconfig_updates-39a684a748d0
>
> Best regards,
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] clk: qcom: Fix default entries for Glymur EVACC and GPUCC
2026-09-16 9:10 ` Pankaj Patil
@ 2026-09-16 22:06 ` Bjorn Andersson
0 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2026-09-16 22:06 UTC (permalink / raw)
To: Pankaj Patil
Cc: Taniya Das, Abel Vesa, Stephen Boyd, Brian Masney, Jerome Brunet,
Konrad Dybcio, Ajit Pandey, Imran Shaik, Jagadeesh Kona,
linux-arm-msm, linux-clk, linux-kernel
On Wed, Sep 16, 2026 at 02:40:31PM +0530, Pankaj Patil wrote:
> On 9/15/2026 12:28 PM, Taniya Das wrote:
> > The EVA clock controller (CLK_GLYMUR_EVACC) config carried a duplicate
> > 'default m if ARCH_QCOM' line, one of them misplaced before the 'select'
> > statement, while the graphics clock controller (CLK_GLYMUR_GPUCC) config
> > was missing the 'default m if ARCH_QCOM' line altogether.
> >
> > Drop the duplicate on EVACC and add the missing default on GPUCC so both
> > Qualcomm Glymur clock controllers follow the same
> > depends on / select / default / help ordering used by the other entries.
> >
> > Fixes: e291ec812dec ("clk: qcom: Add EVA clock controller driver for Glymur SoC")
> > Fixes: 67e645285dd0 ("clk: qcom: Add support for GPUCC and GXCLK for Glymur")
> > Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
> > ---
> > Fix Kconfig ordering/consistency issues for the Qualcomm Glymur clock
> > controllers: the EVA clock controller (CLK_GLYMUR_EVACC) carried a
> > duplicate 'default m if ARCH_QCOM' line, one of them misplaced before the
> > 'select' statement, and the graphics clock controller (CLK_GLYMUR_GPUCC)
> > was missing the 'default m if ARCH_QCOM' line altogether.
> >
> > With this change both entries follow the same
> > depends on / select / default / help ordering used by the other Glymur
> > clock controller Kconfig entries.
>
> Fix was posted by Sivansh and has been reviewed, should get picked up.
> https://lore.kernel.org/all/20260821045214.2623299-2-sivansh.gupta@oss.qualcomm.com/
>
Thanks for pointing that out, Pankaj.
Regards,
Bjorn
> > ---
> > drivers/clk/qcom/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> > index 6ef083f5d9e251d2d2c5592a3f3dd51845dc743b..b3ffe1dced017e6f4bd3f0fa9c11bed5948391fc 100644
> > --- a/drivers/clk/qcom/Kconfig
> > +++ b/drivers/clk/qcom/Kconfig
> > @@ -104,7 +104,6 @@ config CLK_GLYMUR_DISPCC
> > config CLK_GLYMUR_EVACC
> > tristate "Glymur EVA Clock Controller"
> > depends on ARM64 || COMPILE_TEST
> > - default m if ARCH_QCOM
> > select CLK_GLYMUR_GCC
> > default m if ARCH_QCOM
> > help
> > @@ -127,6 +126,7 @@ config CLK_GLYMUR_GPUCC
> > tristate "Glymur Graphics Clock Controller"
> > depends on ARM64 || COMPILE_TEST
> > select CLK_GLYMUR_GCC
> > + default m if ARCH_QCOM
> > help
> > Support for the graphics clock controller on Glymur devices.
> > Say Y if you want to support graphics controller devices and
> >
> > ---
> > base-commit: 1a1de54f7369cd2b5bac0f265910e60ad3a6b4c3
> > change-id: 20260915-kconfig_updates-39a684a748d0
> >
> > Best regards,
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-09-16 22:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-15 6:58 [PATCH] clk: qcom: Fix default entries for Glymur EVACC and GPUCC Taniya Das
2026-09-15 9:41 ` Abel Vesa
2026-09-16 9:00 ` Pankaj Patil
2026-09-16 9:10 ` Pankaj Patil
2026-09-16 22:06 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®