* [PATCH] drm/nouveau: Omit a redundant pm_runtime_mark_last_busy() call in nouveau_pmops_runtime_idle()
@ 2026-03-25 14:05 Markus Elfring
2026-07-17 21:14 ` lyude
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2026-03-25 14:05 UTC (permalink / raw)
To: nouveau, dri-devel, Danilo Krummrich, David Airlie, Lyude Paul,
Maarten Lankhorst, Maxime Ripard, Simona Vetter,
Thomas Zimmermann
Cc: LKML, kernel-janitors, Felix Gu, Laurent Pinchart,
Rafael J. Wysocki, Sakari Ailus
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 25 Mar 2026 14:55:01 +0100
The device's last busy timestamp was set in a wrapper function since
the commit 08071e64cb642ae19ebd6ffeb13b4f3d130b5860 ("PM: runtime:
Mark last busy stamp in pm_runtime_autosuspend()").
Thus delete a pm_runtime_mark_last_busy() call before
a pm_runtime_autosuspend() call.
The source code was transformed by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/gpu/drm/nouveau/nouveau_drm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
index 5d8475e4895e..62ac9593230f 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
@@ -1209,7 +1209,6 @@ nouveau_pmops_runtime_idle(struct device *dev)
return -EBUSY;
}
- pm_runtime_mark_last_busy(dev);
pm_runtime_autosuspend(dev);
/* we don't want the main rpm_idle to call suspend - we want to autosuspend */
return 1;
--
2.53.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/nouveau: Omit a redundant pm_runtime_mark_last_busy() call in nouveau_pmops_runtime_idle()
2026-03-25 14:05 [PATCH] drm/nouveau: Omit a redundant pm_runtime_mark_last_busy() call in nouveau_pmops_runtime_idle() Markus Elfring
@ 2026-07-17 21:14 ` lyude
0 siblings, 0 replies; 2+ messages in thread
From: lyude @ 2026-07-17 21:14 UTC (permalink / raw)
To: Markus Elfring, nouveau, dri-devel, Danilo Krummrich,
David Airlie, Maarten Lankhorst, Maxime Ripard, Simona Vetter,
Thomas Zimmermann
Cc: LKML, kernel-janitors, Felix Gu, Laurent Pinchart,
Rafael J. Wysocki, Sakari Ailus
Reviewed-by: Lyude Paul <lyude@redhat.com>
Will push to drm-misc-next in just a moment
On Wed, 2026-03-25 at 15:05 +0100, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 25 Mar 2026 14:55:01 +0100
>
> The device's last busy timestamp was set in a wrapper function since
> the commit 08071e64cb642ae19ebd6ffeb13b4f3d130b5860 ("PM: runtime:
> Mark last busy stamp in pm_runtime_autosuspend()").
> Thus delete a pm_runtime_mark_last_busy() call before
> a pm_runtime_autosuspend() call.
>
> The source code was transformed by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/gpu/drm/nouveau/nouveau_drm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c
> b/drivers/gpu/drm/nouveau/nouveau_drm.c
> index 5d8475e4895e..62ac9593230f 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_drm.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
> @@ -1209,7 +1209,6 @@ nouveau_pmops_runtime_idle(struct device *dev)
> return -EBUSY;
> }
>
> - pm_runtime_mark_last_busy(dev);
> pm_runtime_autosuspend(dev);
> /* we don't want the main rpm_idle to call suspend - we want
> to autosuspend */
> return 1;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-17 21:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-25 14:05 [PATCH] drm/nouveau: Omit a redundant pm_runtime_mark_last_busy() call in nouveau_pmops_runtime_idle() Markus Elfring
2026-07-17 21:14 ` lyude
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome