[PATCH 0/3] SC7180 MDSS core reset

[PATCH 0/3] SC7180 MDSS core reset

[Konrad Dybcio]

Add the missing reset for the display subsystem and wire it up, so that
drivers can consume it.

Compile-tested only.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
Konrad Dybcio (3):
      dt-bindings: clock: qcom,dispcc-sc7180: Define MDSS resets
      clk: qcom: dispcc-sc7180: Add missing MDSS resets
      arm64: dts: qcom: sc7180: Add missing MDSS core reset

 arch/arm64/boot/dts/qcom/sc7180.dtsi           | 2 ++
 drivers/clk/qcom/dispcc-sc7180.c               | 8 ++++++++
 include/dt-bindings/clock/qcom,dispcc-sc7180.h | 7 ++++++-
 3 files changed, 16 insertions(+), 1 deletion(-)
---
base-commit: 46fe65a2c28ecf5df1a7475aba1f08ccf4c0ac1b
change-id: 20260120-topic-7180_dispcc_bcr-f7ac25c21f89

Best regards,
-- 
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

[PATCH 1/3] dt-bindings: clock: qcom,dispcc-sc7180: Define MDSS resets

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

The MDSS resets have so far been left undescribed. Fix that.

Fixes: 75616da71291 ("dt-bindings: clock: Introduce QCOM sc7180 display clock bindings")
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 include/dt-bindings/clock/qcom,dispcc-sc7180.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/include/dt-bindings/clock/qcom,dispcc-sc7180.h b/include/dt-bindings/clock/qcom,dispcc-sc7180.h
index b9b51617a335..070510306074 100644
--- a/include/dt-bindings/clock/qcom,dispcc-sc7180.h
+++ b/include/dt-bindings/clock/qcom,dispcc-sc7180.h
@@ -6,6 +6,7 @@
 #ifndef _DT_BINDINGS_CLK_QCOM_DISP_CC_SC7180_H
 #define _DT_BINDINGS_CLK_QCOM_DISP_CC_SC7180_H
 
+/* Clocks */
 #define DISP_CC_PLL0				0
 #define DISP_CC_PLL0_OUT_EVEN			1
 #define DISP_CC_MDSS_AHB_CLK			2
@@ -40,7 +41,11 @@
 #define DISP_CC_MDSS_VSYNC_CLK_SRC		31
 #define DISP_CC_XO_CLK				32
 
-/* DISP_CC GDSCR */
+/* Resets */
+#define DISP_CC_MDSS_CORE_BCR			0
+#define DISP_CC_MDSS_RSCC_BCR			1
+
+/* GDSCs */
 #define MDSS_GDSC				0
 
 #endif

-- 
2.52.0

[PATCH 2/3] clk: qcom: dispcc-sc7180: Add missing MDSS resets

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

The MDSS resets have so far been left undescribed. Fix that.

Fixes: dd3d06622138 ("clk: qcom: Add display clock controller driver for SC7180")
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 drivers/clk/qcom/dispcc-sc7180.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/clk/qcom/dispcc-sc7180.c b/drivers/clk/qcom/dispcc-sc7180.c
index ab1a8d419863..d7e37fbbe87e 100644
--- a/drivers/clk/qcom/dispcc-sc7180.c
+++ b/drivers/clk/qcom/dispcc-sc7180.c
@@ -17,6 +17,7 @@
 #include "clk-regmap-divider.h"
 #include "common.h"
 #include "gdsc.h"
+#include "reset.h"
 
 enum {
 	P_BI_TCXO,
@@ -636,6 +637,11 @@ static struct gdsc mdss_gdsc = {
 	.flags = HW_CTRL,
 };
 
+static const struct qcom_reset_map disp_cc_sc7180_resets[] = {
+	[DISP_CC_MDSS_CORE_BCR] = { 0x2000 },
+	[DISP_CC_MDSS_RSCC_BCR] = { 0x4000 },
+};
+
 static struct gdsc *disp_cc_sc7180_gdscs[] = {
 	[MDSS_GDSC] = &mdss_gdsc,
 };
@@ -687,6 +693,8 @@ static const struct qcom_cc_desc disp_cc_sc7180_desc = {
 	.config = &disp_cc_sc7180_regmap_config,
 	.clks = disp_cc_sc7180_clocks,
 	.num_clks = ARRAY_SIZE(disp_cc_sc7180_clocks),
+	.resets = disp_cc_sc7180_resets,
+	.num_resets = ARRAY_SIZE(disp_cc_sc7180_resets),
 	.gdscs = disp_cc_sc7180_gdscs,
 	.num_gdscs = ARRAY_SIZE(disp_cc_sc7180_gdscs),
 };

-- 
2.52.0

[PATCH 3/3] arm64: dts: qcom: sc7180: Add missing MDSS core reset

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

To make sure the core starts in a predictable state, it's useful to
first reset it.

Wire up the reset to fulfill that missing part of the HW description.

Reported-by: Val Packett <val@packett.cool>
Fixes: a3db7ad1af49 ("arm64: dts: sc7180: add display dt nodes")
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 45b9864e3304..f7937fa88536 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -3221,6 +3221,8 @@ mdss: display-subsystem@ae00000 {
 				 <&dispcc DISP_CC_MDSS_MDP_CLK>;
 			clock-names = "iface", "ahb", "core";
 
+			resets = <&dispcc DISPCC_MDSS_CORE_BCR>;
+
 			interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-controller;
 			#interrupt-cells = <1>;

-- 
2.52.0

Re: [PATCH 3/3] arm64: dts: qcom: sc7180: Add missing MDSS core reset

[Konrad Dybcio]

On 1/20/26 12:19 PM, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> To make sure the core starts in a predictable state, it's useful to
> first reset it.
> 
> Wire up the reset to fulfill that missing part of the HW description.
> 
> Reported-by: Val Packett <val@packett.cool>
> Fixes: a3db7ad1af49 ("arm64: dts: sc7180: add display dt nodes")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 45b9864e3304..f7937fa88536 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -3221,6 +3221,8 @@ mdss: display-subsystem@ae00000 {
>  				 <&dispcc DISP_CC_MDSS_MDP_CLK>;
>  			clock-names = "iface", "ahb", "core";
>  
> +			resets = <&dispcc DISPCC_MDSS_CORE_BCR>;

^ won't compile without a _ between 'DISP' and 'CC', should have 
compile-tested harder..

Konrad

Re: [PATCH 1/3] dt-bindings: clock: qcom,dispcc-sc7180: Define MDSS resets

[Krzysztof Kozlowski]

On 20/01/2026 12:19, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> The MDSS resets have so far been left undescribed. Fix that.
> 
> Fixes: 75616da71291 ("dt-bindings: clock: Introduce QCOM sc7180 display clock bindings")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  include/dt-bindings/clock/qcom,dispcc-sc7180.h | 7 ++++++


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

Re: [PATCH 0/3] SC7180 MDSS core reset

[Val Packett]

On 1/20/26 8:19 AM, Konrad Dybcio wrote:
> Add the missing reset for the display subsystem and wire it up, so that
> drivers can consume it.
>
> Compile-tested only.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---

Thanks!

Tested-by: Val Packett <val@packett.cool> # sc7180-ecs-liva-qc710

Might be worth noting in the commit message that the real world issue 
this solves is that after probing the driver, the DPU would keep trying 
to access the physical address that belonged to the EFI framebuffer, 
causing constant IOMMU faults and visual glitches on the display output.

~val

P.S. what a coincidence that just a week ago this was discussed for 
sdm845 
https://lore.kernel.org/all/bfe55d1b-1b45-4187-84fe-9475cb90b00a@linaro.org/

Re: [PATCH 1/3] dt-bindings: clock: qcom,dispcc-sc7180: Define MDSS resets

[Taniya Das]

On 1/20/2026 4:49 PM, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> The MDSS resets have so far been left undescribed. Fix that.
> 
> Fixes: 75616da71291 ("dt-bindings: clock: Introduce QCOM sc7180 display clock bindings")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  include/dt-bindings/clock/qcom,dispcc-sc7180.h | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/include/dt-bindings/clock/qcom,dispcc-sc7180.h b/include/dt-bindings/clock/qcom,dispcc-sc7180.h
> index b9b51617a335..070510306074 100644
> --- a/include/dt-bindings/clock/qcom,dispcc-sc7180.h
> +++ b/include/dt-bindings/clock/qcom,dispcc-sc7180.h
> @@ -6,6 +6,7 @@
>  #ifndef _DT_BINDINGS_CLK_QCOM_DISP_CC_SC7180_H
>  #define _DT_BINDINGS_CLK_QCOM_DISP_CC_SC7180_H
>  
> +/* Clocks */
>  #define DISP_CC_PLL0				0
>  #define DISP_CC_PLL0_OUT_EVEN			1
>  #define DISP_CC_MDSS_AHB_CLK			2
> @@ -40,7 +41,11 @@
>  #define DISP_CC_MDSS_VSYNC_CLK_SRC		31
>  #define DISP_CC_XO_CLK				32
>  
> -/* DISP_CC GDSCR */
> +/* Resets */
> +#define DISP_CC_MDSS_CORE_BCR			0
> +#define DISP_CC_MDSS_RSCC_BCR			1
> +
> +/* GDSCs */
>  #define MDSS_GDSC				0
>  
>  #endif
> 

Reviewed-by: Taniya Das <taniya.das@oss.qualcomm.com>

-- 
Thanks,
Taniya Das

Re: [PATCH 2/3] clk: qcom: dispcc-sc7180: Add missing MDSS resets

[Taniya Das]

On 1/20/2026 4:49 PM, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> The MDSS resets have so far been left undescribed. Fix that.
> 
> Fixes: dd3d06622138 ("clk: qcom: Add display clock controller driver for SC7180")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  drivers/clk/qcom/dispcc-sc7180.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/clk/qcom/dispcc-sc7180.c b/drivers/clk/qcom/dispcc-sc7180.c
> index ab1a8d419863..d7e37fbbe87e 100644
> --- a/drivers/clk/qcom/dispcc-sc7180.c
> +++ b/drivers/clk/qcom/dispcc-sc7180.c
> @@ -17,6 +17,7 @@
>  #include "clk-regmap-divider.h"
>  #include "common.h"
>  #include "gdsc.h"
> +#include "reset.h"
>  
>  enum {
>  	P_BI_TCXO,
> @@ -636,6 +637,11 @@ static struct gdsc mdss_gdsc = {
>  	.flags = HW_CTRL,
>  };
>  
> +static const struct qcom_reset_map disp_cc_sc7180_resets[] = {
> +	[DISP_CC_MDSS_CORE_BCR] = { 0x2000 },
> +	[DISP_CC_MDSS_RSCC_BCR] = { 0x4000 },
> +};
> +
>  static struct gdsc *disp_cc_sc7180_gdscs[] = {
>  	[MDSS_GDSC] = &mdss_gdsc,
>  };
> @@ -687,6 +693,8 @@ static const struct qcom_cc_desc disp_cc_sc7180_desc = {
>  	.config = &disp_cc_sc7180_regmap_config,
>  	.clks = disp_cc_sc7180_clocks,
>  	.num_clks = ARRAY_SIZE(disp_cc_sc7180_clocks),
> +	.resets = disp_cc_sc7180_resets,
> +	.num_resets = ARRAY_SIZE(disp_cc_sc7180_resets),
>  	.gdscs = disp_cc_sc7180_gdscs,
>  	.num_gdscs = ARRAY_SIZE(disp_cc_sc7180_gdscs),
>  };
> 

Reviewed-by: Taniya Das <taniya.das@oss.qualcomm.com>

-- 
Thanks,
Taniya Das

Re: [PATCH 0/3] SC7180 MDSS core reset

[Rob Herring]

On Tue, 20 Jan 2026 12:19:24 +0100, Konrad Dybcio wrote:
> Add the missing reset for the display subsystem and wire it up, so that
> drivers can consume it.
> 
> Compile-tested only.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
> Konrad Dybcio (3):
>       dt-bindings: clock: qcom,dispcc-sc7180: Define MDSS resets
>       clk: qcom: dispcc-sc7180: Add missing MDSS resets
>       arm64: dts: qcom: sc7180: Add missing MDSS core reset
> 
>  arch/arm64/boot/dts/qcom/sc7180.dtsi           | 2 ++
>  drivers/clk/qcom/dispcc-sc7180.c               | 8 ++++++++
>  include/dt-bindings/clock/qcom,dispcc-sc7180.h | 7 ++++++-
>  3 files changed, 16 insertions(+), 1 deletion(-)
> ---
> base-commit: 46fe65a2c28ecf5df1a7475aba1f08ccf4c0ac1b
> change-id: 20260120-topic-7180_dispcc_bcr-f7ac25c21f89
> 
> Best regards,
> --
> Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: 46fe65a2c28ecf5df1a7475aba1f08ccf4c0ac1b (use --merge-base to override)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)


Warnings in base: 429
Warnings after series: 164

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20260120-topic-7180_dispcc_bcr-v1-0-0b1b442156c3@oss.qualcomm.com:

Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
FATAL ERROR: Syntax error parsing input tree
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dtb] Error 1
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-idp.dtb] Error 1
FATAL ERROR: Syntax error parsing input tree
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
FATAL ERROR: Syntax error parsing input tree
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dtb] Error 1
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dtb] Error 1
FATAL ERROR: Syntax error parsing input tree
FATAL ERROR: Syntax error parsing input tree
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r2.dtb] Error 1
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r3.dtb] Error 1
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r4.dtb] Error 1
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtb] Error 1
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dtb] Error 1
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dtb] Error 1
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dtb] Error 1
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
FATAL ERROR: Syntax error parsing input tree
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dtb] Error 1
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dtb] Error 1
FATAL ERROR: Syntax error parsing input tree
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-kb.dtb] Error 1
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
FATAL ERROR: Syntax error parsing input tree
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9.dtb] Error 1
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dtb] Error 1
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-kb.dtb] Error 1
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dtb] Error 1
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r10.dtb] Error 1
FATAL ERROR: Syntax error parsing input tree
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r10-kb.dtb] Error 1
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r4.dtb] Error 1
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
FATAL ERROR: Syntax error parsing input tree
FATAL ERROR: Syntax error parsing input tree
FATAL ERROR: Syntax error parsing input tree
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
FATAL ERROR: Syntax error parsing input tree
FATAL ERROR: Syntax error parsing input tree
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dtb] Error 1
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r9.dtb] Error 1
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r10.dtb] Error 1
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dtb] Error 1
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r5.dtb] Error 1
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r10.dtb] Error 1
FATAL ERROR: Syntax error parsing input tree
FATAL ERROR: Syntax error parsing input tree
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r10-lte.dtb] Error 1
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r9.dtb] Error 1
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dtb] Error 1
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
Unexpected 'DISPCC_MDSS_CORE_BCR'
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-ti.dtb] Error 1
FATAL ERROR: FATAL ERROR: Syntax error parsing input tree
Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-ti.dtb] Error 1
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-parade.dtb] Error 1
Unexpected 'DISPCC_MDSS_CORE_BCR'
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dtb] Error 1
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dtb] Error 1
FATAL ERROR: Syntax error parsing input tree
FATAL ERROR: Syntax error parsing input tree
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dtb] Error 1
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dtb] Error 1
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-lte.dtb] Error 1
FATAL ERROR: Syntax error parsing input tree
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3.dtb] Error 1
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3-lte.dtb] Error 1
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick-r0.dtb] Error 1
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-wifi.dtb] Error 1
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe.dtb] Error 1
FATAL ERROR: Syntax error parsing input tree
FATAL ERROR: Syntax error parsing input tree
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick-r0-lte.dtb] Error 1
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx.dtb] Error 1
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dtb] Error 1
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-r1-lte.dtb] Error 1
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dtb] Error 1
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sm7125-xiaomi-curtana.dtb] Error 1
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
Lexical error: arch/arm64/boot/dts/qcom/sc7180.dtsi:3224.22-42 Unexpected 'DISPCC_MDSS_CORE_BCR'
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sm7125-xiaomi-joyeuse.dtb] Error 1
FATAL ERROR: Syntax error parsing input tree
make[5]: *** [scripts/Makefile.dtbs:142: arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dtb] Error 1
make[5]: Target 'arch/arm64/boot/dts/qcom/' not remade because of errors.
make[4]: *** [scripts/Makefile.build:544: arch/arm64/boot/dts/qcom] Error 2
make[4]: Target 'arch/arm64/boot/dts/qcom/' not remade because of errors.
make[3]: *** [scripts/Makefile.build:544: arch/arm64/boot/dts] Error 2
make[3]: Target 'arch/arm64/boot/dts/qcom/' not remade because of errors.
make[2]: *** [scripts/Makefile.build:544: arch/arm64] Error 2
make[2]: Target 'arch/arm64/boot/dts/qcom/' not remade because of errors.
make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:2080: .] Error 2
make[1]: Target 'arch/arm64/boot/dts/qcom/' not remade because of errors.
make: *** [Makefile:248: __sub-make] Error 2
make: Target 'arch/arm64/boot/dts/qcom/' not remade because of errors.

Re: [PATCH 2/3] clk: qcom: dispcc-sc7180: Add missing MDSS resets

[Dmitry Baryshkov]

On Tue, Jan 20, 2026 at 12:19:26PM +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> The MDSS resets have so far been left undescribed. Fix that.
> 
> Fixes: dd3d06622138 ("clk: qcom: Add display clock controller driver for SC7180")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  drivers/clk/qcom/dispcc-sc7180.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

Re: [PATCH 3/3] arm64: dts: qcom: sc7180: Add missing MDSS core reset

[Dmitry Baryshkov]

On Tue, Jan 20, 2026 at 12:19:27PM +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> To make sure the core starts in a predictable state, it's useful to
> first reset it.
> 
> Wire up the reset to fulfill that missing part of the HW description.
> 
> Reported-by: Val Packett <val@packett.cool>

Closes?

> Fixes: a3db7ad1af49 ("arm64: dts: sc7180: add display dt nodes")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 ++
>  1 file changed, 2 insertions(+)

Let's check that trogrod users don't have anything against it. Doug?

-- 
With best wishes
Dmitry

Re: [PATCH 3/3] arm64: dts: qcom: sc7180: Add missing MDSS core reset

[Konrad Dybcio]

On 1/20/26 11:03 PM, Dmitry Baryshkov wrote:
> On Tue, Jan 20, 2026 at 12:19:27PM +0100, Konrad Dybcio wrote:
>> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>
>> To make sure the core starts in a predictable state, it's useful to
>> first reset it.
>>
>> Wire up the reset to fulfill that missing part of the HW description.
>>
>> Reported-by: Val Packett <val@packett.cool>
> 
> Closes?

Outside lkml

> 
>> Fixes: a3db7ad1af49 ("arm64: dts: sc7180: add display dt nodes")
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> ---
>>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 ++
>>  1 file changed, 2 insertions(+)
> 
> Let's check that trogrod users don't have anything against it. Doug?

Good point, I don't think there should be anything wrong with it
though..

Konrad

Re: (subset) [PATCH 0/3] SC7180 MDSS core reset

[Bjorn Andersson]

On Tue, 20 Jan 2026 12:19:24 +0100, Konrad Dybcio wrote:
> Add the missing reset for the display subsystem and wire it up, so that
> drivers can consume it.
> 
> Compile-tested only.
> 
> 

Applied, thanks!

[2/3] clk: qcom: dispcc-sc7180: Add missing MDSS resets
      commit: b0bc6011c5499bdfddd0390262bfa13dce1eff74

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>