* Re: [PATCH v2] docs: changes.rst: set the pahole minimum back to 1.22
2026-10-22 1:48 ` [PATCH v2] " Mark Severson
@ 2026-10-24 10:09 ` Nguyen Duc Thinh
2026-10-25 13:22 ` Daniel Pereira
2026-10-25 20:20 ` Krzysztof Kozlowski
2 siblings, 0 replies; 5+ messages in thread
From: Nguyen Duc Thinh @ 2026-10-24 10:09 UTC (permalink / raw)
To: Mark Severson
Cc: Jonathan Corbet, Federico Vaga, Shuah Khan, Randy Dunlap, bpf,
linux-doc, linux-kernel, Nguyen Duc Thinh
On Wed, Oct 21, 2026 at 21:48:11 -0400, Mark Severson wrote:
> Set the table back to 1.22, in the English document and in the Italian
> translation, which carries the same table, and remove the Italian
> translation's copy of the paragraph that the English document no longer
> has.
>
> Fixes: fd5425b67355 ("docs, resolve_btfids: Document kfunc BTF annotation emission")
> Signed-off-by: Mark Severson <gr3yf0x87@skyn3tlab.com>
Hi Mark,
Thank you for catching the mismatching requirements (pahole)
alongside the Italian documentation update. The patch makes
complete sense and resolves the contradiction cleanly.
Reviewed-by: Nguyen Duc Thinh <ducthinh100812@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] docs: changes.rst: set the pahole minimum back to 1.22
2026-10-22 1:48 ` [PATCH v2] " Mark Severson
2026-10-24 10:09 ` Nguyen Duc Thinh
@ 2026-10-25 13:22 ` Daniel Pereira
2026-10-25 20:20 ` Krzysztof Kozlowski
2 siblings, 0 replies; 5+ messages in thread
From: Daniel Pereira @ 2026-10-25 13:22 UTC (permalink / raw)
To: gr3yf0x87
Cc: corbet, federico.vaga, skhan, rdunlap, ihor.solodrai, eddyz87,
workflows, linux-doc, bpf, linux-kernel
On Wed, Oct 21, 2026, Mark Severson wrote:
> Set the table back to 1.22, in the English document and in the Italian
> translation, which carries the same table, and remove the Italian
> translation's copy of the paragraph that the English document no longer
> has.
Hi Mark,
I went through v2 against the tree (docs-next at f857ff5bf):
- In Documentation/process/changes.rst the table says pahole 1.26,
while the text below it and lib/Kconfig.debug (DEBUG_INFO_BTF
depends on PAHOLE_VERSION >= 122) say 1.22, so the table is the odd
one out.
- tools/bpf/resolve_btfids/main.c now rewrites the prototype of
KF_IMPLICIT_ARGS kfuncs itself, which is consistent with the
explanation in the changelog for dropping the 1.26 requirement.
- The English document has no KF_IMPLICIT_ARGS paragraph any more, so
removing the Italian copy brings it_IT back in line with it.
- You mention that htmldocs was not run, so I built
SPHINXDIRS=process and SPHINXDIRS=translations/it_IT with the patch
applied: no new warnings compared to the unpatched tree. The
undefined-label warnings that show up in these two files also show
up without the patch in partial builds.
One process remark, which I leave to Jon: "Assisted-by:" is not a tag
that Documentation/process/ describes in docs-next, and checkpatch
flags it. I could not find the "Attribution" section of
coding-assistants.rst that the note mentions in this tree; it may be in
another one.
Reviewed-by: Daniel Pereira <danielmaraboo@gmail.com>
Thanks,
Daniel
Em qua., 21 de out. de 2026 às 22:48, Mark Severson
<gr3yf0x87@skyn3tlab.com> escreveu:
>
> Commit fd5425b67355 ("docs, resolve_btfids: Document kfunc BTF
> annotation emission") removed the paragraph saying that kfuncs annotated
> with KF_IMPLICIT_ARGS need pahole v1.26, because resolve_btfids now
> emits the kfunc BTF annotations that pahole used to produce. That
> paragraph was the reason the requirements table lists pahole 1.26, and
> the table was left unchanged. The text below the table and
> lib/Kconfig.debug (DEBUG_INFO_BTF depends on PAHOLE_VERSION >= 122)
> both still say 1.22.
>
> Set the table back to 1.22, in the English document and in the Italian
> translation, which carries the same table, and remove the Italian
> translation's copy of the paragraph that the English document no longer
> has.
>
> Checked by building linux-next 20261021 with pahole v1.25 and
> CONFIG_DEBUG_INFO_BTF=y: in the vmlinux BTF,
> bpf_task_work_schedule_signal has four arguments and the bpf_kfunc decl
> tag, and bpf_task_work_schedule_signal_impl keeps the
> struct bpf_prog_aux * argument, as Documentation/bpf/kfuncs.rst
> describes for KF_IMPLICIT_ARGS.
>
> Fixes: fd5425b67355 ("docs, resolve_btfids: Document kfunc BTF annotation emission")
> Assisted-by: Claude
> Signed-off-by: Mark Severson <gr3yf0x87@skyn3tlab.com>
> ---
> v2:
> - Also remove the Italian translation's copy of the KF_IMPLICIT_ARGS /
> pahole 1.26 paragraph, which fd5425b67355 removed from the English
> document only; v1 left the Italian text contradicting its own table.
> Found by the Sashiko review of v1.
> v1: https://lore.kernel.org/all/20261022013432.2638010-1-gr3yf0x87@skyn3tlab.com/
>
> checkpatch reports the Assisted-by tag as non-standard; it follows the
> Attribution section of Documentation/process/coding-assistants.rst as
> published on docs.kernel.org. Not run: make htmldocs; the change keeps
> the table's column widths and removes a whole paragraph.
>
> Documentation/process/changes.rst | 2 +-
> Documentation/translations/it_IT/process/changes.rst | 8 +-------
> 2 files changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/process/changes.rst b/Documentation/process/changes.rst
> index 28f2ca633..13093c5c2 100644
> --- a/Documentation/process/changes.rst
> +++ b/Documentation/process/changes.rst
> @@ -53,7 +53,7 @@ mcelog 0.6 mcelog --version
> mkimage (optional) 2017.01 mkimage --version
> nfs-utils 1.0.5 showmount --version
> openssl & libcrypto 1.0.0 openssl version
> -pahole 1.26 pahole --version
> +pahole 1.22 pahole --version
> pcmciautils 004 pccardctl -V
> pigz (optional) 2.4 pigz --version
> PPP 2.4.0 pppd --version
> diff --git a/Documentation/translations/it_IT/process/changes.rst b/Documentation/translations/it_IT/process/changes.rst
> index 0be1292a8..b4accd428 100644
> --- a/Documentation/translations/it_IT/process/changes.rst
> +++ b/Documentation/translations/it_IT/process/changes.rst
> @@ -57,7 +57,7 @@ mcelog 0.6 mcelog --version
> mkimage (opzionale) 2017.01 mkimage --version
> nfs-utils 1.0.5 showmount --version
> openssl & libcrypto 1.0.0 openssl version
> -pahole 1.26 pahole --version
> +pahole 1.22 pahole --version
> pcmciautils 004 pccardctl -V
> PPP 2.4.0 pppd --version
> procps 3.2.0 ps --version
> @@ -149,12 +149,6 @@ Dalla versione 5.2, quando viene impostato CONFIG_DEBUG_INFO_BTF, il sistema di
> compilazione genera BTF (BPF Type Format) a partire da DWARF per vmlinux. Più
> tardi anche per i moduli. Questo richiede pahole v1.22 o successivo.
>
> -Dalla versione 7.0, le kfunc annotate con KF_IMPLICIT_ARGS richiedono pahole
> -v1.26 o successivo. Senza questa versione, tali kfunc avranno prototipi BTF
> -errati in vmlinux, causando il fallimento del caricamento dei programmi BPF con
> -l'errore "func_proto incompatible with vmlinux". Molte kfunc in sched_ext sono
> -interessate da questo problema.
> -
> A seconda della distribuzione, lo si può trovare nei pacchetti 'dwarves' o
> 'pahole'. Oppure lo si può trovare qui: https://fedorapeople.org/~acme/dwarves/.
>
> --
> 2.43.0
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] docs: changes.rst: set the pahole minimum back to 1.22
2026-10-22 1:48 ` [PATCH v2] " Mark Severson
2026-10-24 10:09 ` Nguyen Duc Thinh
2026-10-25 13:22 ` Daniel Pereira
@ 2026-10-25 20:20 ` Krzysztof Kozlowski
2 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-10-25 20:20 UTC (permalink / raw)
To: Mark Severson, Jonathan Corbet, Federico Vaga
Cc: Shuah Khan, Randy Dunlap, Ihor Solodrai, Eduard Zingerman,
workflows, linux-doc, bpf, linux-kernel
On 22/10/2026 03:48, Mark Severson wrote:
> Fixes: fd5425b67355 ("docs, resolve_btfids: Document kfunc BTF annotation emission")
> Assisted-by: Claude
> Signed-off-by: Mark Severson <gr3yf0x87@skyn3tlab.com>
> ---
> v2:
> - Also remove the Italian translation's copy of the KF_IMPLICIT_ARGS /
> pahole 1.26 paragraph, which fd5425b67355 removed from the English
> document only; v1 left the Italian text contradicting its own table.
> Found by the Sashiko review of v1.
> v1: https://lore.kernel.org/all/20261022013432.2638010-1-gr3yf0x87@skyn3tlab.com/
>
> checkpatch reports the Assisted-by tag as non-standard; it follows the
> Attribution section of Documentation/process/coding-assistants.rst as
> published on docs.kernel.org. Not run: make htmldocs; the change keeps
> the table's column widths and removes a whole paragraph.
As checkpatch asked you, drop the tag. Claude is anyway wrong value for
it (older value was LLM).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread