* [PATCH -next] dm: Remove unused declaration dm_get_rq_mapinfo()
@ 2023-08-08 15:03 Yue Haibing
2023-08-08 17:03 ` Hugo Villeneuve
0 siblings, 1 reply; 5+ messages in thread
From: Yue Haibing @ 2023-08-08 15:03 UTC (permalink / raw)
To: agk, snitzer, dm-devel, heinzm; +Cc: linux-kernel, yuehaibing
Commit ae6ad75e5c3c ("dm: remove unused dm_get_rq_mapinfo()")
removed the implementation but leave declaration.
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
include/linux/device-mapper.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/device-mapper.h b/include/linux/device-mapper.h
index 69d0435c7ebb..5bc69c6a64e0 100644
--- a/include/linux/device-mapper.h
+++ b/include/linux/device-mapper.h
@@ -502,7 +502,6 @@ int dm_post_suspending(struct dm_target *ti);
int dm_noflush_suspending(struct dm_target *ti);
void dm_accept_partial_bio(struct bio *bio, unsigned int n_sectors);
void dm_submit_bio_remap(struct bio *clone, struct bio *tgt_clone);
-union map_info *dm_get_rq_mapinfo(struct request *rq);
#ifdef CONFIG_BLK_DEV_ZONED
struct dm_report_zones_args {
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] dm: Remove unused declaration dm_get_rq_mapinfo()
2023-08-08 15:03 [PATCH -next] dm: Remove unused declaration dm_get_rq_mapinfo() Yue Haibing
@ 2023-08-08 17:03 ` Hugo Villeneuve
2023-08-09 3:03 ` Yue Haibing
0 siblings, 1 reply; 5+ messages in thread
From: Hugo Villeneuve @ 2023-08-08 17:03 UTC (permalink / raw)
To: Yue Haibing; +Cc: agk, snitzer, dm-devel, heinzm, linux-kernel
On Tue, 8 Aug 2023 23:03:01 +0800
Yue Haibing <yuehaibing@huawei.com> wrote:
Hi,
> Commit ae6ad75e5c3c ("dm: remove unused dm_get_rq_mapinfo()")
> removed the implementation but leave declaration.
Maybe change to "removed the implementation but not the declaration."
Hugo Villeneuve.
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> include/linux/device-mapper.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/device-mapper.h b/include/linux/device-mapper.h
> index 69d0435c7ebb..5bc69c6a64e0 100644
> --- a/include/linux/device-mapper.h
> +++ b/include/linux/device-mapper.h
> @@ -502,7 +502,6 @@ int dm_post_suspending(struct dm_target *ti);
> int dm_noflush_suspending(struct dm_target *ti);
> void dm_accept_partial_bio(struct bio *bio, unsigned int n_sectors);
> void dm_submit_bio_remap(struct bio *clone, struct bio *tgt_clone);
> -union map_info *dm_get_rq_mapinfo(struct request *rq);
>
> #ifdef CONFIG_BLK_DEV_ZONED
> struct dm_report_zones_args {
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] dm: Remove unused declaration dm_get_rq_mapinfo()
2023-08-08 17:03 ` Hugo Villeneuve
@ 2023-08-09 3:03 ` Yue Haibing
0 siblings, 0 replies; 5+ messages in thread
From: Yue Haibing @ 2023-08-09 3:03 UTC (permalink / raw)
To: Hugo Villeneuve; +Cc: agk, snitzer, dm-devel, heinzm, linux-kernel
On 2023/8/9 1:03, Hugo Villeneuve wrote:
> On Tue, 8 Aug 2023 23:03:01 +0800
> Yue Haibing <yuehaibing@huawei.com> wrote:
>
> Hi,
>
>> Commit ae6ad75e5c3c ("dm: remove unused dm_get_rq_mapinfo()")
>> removed the implementation but leave declaration.
>
> Maybe change to "removed the implementation but not the declaration."
Thanks， will do this in v2.
>
> Hugo Villeneuve.
>
>
>> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
>> ---
>> include/linux/device-mapper.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/include/linux/device-mapper.h b/include/linux/device-mapper.h
>> index 69d0435c7ebb..5bc69c6a64e0 100644
>> --- a/include/linux/device-mapper.h
>> +++ b/include/linux/device-mapper.h
>> @@ -502,7 +502,6 @@ int dm_post_suspending(struct dm_target *ti);
>> int dm_noflush_suspending(struct dm_target *ti);
>> void dm_accept_partial_bio(struct bio *bio, unsigned int n_sectors);
>> void dm_submit_bio_remap(struct bio *clone, struct bio *tgt_clone);
>> -union map_info *dm_get_rq_mapinfo(struct request *rq);
>>
>> #ifdef CONFIG_BLK_DEV_ZONED
>> struct dm_report_zones_args {
>> --
>> 2.34.1
>>
>
> .
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH -next] dm: Remove unused declaration dm_get_rq_mapinfo()
@ 2024-08-01 13:31 Yue Haibing
2024-08-02 0:48 ` Damien Le Moal
0 siblings, 1 reply; 5+ messages in thread
From: Yue Haibing @ 2024-08-01 13:31 UTC (permalink / raw)
To: agk, snitzer, mpatocka, dlemoal; +Cc: dm-devel, linux-kernel, yuehaibing
Commit ae6ad75e5c3c ("dm: remove unused dm_get_rq_mapinfo()")
removed the implementation but leave declaration.
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
include/linux/device-mapper.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/device-mapper.h b/include/linux/device-mapper.h
index 53ca3a913d06..8321f65897f3 100644
--- a/include/linux/device-mapper.h
+++ b/include/linux/device-mapper.h
@@ -524,7 +524,6 @@ int dm_post_suspending(struct dm_target *ti);
int dm_noflush_suspending(struct dm_target *ti);
void dm_accept_partial_bio(struct bio *bio, unsigned int n_sectors);
void dm_submit_bio_remap(struct bio *clone, struct bio *tgt_clone);
-union map_info *dm_get_rq_mapinfo(struct request *rq);
#ifdef CONFIG_BLK_DEV_ZONED
struct dm_report_zones_args {
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] dm: Remove unused declaration dm_get_rq_mapinfo()
2024-08-01 13:31 Yue Haibing
@ 2024-08-02 0:48 ` Damien Le Moal
0 siblings, 0 replies; 5+ messages in thread
From: Damien Le Moal @ 2024-08-02 0:48 UTC (permalink / raw)
To: Yue Haibing, agk, snitzer, mpatocka; +Cc: dm-devel, linux-kernel
On 8/1/24 22:31, Yue Haibing wrote:
> Commit ae6ad75e5c3c ("dm: remove unused dm_get_rq_mapinfo()")
> removed the implementation but leave declaration.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-08-02 0:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-08 15:03 [PATCH -next] dm: Remove unused declaration dm_get_rq_mapinfo() Yue Haibing
2023-08-08 17:03 ` Hugo Villeneuve
2023-08-09 3:03 ` Yue Haibing
2024-08-01 13:31 Yue Haibing
2024-08-02 0:48 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®