From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Shawn Guo <shengchao.guo@oss.qualcomm.com>,
Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Yu Zhang <yu.zhang@oss.qualcomm.com>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abel Vesa <abel.vesa@oss.qualcomm.com>,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Subject: Re: [PATCH v2 1/5] arm64: dts: qcom: nord: Add PCIe PHY and controller nodes
Date: Mon, 12 Oct 2026 09:40:24 +0200 [thread overview]
Message-ID: <2ca0fff3-aadc-4dcd-93e8-df2ffbac08ab@oss.qualcomm.com> (raw)
In-Reply-To: <asyANRr8ac_SD0CG@QCOM-aGQu4IUr3Y>
On 10/12/26 8:37 AM, Shawn Guo wrote:
> On Mon, Oct 12, 2026 at 10:52:34AM +0530, Krishna Chaitanya Chundru wrote:
>>
>>
>> On 10/10/2026 8:04 AM, Shawn Guo wrote:
>>> On Tue, Sep 15, 2026 at 09:56:28AM +0800, Shawn Guo wrote:
>>>> From: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
[...]
>>>> + perst-pins {
>>>> + pins = "gpio2";
>>>> + function = "gpio";
>>>> + drive-strength = <2>;
>>>> + bias-disable;
>>>> + };
>>> pcie0_clk_req_n is a SoC level pin function, so it has a good reason to
>>> stay here. But wake and perst are board chosen GPIOs. I think they should
>>> go to board DTS.
>> Shawn, I don't see perst and wake gpios are changing per board, for that
>> reason I added them here, but such requirement is coming we can move them to
>> board file.
>
> Well, we have only seen Ride and RRD so far. We never know how other Nord
> based boards to come will choose the perst and wake GPIOs. This is
> simply a board level configuration and should go to board dts.
They never do in practice (for a good reason, the reference-chosen pins are
consecutive and presumably next to each other) and we have no occurences of
that in the tree across the hundreds of devices.
Konrad
next prev parent reply other threads:[~2026-10-12 7:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 1:56 [PATCH v2 0/5] arm64: dts: qcom: nord: Add PCIe and WLAN support Shawn Guo
2026-09-15 1:56 ` [PATCH v2 1/5] arm64: dts: qcom: nord: Add PCIe PHY and controller nodes Shawn Guo
2026-10-10 2:34 ` Shawn Guo
2026-10-12 5:22 ` Krishna Chaitanya Chundru
2026-10-12 6:37 ` Shawn Guo
2026-10-12 7:40 ` Konrad Dybcio [this message]
2026-10-12 8:59 ` Shawn Guo
2026-09-15 1:56 ` [PATCH v2 2/5] arm64: dts: qcom: nord-rrd: Enable PCIe controllers and PHY Shawn Guo
2026-09-15 1:56 ` [PATCH v2 3/5] arm64: dts: qcom: nord-ride-embedded: " Shawn Guo
2026-09-15 1:56 ` [PATCH v2 4/5] arm64: dts: qcom: nord-ride-embedded: Add WCN7850 WLAN support Shawn Guo
2026-09-15 1:56 ` [PATCH v2 5/5] arm64: dts: qcom: nord-rrd: " Shawn Guo
2026-09-28 1:56 ` [PATCH v2 0/5] arm64: dts: qcom: nord: Add PCIe and " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ca0fff3-aadc-4dcd-93e8-df2ffbac08ab@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=abel.vesa@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=shengchao.guo@oss.qualcomm.com \
--cc=yu.zhang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®