Re: [PATCH V2 4/6] rtc: nvvrs: add NVIDIA VRS PSEQ RTC device driver

[Jon Hunter <jonathanh@nvidia.com>]

On 21/05/2025 10:14, Krzysztof Kozlowski wrote:
> On Tue, May 20, 2025 at 09:08:30AM GMT, Shubhi Garg wrote:
>> Add support for NVIDIA VRS (Voltage Regulator Specification) Power
>> Sequencer RTC device driver. This RTC can be used to get/set system
>> time, retain system time across boot, wake system from suspend and
>> shutdown state.
>>
>> Signed-off-by: Shubhi Garg <shgarg@nvidia.com>
>> ---
>>
>> v2:
>> - removed regmap struct since it is not required
>> - removed rtc_map definition to directly use register definition
>> - removed unnecessary dev_err logs
>> - fixed dev_err logs to dev_dbg
>> - used rtc_lock/unlock in irq handler
>> - changed RTC allocation and register APIs as per latest kernel
>> - removed nvvrs_rtc_remove function since it's not required
>>
>>   drivers/rtc/Kconfig               |  10 +
>>   drivers/rtc/Makefile              |   1 +
>>   drivers/rtc/rtc-nvidia-vrs-pseq.c | 456 ++++++++++++++++++++++++++++++
>>   3 files changed, 467 insertions(+)
>>   create mode 100644 drivers/rtc/rtc-nvidia-vrs-pseq.c
>>
>> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
>> index 838bdc138ffe..3b6dc27a50af 100644
>> --- a/drivers/rtc/Kconfig
>> +++ b/drivers/rtc/Kconfig
>> @@ -406,6 +406,16 @@ config RTC_DRV_MAX77686
>>   	  This driver can also be built as a module. If so, the module
>>   	  will be called rtc-max77686.
>>   
>> +config RTC_DRV_NVVRS_PSEQ
>> +	tristate "NVIDIA VRS Power Sequencer RTC device"
>> +	depends on MFD_NVVRS_PSEQ
> 
> I bet this fails when MFD_NVVRS_PSEQ is a module.


This is building fine for me when MFD_NVVRS_PSEQ is a module. 	

The 'depends on I2C=y' in patch 3/6 definitely needs correcting as you 
highlighted and will be fixed in the next version of this series.

Cheers
Jon

-- 
nvpublic