mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* is_device_dma_capable
@ 2009-06-16  7:24 Malcom Blaney
  2009-06-16  8:12 ` is_device_dma_capable FUJITA Tomonori
  0 siblings, 1 reply; 5+ messages in thread
From: Malcom Blaney @ 2009-06-16  7:24 UTC (permalink / raw)
  To: linux-kernel

Hello,

I'm using the parport_pc driver with a dma buffer, which is provided
by calling dma_alloc_coherent in arch/x86/include/asm/dma-mapping.h.

This is no longer working for me in 2.6.29.2, the previous version I
was using is 2.6.25.10, which was fine with the same hardware.

The problem is that the call to is_device_dma_capable returns false,
so dma_alloc_coherent returns NULL. Do I need to set the dma_mask in
the driver for this to work correctly?

thanks,
Malcolm.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: is_device_dma_capable
  2009-06-16  7:24 is_device_dma_capable Malcom Blaney
@ 2009-06-16  8:12 ` FUJITA Tomonori
  2009-06-16  8:23   ` is_device_dma_capable Malcom Blaney
  0 siblings, 1 reply; 5+ messages in thread
From: FUJITA Tomonori @ 2009-06-16  8:12 UTC (permalink / raw)
  To: malcolm.blaney; +Cc: linux-kernel

On Tue, 16 Jun 2009 16:54:24 +0930
Malcom Blaney <malcolm.blaney@maptek.com.au> wrote:

> I'm using the parport_pc driver with a dma buffer, which is provided
> by calling dma_alloc_coherent in arch/x86/include/asm/dma-mapping.h.
> 
> This is no longer working for me in 2.6.29.2, the previous version I
> was using is 2.6.25.10, which was fine with the same hardware.
> 
> The problem is that the call to is_device_dma_capable returns false,
> so dma_alloc_coherent returns NULL. Do I need to set the dma_mask in
> the driver for this to work correctly?

You use X86_32, right?

In 2.6.25, X86_32 and X86_64 had the own dma_alloc_coherent
implementations; X86_32 accepted a device having dma_mask that is not
initialized however X86_64 didn't, I think.

When we merged them, we chose to prohibit a device having dma_mask
that is not initialized. I'm not sure the DMA docs say this but IMO
it's good to require drivers to set up dma_mask (and
coherent_dma_mask) properly if the drivers want DMA.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: is_device_dma_capable
  2009-06-16  8:12 ` is_device_dma_capable FUJITA Tomonori
@ 2009-06-16  8:23   ` Malcom Blaney
  2009-06-16  8:55     ` is_device_dma_capable FUJITA Tomonori
  0 siblings, 1 reply; 5+ messages in thread
From: Malcom Blaney @ 2009-06-16  8:23 UTC (permalink / raw)
  To: FUJITA Tomonori; +Cc: linux-kernel

Hi Fujita,

2009/6/16 FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>:
> You use X86_32, right?

I have CONFIG_X86_32=y in my config file.

>
> In 2.6.25, X86_32 and X86_64 had the own dma_alloc_coherent
> implementations; X86_32 accepted a device having dma_mask that is not
> initialized however X86_64 didn't, I think.
>
> When we merged them, we chose to prohibit a device having dma_mask
> that is not initialized. I'm not sure the DMA docs say this but IMO
> it's good to require drivers to set up dma_mask (and
> coherent_dma_mask) properly if the drivers want DMA.
>

If you could point me in the direction of how to set these values
correctly, I would appreciate it.

thanks,
Malcolm.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: is_device_dma_capable
  2009-06-16  8:23   ` is_device_dma_capable Malcom Blaney
@ 2009-06-16  8:55     ` FUJITA Tomonori
  2009-06-17  1:10       ` is_device_dma_capable Malcom Blaney
  0 siblings, 1 reply; 5+ messages in thread
From: FUJITA Tomonori @ 2009-06-16  8:55 UTC (permalink / raw)
  To: malcolm.blaney; +Cc: fujita.tomonori, linux-kernel

On Tue, 16 Jun 2009 17:53:03 +0930
Malcom Blaney <malcolm.blaney@maptek.com.au> wrote:

> Hi Fujita,
> 
> 2009/6/16 FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>:
> > You use X86_32, right?
> 
> I have CONFIG_X86_32=y in my config file.
> 
> >
> > In 2.6.25, X86_32 and X86_64 had the own dma_alloc_coherent
> > implementations; X86_32 accepted a device having dma_mask that is not
> > initialized however X86_64 didn't, I think.
> >
> > When we merged them, we chose to prohibit a device having dma_mask
> > that is not initialized. I'm not sure the DMA docs say this but IMO
> > it's good to require drivers to set up dma_mask (and
> > coherent_dma_mask) properly if the drivers want DMA.
> >
> 
> If you could point me in the direction of how to set these values
> correctly, I would appreciate it.

You hit the problem that a device that parport_pc_probe_port creates
but doesn't set up the dma_mask properly, right (I'm not familiar with
the driver at all so I might misunderstand something)?

If so, I guess that the following patch works (only compile tested).


diff --git a/drivers/parport/parport_pc.c b/drivers/parport/parport_pc.c
index 151bf5b..1af57b7 100644
--- a/drivers/parport/parport_pc.c
+++ b/drivers/parport/parport_pc.c
@@ -2271,6 +2271,9 @@ struct parport *parport_pc_probe_port(unsigned long int base,
 		if (IS_ERR(pdev))
 			return NULL;
 		dev = &pdev->dev;
+
+		dev->coherent_dma_mask = DMA_BIT_MASK(24);
+		dev->dma_mask = &dev->coherent_dma_mask;
 	}
 
 	ops = kmalloc(sizeof(struct parport_operations), GFP_KERNEL);

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: is_device_dma_capable
  2009-06-16  8:55     ` is_device_dma_capable FUJITA Tomonori
@ 2009-06-17  1:10       ` Malcom Blaney
  0 siblings, 0 replies; 5+ messages in thread
From: Malcom Blaney @ 2009-06-17  1:10 UTC (permalink / raw)
  To: FUJITA Tomonori; +Cc: linux-kernel, linux-parport

Thanks Fujita, your patch worked a treat!

2009/6/16 FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>:
> On Tue, 16 Jun 2009 17:53:03 +0930
> Malcom Blaney <malcolm.blaney@maptek.com.au> wrote:
>
>> Hi Fujita,
>>
>> 2009/6/16 FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>:
>> > You use X86_32, right?
>>
>> I have CONFIG_X86_32=y in my config file.
>>
>> >
>> > In 2.6.25, X86_32 and X86_64 had the own dma_alloc_coherent
>> > implementations; X86_32 accepted a device having dma_mask that is not
>> > initialized however X86_64 didn't, I think.
>> >
>> > When we merged them, we chose to prohibit a device having dma_mask
>> > that is not initialized. I'm not sure the DMA docs say this but IMO
>> > it's good to require drivers to set up dma_mask (and
>> > coherent_dma_mask) properly if the drivers want DMA.
>> >
>>
>> If you could point me in the direction of how to set these values
>> correctly, I would appreciate it.
>
> You hit the problem that a device that parport_pc_probe_port creates
> but doesn't set up the dma_mask properly, right (I'm not familiar with
> the driver at all so I might misunderstand something)?
>
> If so, I guess that the following patch works (only compile tested).
>
>
> diff --git a/drivers/parport/parport_pc.c b/drivers/parport/parport_pc.c
> index 151bf5b..1af57b7 100644
> --- a/drivers/parport/parport_pc.c
> +++ b/drivers/parport/parport_pc.c
> @@ -2271,6 +2271,9 @@ struct parport *parport_pc_probe_port(unsigned long int base,
>                if (IS_ERR(pdev))
>                        return NULL;
>                dev = &pdev->dev;
> +
> +               dev->coherent_dma_mask = DMA_BIT_MASK(24);
> +               dev->dma_mask = &dev->coherent_dma_mask;
>        }
>
>        ops = kmalloc(sizeof(struct parport_operations), GFP_KERNEL);
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2009-06-17  1:10 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-16  7:24 is_device_dma_capable Malcom Blaney
2009-06-16  8:12 ` is_device_dma_capable FUJITA Tomonori
2009-06-16  8:23   ` is_device_dma_capable Malcom Blaney
2009-06-16  8:55     ` is_device_dma_capable FUJITA Tomonori
2009-06-17  1:10       ` is_device_dma_capable Malcom Blaney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®