Re: [PATCH v5 0/2] rohm-bdi718x7/71828: Use software nodes for gpio-keys

[Matti Vaittinen <mazziesaccount@gmail.com>]

On 12/06/2026 08:09, Dmitry Torokhov wrote:
> Hi Matti,
> 
> On Fri, Jun 12, 2026 at 07:40:49AM +0300, Matti Vaittinen wrote:
>> On 12/06/2026 07:38, Matti Vaittinen wrote:
>>> On 11/06/2026 18:48, Dmitry Torokhov wrote:
>>>> Now that gpio-keys can use platform resources to identify interrupts
>>>> assigned to buttons we can convert ROHM power buttons to use software
>>>> nodes and device properties for configuration, removing the need to use
>>>> platform data.
>>>>
>>>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>>>   > ---> Changes in v5:
>>>> Addressed Lee's comments:
>>>> - moved static constants out of function to module level
>>>> - added #defines for nodes' indexes
>>>> - adjusted error message
>>>> - renamed "error" to "ret"
>>>> - dropped unneeded comments
>>>> - Link to v4: https://patch.msgid.link/20260427-rohm-software-nodes-
>>>> v4-0-ffeb5b0c4774@gmail.com
>>>
>>> I think I did already review these? Is there a reason my tags were dropped?
>>
>> "These" referring to these patches, not the v5 changes (which seem minor to
>> drop the tags).
> 
> Sorry, I decided to exercise caution and not carry over the tags.

Understood. I think there is no generally accepted "golden rule" when to 
drop the tags. I just personally prefer keeping tags unless there are 
functional changes. That helps me avoid going "Deja Vu" -reviews.

The patches look good to me.

>> Furthermore, is there a reason I was not CC'd? Especially if
>> there was a reason to drop the tags.
> 
> I see the following on the emails:
> 
>> To: Matti Vaittinen <mazziesaccount@gmail.com>, Lee Jones <lee@kernel.org>
> 
> so I am not sure why they did not reach you...

Ah. This is 100% my bad. I was only checking the CC-field. I need to fix 
my filters.
Yours,
	-- Matti

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~