From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>, Lee Jones <lee@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/2] rohm-bdi718x7/71828: Use software nodes for gpio-keys
Date: Fri, 12 Jun 2026 07:38:11 +0300 [thread overview]
Message-ID: <edf1cd70-7822-45d1-887c-585136da92a6@gmail.com> (raw)
In-Reply-To: <20260611-rohm-software-nodes-v5-0-0244664a3b65@gmail.com>
On 11/06/2026 18:48, Dmitry Torokhov wrote:
> Now that gpio-keys can use platform resources to identify interrupts
> assigned to buttons we can convert ROHM power buttons to use software
> nodes and device properties for configuration, removing the need to use
> platform data.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---> Changes in v5:
> Addressed Lee's comments:
> - moved static constants out of function to module level
> - added #defines for nodes' indexes
> - adjusted error message
> - renamed "error" to "ret"
> - dropped unneeded comments
> - Link to v4: https://patch.msgid.link/20260427-rohm-software-nodes-v4-0-ffeb5b0c4774@gmail.com
I think I did already review these? Is there a reason my tags were dropped?
Yours,
-- Matti
next prev parent reply other threads:[~2026-06-12 4:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 15:48 Dmitry Torokhov
2026-06-11 15:48 ` [PATCH v5 1/2] mfd: rohm-bd71828: " Dmitry Torokhov
2026-06-11 15:48 ` [PATCH v5 2/2] mfd: rohm-bd718x7: " Dmitry Torokhov
2026-06-12 4:38 ` Matti Vaittinen [this message]
2026-06-12 4:40 ` [PATCH v5 0/2] rohm-bdi718x7/71828: " Matti Vaittinen
2026-06-12 5:09 ` Dmitry Torokhov
2026-06-12 8:26 ` Matti Vaittinen
2026-06-18 11:17 ` Lee Jones
2026-06-18 11:18 ` Lee Jones
2026-06-18 19:03 ` Dmitry Torokhov
2026-06-19 8:58 ` Lee Jones
2026-07-06 23:17 ` Dmitry Torokhov
2026-07-16 12:36 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edf1cd70-7822-45d1-887c-585136da92a6@gmail.com \
--to=mazziesaccount@gmail.com \
--cc=arnd@arndb.de \
--cc=dmitry.torokhov@gmail.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox