From: Chris Mason <clm@meta.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
dietmar.eggemann@arm.com, vschneid@redhat.com
Subject: Re: scheduler performance regression since v6.11
Date: Mon, 12 May 2025 15:39:31 -0400 [thread overview]
Message-ID: <2f394a01-1cd9-4719-9394-647d8731cf3f@meta.com> (raw)
In-Reply-To: <20250512180846.GA25891@noisy.programming.kicks-ass.net>
On 5/12/25 2:08 PM, Peter Zijlstra wrote:
> On Fri, May 09, 2025 at 09:49:55PM +0200, Peter Zijlstra wrote:
>> 152 729288bc6856 kernel/sched: Fix util_est accounting for DELAY_DEQUEUE
>> average rps: 1936829.47
>> average rps: 1950715.10
>>
>> 153 84d265281d6c sched/pelt: Use rq_clock_task() for hw_pressure
>> average rps: 2176857.32
>> average rps: 2223004.23
>
> So, a little more data on this.
>
> The result appears stable, but reverting 729288bc6856 on master does not
> seem to cure things.
729288bc6856 is in that section of commits where the regression was ~1/2
as bad. (bad: 1.8M, good: 2M, middle ground: 1.9M) I get the same RPS
with and without it.
I called it "good" in my bisect run, but I'll take a second pass through
those potential suspects and see if the bad really starts there.
>
> OTOH, switching to performance governor completely cures things here.
>
> My machine defaults to schedutil governor.
>
> Chris, can you confirm -- or did we manage to find different issues?
My repro script sets to performance w/turbo on as step one. I didn't
turbostat my way to making sure both sides were actually running at the
same frequency, but I'll check that too.
-chris
next prev parent reply other threads:[~2025-05-12 19:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 23:13 Chris Mason
2025-05-09 19:49 ` Peter Zijlstra
2025-05-12 18:08 ` Peter Zijlstra
2025-05-12 19:39 ` Chris Mason [this message]
2025-05-12 22:35 ` Chris Mason
2025-05-13 7:15 ` Peter Zijlstra
2025-05-16 10:18 ` Peter Zijlstra
2025-05-20 14:38 ` Dietmar Eggemann
2025-05-20 14:53 ` Chris Mason
2025-05-21 13:59 ` Dietmar Eggemann
2025-05-21 14:32 ` Chris Mason
2025-05-20 19:38 ` Peter Zijlstra
2025-05-21 14:02 ` Dietmar Eggemann
2025-05-21 15:02 ` Peter Zijlstra
2025-05-21 19:00 ` Peter Zijlstra
2025-05-21 14:54 ` Peter Zijlstra
2025-05-22 8:48 ` Peter Zijlstra
2025-05-22 15:00 ` Johannes Weiner
2025-05-23 15:40 ` Peter Zijlstra
2025-05-23 12:27 ` Dietmar Eggemann
2025-07-10 12:46 ` [tip: sched/core] sched/psi: Optimize psi_group_change() cpu_clock() usage tip-bot2 for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f394a01-1cd9-4719-9394-647d8731cf3f@meta.com \
--to=clm@meta.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®