mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [GIT PULL] Block fixes for 4.8-rc4
@ 2016-08-26 15:16 Jens Axboe
  2016-08-27  1:55 ` Linus Torvalds
  0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2016-08-26 15:16 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

Hi Linus,

Here's a set of block fixes for the current 4.8-rc release. This pull
request contains:

- A fix for a secure erase regression, from Adrian.

- A fix for an mmc use-after-free bug regression, also from Adrian.

- Potential zero pointer deference in bdev freezing, from Andrey.

- A race fix for blk_set_queue_dying() from Bart.

- A set of xen blkfront fixes from Bob Liu.

- Three small fixes for bcache, from Eric and Kent.

- A fix for a potential invalid NVMe state transition, from Gabriel.

- blk-mq CPU offline fix, preventing us from issuing and completing
   a request on the wrong queue. From me.

- Revert two previous floppy changes, since they caused a user visibile
   regression. A better fix is in the works.

- Ensure that we don't send down bios that have more than 256 elements
   in them. Fixes a crash with bcache, for example. From Ming.

- A fix for deferencing an error pointer with cgroup writeback. Fixes
   a regression. From Vegard.

Please pull for 4.8-rc4! Thanks.


   git://git.kernel.dk/linux-block.git for-linus


----------------------------------------------------------------
Adrian Hunter (2):
       block: Fix secure erase
       mmc: fix use-after-free of struct request

Andrey Ryabinin (1):
       fs/block_dev: fix potential NULL ptr deref in freeze_bdev()

Andy Lutomirski (1):
       nvme: Fix nvme_get/set_features() with a NULL result pointer

Bart Van Assche (1):
       block: Fix race triggered by blk_set_queue_dying()

Bob Liu (3):
       xen-blkfront: fix places not updated after introducing 64KB page 
granularity
       xen-blkfront: introduce blkif_set_queue_limits()
       xen-blkfront: free resources if xlvbd_alloc_gendisk fails

Eric Wheeler (2):
       bcache: register_bcache(): call blkdev_put() when cache_alloc() fails
       bcache: pr_err: more meaningful error message when nr_stripes is 
invalid

Gabriel Krisman Bertazi (1):
       nvme: Prevent controller state invalid transition

Jens Axboe (6):
       Merge branch 'stable/for-jens-4.8-for-linus' of 
git://git.kernel.org/.../konrad/xen into for-linus
       Merge branch 'v4.8-rc2-bcache-fixes' of 
https://bitbucket.org/ewheelerinc/linux into for-linus
       blk-mq: don't overwrite rq->mq_ctx
       blk-mq: improve warning for running a queue on the wrong CPU
       Revert "floppy: fix open(O_ACCMODE) for ioctl-only open"
       Revert "floppy: refactor open() flags handling"

Kent Overstreet (1):
       bcache: RESERVE_PRIO is too small by one when prio_buckets() is a 
power of two.

Ming Lei (1):
       block: make sure a big bio is split into at most 256 bvecs

Vegard Nossum (1):
       bdev: fix NULL pointer dereference

  block/bio.c                  | 21 +++++-----
  block/blk-core.c             |  4 +-
  block/blk-merge.c            | 55 ++++++++++++++++++-------
  block/blk-mq.c               | 60 +++++++++------------------
  block/elevator.c             |  2 +-
  drivers/block/floppy.c       | 27 ++++++------
  drivers/block/xen-blkfront.c | 97 
+++++++++++++++++++++++++-------------------
  drivers/md/bcache/super.c    | 14 +++++--
  drivers/mmc/card/block.c     |  5 ++-
  drivers/mmc/card/queue.c     |  7 +++-
  drivers/mmc/card/queue.h     |  4 +-
  drivers/nvme/host/core.c     | 11 +++--
  fs/block_dev.c               |  5 ++-
  include/linux/bio.h          | 10 ++++-
  include/linux/blkdev.h       |  6 ++-
  kernel/trace/blktrace.c      |  2 +-
  16 files changed, 188 insertions(+), 142 deletions(-)

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [GIT PULL] Block fixes for 4.8-rc4
  2016-08-26 15:16 [GIT PULL] Block fixes for 4.8-rc4 Jens Axboe
@ 2016-08-27  1:55 ` Linus Torvalds
  2016-08-27  4:42   ` Jens Axboe
  0 siblings, 1 reply; 3+ messages in thread
From: Linus Torvalds @ 2016-08-27  1:55 UTC (permalink / raw)
  To: Jens Axboe; +Cc: linux-kernel

On Fri, Aug 26, 2016 at 8:16 AM, Jens Axboe <axboe@fb.com> wrote:
> Hi Linus,
>
> - Revert two previous floppy changes, since they caused a user visibile
>   regression. A better fix is in the works.

Those reverts have no sign-off, and no explanation for them.

No, a revert may not have any copyright value, but the sign-offs have
been our main way to also see who actually did stuff and what the
chain was. All the usual "who caused this" background for reverts.

What was it that went wrong? Nobody knows. Not from the logs, at least.

I pulled it, but just FYI: reverts need explanations too. They need to
explain why they happened and what went wrong.

              Linus

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [GIT PULL] Block fixes for 4.8-rc4
  2016-08-27  1:55 ` Linus Torvalds
@ 2016-08-27  4:42   ` Jens Axboe
  0 siblings, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2016-08-27  4:42 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

On 08/26/2016 07:55 PM, Linus Torvalds wrote:
> On Fri, Aug 26, 2016 at 8:16 AM, Jens Axboe <axboe@fb.com> wrote:
>> Hi Linus,
>>
>> - Revert two previous floppy changes, since they caused a user visibile
>>   regression. A better fix is in the works.
>
> Those reverts have no sign-off, and no explanation for them.
>
> No, a revert may not have any copyright value, but the sign-offs have
> been our main way to also see who actually did stuff and what the
> chain was. All the usual "who caused this" background for reverts.
>
> What was it that went wrong? Nobody knows. Not from the logs, at least.

You are right, those reverts should have the reasoning included.

> I pulled it, but just FYI: reverts need explanations too. They need to
> explain why they happened and what went wrong.

Thanks.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-08-27  4:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-26 15:16 [GIT PULL] Block fixes for 4.8-rc4 Jens Axboe
2016-08-27  1:55 ` Linus Torvalds
2016-08-27  4:42   ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®