Re: [PATCH 13/29] crypto: talitos/skcipher - Convert to init/exit type-specific API

["Christophe Leroy (CS GROUP)" <chleroy@kernel.org>]

Le 28/05/2026 à 11:08, Paul Louvel a écrit :
> Since commit 6eed1e3552fc0 ("crypto: api - Mark cra_init/cra_exit as
> deprecated"), both cra_{init,exit} are deprecated.
> 
> Restore the type-specific talitos_cra_exit_skcipher() wrapper and use
> skcipher_alg->exit instead of the generic cra_exit field, matching the
> pattern used by init.
> 
> Signed-off-by: Paul Louvel <paul.louvel@bootlin.com>

Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>

> ---
>   drivers/crypto/talitos/talitos-skcipher.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/talitos/talitos-skcipher.c b/drivers/crypto/talitos/talitos-skcipher.c
> index ff7b8f9344c4..f86a0a9a0ffe 100644
> --- a/drivers/crypto/talitos/talitos-skcipher.c
> +++ b/drivers/crypto/talitos/talitos-skcipher.c
> @@ -232,6 +232,11 @@ static int talitos_cra_init_skcipher(struct crypto_skcipher *tfm)
>   	return talitos_init_common(ctx, talitos_alg);
>   }
>   
> +static void talitos_cra_exit_skcipher(struct crypto_skcipher *tfm)
> +{
> +	talitos_cra_exit(crypto_skcipher_tfm(tfm));
> +}
> +
>   static struct talitos_alg_template skcipher_driver_algs[] = {
>   	{	.type = CRYPTO_ALG_TYPE_SKCIPHER,
>   		.alg.skcipher = {
> @@ -410,8 +415,8 @@ int talitos_register_skcipher(struct device *dev)
>   		if (has_ftr_sec1(priv))
>   			alg->cra_alignmask = 3;
>   
> -		alg->cra_exit = talitos_cra_exit;
>   		skcipher_alg->init = talitos_cra_init_skcipher;
> +		skcipher_alg->exit = talitos_cra_exit_skcipher;
>   		skcipher_alg->setkey = skcipher_alg->setkey ?: skcipher_setkey;
>   		skcipher_alg->encrypt = skcipher_encrypt;
>   		skcipher_alg->decrypt = skcipher_decrypt;
>