Re: [PATCH 02/29] crypto: talitos - Move driver into dedicated directory

["Christophe Leroy (CS GROUP)" <chleroy@kernel.org>]

Le 28/05/2026 à 11:08, Paul Louvel a écrit :
> Move the talitos driver files from drivers/crypto/ into
> drivers/crypto/talitos/ to accommodate upcoming code
> reorganization.
> 
> Signed-off-by: Paul Louvel <paul.louvel@bootlin.com>

Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>

> ---
>   drivers/crypto/Kconfig                 | 38 +---------------------------------
>   drivers/crypto/Makefile                |  2 +-
>   drivers/crypto/talitos/Kconfig         | 36 ++++++++++++++++++++++++++++++++
>   drivers/crypto/talitos/Makefile        |  1 +
>   drivers/crypto/{ => talitos}/talitos.c |  0
>   drivers/crypto/{ => talitos}/talitos.h |  0
>   6 files changed, 39 insertions(+), 38 deletions(-)
> 
> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> index d23b58b81ca3..783b5dc42a42 100644
> --- a/drivers/crypto/Kconfig
> +++ b/drivers/crypto/Kconfig
> @@ -253,43 +253,7 @@ config CRYPTO_DEV_HIFN_795X_RNG
>   	  on the HIFN 795x crypto adapters.
>   
>   source "drivers/crypto/caam/Kconfig"
> -
> -config CRYPTO_DEV_TALITOS
> -	tristate "Talitos Freescale Security Engine (SEC)"
> -	select CRYPTO_AEAD
> -	select CRYPTO_AUTHENC
> -	select CRYPTO_SKCIPHER
> -	select CRYPTO_HASH
> -	select CRYPTO_LIB_DES
> -	select HW_RANDOM
> -	depends on FSL_SOC
> -	help
> -	  Say 'Y' here to use the Freescale Security Engine (SEC)
> -	  to offload cryptographic algorithm computation.
> -
> -	  The Freescale SEC is present on PowerQUICC 'E' processors, such
> -	  as the MPC8349E and MPC8548E.
> -
> -	  To compile this driver as a module, choose M here: the module
> -	  will be called talitos.
> -
> -config CRYPTO_DEV_TALITOS1
> -	bool "SEC1 (SEC 1.0 and SEC Lite 1.2)"
> -	depends on CRYPTO_DEV_TALITOS
> -	depends on PPC_8xx || PPC_82xx
> -	default y
> -	help
> -	  Say 'Y' here to use the Freescale Security Engine (SEC) version 1.0
> -	  found on MPC82xx or the Freescale Security Engine (SEC Lite)
> -	  version 1.2 found on MPC8xx
> -
> -config CRYPTO_DEV_TALITOS2
> -	bool "SEC2+ (SEC version 2.0 or upper)"
> -	depends on CRYPTO_DEV_TALITOS
> -	default y if !PPC_8xx
> -	help
> -	  Say 'Y' here to use the Freescale Security Engine (SEC)
> -	  version 2 and following as found on MPC83xx, MPC85xx, etc ...
> +source "drivers/crypto/talitos/Kconfig"
>   
>   config CRYPTO_DEV_PPC4XX
>   	tristate "Driver AMCC PPC4xx crypto accelerator"
> diff --git a/drivers/crypto/Makefile b/drivers/crypto/Makefile
> index 283bbc650b5b..a059139d4a75 100644
> --- a/drivers/crypto/Makefile
> +++ b/drivers/crypto/Makefile
> @@ -35,7 +35,7 @@ obj-$(CONFIG_CRYPTO_DEV_SA2UL) += sa2ul.o
>   obj-$(CONFIG_CRYPTO_DEV_SAHARA) += sahara.o
>   obj-$(CONFIG_CRYPTO_DEV_SL3516) += gemini/
>   obj-y += stm32/
> -obj-$(CONFIG_CRYPTO_DEV_TALITOS) += talitos.o
> +obj-$(CONFIG_CRYPTO_DEV_TALITOS) += talitos/
>   obj-$(CONFIG_CRYPTO_DEV_TEGRA) += tegra/
>   obj-$(CONFIG_CRYPTO_DEV_VIRTIO) += virtio/
>   obj-$(CONFIG_CRYPTO_DEV_BCM_SPU) += bcm/
> diff --git a/drivers/crypto/talitos/Kconfig b/drivers/crypto/talitos/Kconfig
> new file mode 100644
> index 000000000000..c3470553a966
> --- /dev/null
> +++ b/drivers/crypto/talitos/Kconfig
> @@ -0,0 +1,36 @@
> +config CRYPTO_DEV_TALITOS
> +	tristate "Talitos Freescale Security Engine (SEC)"
> +	select CRYPTO_AEAD
> +	select CRYPTO_AUTHENC
> +	select CRYPTO_SKCIPHER
> +	select CRYPTO_HASH
> +	select CRYPTO_LIB_DES
> +	select HW_RANDOM
> +	depends on FSL_SOC
> +	help
> +	  Say 'Y' here to use the Freescale Security Engine (SEC)
> +	  to offload cryptographic algorithm computation.
> +
> +	  The Freescale SEC is present on PowerQUICC 'E' processors, such
> +	  as the MPC8349E and MPC8548E.
> +
> +	  To compile this driver as a module, choose M here: the module
> +	  will be called talitos.
> +
> +config CRYPTO_DEV_TALITOS1
> +	bool "SEC1 (SEC 1.0 and SEC Lite 1.2)"
> +	depends on CRYPTO_DEV_TALITOS
> +	depends on PPC_8xx || PPC_82xx
> +	default y
> +	help
> +	  Say 'Y' here to use the Freescale Security Engine (SEC) version 1.0
> +	  found on MPC82xx or the Freescale Security Engine (SEC Lite)
> +	  version 1.2 found on MPC8xx
> +
> +config CRYPTO_DEV_TALITOS2
> +	bool "SEC2+ (SEC version 2.0 or upper)"
> +	depends on CRYPTO_DEV_TALITOS
> +	default y if !PPC_8xx
> +	help
> +	  Say 'Y' here to use the Freescale Security Engine (SEC)
> +	  version 2 and following as found on MPC83xx, MPC85xx, etc ...
> diff --git a/drivers/crypto/talitos/Makefile b/drivers/crypto/talitos/Makefile
> new file mode 100644
> index 000000000000..fcc5db5e63c2
> --- /dev/null
> +++ b/drivers/crypto/talitos/Makefile
> @@ -0,0 +1 @@
> +obj-$(CONFIG_CRYPTO_DEV_TALITOS) += talitos.o
> diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos/talitos.c
> similarity index 100%
> rename from drivers/crypto/talitos.c
> rename to drivers/crypto/talitos/talitos.c
> diff --git a/drivers/crypto/talitos.h b/drivers/crypto/talitos/talitos.h
> similarity index 100%
> rename from drivers/crypto/talitos.h
> rename to drivers/crypto/talitos/talitos.h
>