From: Neil Armstrong <neil.armstrong@linaro.org>
To: sebastian.krzyszkowiak@puri.sm, "Guido Günther" <agx@sigxcpu.org>,
"Purism Kernel Team" <kernel@puri.sm>,
"Jessica Zhang" <jesszhan0024@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] drm/panel: mantix: Drop bank 9 initialization
Date: Tue, 6 Jan 2026 09:16:01 +0100 [thread overview]
Message-ID: <307ea449-c8a1-4fd7-a67b-7c6777eb4669@linaro.org> (raw)
In-Reply-To: <20260105-mantix-halo-fixes-v1-4-1ebc9b195a34@puri.sm>
On 1/5/26 21:24, Sebastian Krzyszkowiak via B4 Relay wrote:
> From: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
>
> This command is part of LIC sequence included in FT8006P firmware.
> There's no need to repeat it here.
>
> Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
> ---
> drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
> index 0e66ee7a727d..30e378faafcd 100644
> --- a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
> +++ b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
> @@ -53,11 +53,9 @@ static void mantix_init_sequence(struct mipi_dsi_multi_context *dsi_ctx)
> mipi_dsi_generic_write_seq_multi(dsi_ctx, MANTIX_CMD_OTP_STOP_RELOAD_MIPI, 0x5a);
>
> mipi_dsi_generic_write_seq_multi(dsi_ctx, MANTIX_CMD_INT_CANCEL, 0x03);
> - mipi_dsi_generic_write_seq_multi(dsi_ctx, MANTIX_CMD_OTP_STOP_RELOAD_MIPI, 0x5a, 0x03);
> - mipi_dsi_generic_write_seq_multi(dsi_ctx, 0x80, 0xa9, 0x00);
>
> - mipi_dsi_generic_write_seq_multi(dsi_ctx, MANTIX_CMD_OTP_STOP_RELOAD_MIPI, 0x5a, 0x09);
> - mipi_dsi_generic_write_seq_multi(dsi_ctx, 0x80, 0x64, 0x00, 0x64, 0x00, 0x00);
> + mipi_dsi_generic_write_seq_multi(dsi_ctx, MANTIX_CMD_OTP_STOP_RELOAD_MIPI, 0x5a, 0x03);
> + mipi_dsi_generic_write_seq_multi(dsi_ctx, 0x80, 0xa9, 0x00); /* VCOM */
>
> mipi_dsi_generic_write_seq_multi(dsi_ctx, MANTIX_CMD_SPI_FINISH, 0xa5);
> mipi_dsi_generic_write_seq_multi(dsi_ctx, MANTIX_CMD_OTP_STOP_RELOAD_MIPI, 0x00, 0x2f);
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Thanks,
Neil
next prev parent reply other threads:[~2026-01-06 8:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 20:24 [PATCH 0/5] drm/panel: mantix-mlaf057we51: Power sequence improvements Sebastian Krzyszkowiak via B4 Relay
2026-01-05 20:24 ` [PATCH 1/5] drm/panel: mantix: Enable DSI LPM Sebastian Krzyszkowiak via B4 Relay
2026-01-06 8:14 ` Neil Armstrong
2026-01-05 20:24 ` [PATCH 2/5] drm/panel: mantix: Improve power on sequence timings Sebastian Krzyszkowiak via B4 Relay
2026-01-06 8:14 ` Neil Armstrong
2026-01-05 20:24 ` [PATCH 3/5] drm/panel: mantix: Improve power off sequence Sebastian Krzyszkowiak via B4 Relay
2026-01-06 8:15 ` Neil Armstrong
2026-01-05 20:24 ` [PATCH 4/5] drm/panel: mantix: Drop bank 9 initialization Sebastian Krzyszkowiak via B4 Relay
2026-01-06 8:16 ` Neil Armstrong [this message]
2026-01-05 20:24 ` [PATCH 5/5] drm/panel: mantix: Don't turn on MIPI peripheral Sebastian Krzyszkowiak via B4 Relay
2026-01-06 8:16 ` Neil Armstrong
2026-01-13 9:06 ` [PATCH 0/5] drm/panel: mantix-mlaf057we51: Power sequence improvements Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=307ea449-c8a1-4fd7-a67b-7c6777eb4669@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=agx@sigxcpu.org \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=kernel@puri.sm \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=sebastian.krzyszkowiak@puri.sm \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®