mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Neil Armstrong <neil.armstrong@linaro.org>
To: sebastian.krzyszkowiak@puri.sm, "Guido Günther" <agx@sigxcpu.org>,
	"Purism Kernel Team" <kernel@puri.sm>,
	"Jessica Zhang" <jesszhan0024@gmail.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] drm/panel: mantix: Improve power off sequence
Date: Tue, 6 Jan 2026 09:15:19 +0100	[thread overview]
Message-ID: <d0751b98-86d6-4088-a4c4-cfa77fe0c241@linaro.org> (raw)
In-Reply-To: <20260105-mantix-halo-fixes-v1-3-1ebc9b195a34@puri.sm>

On 1/5/26 21:24, Sebastian Krzyszkowiak via B4 Relay wrote:
> From: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
> 
> According to the sequence from section 7.3.4 of FT8006P datasheet,
> TP_RSTN and RESX should be asserted after disabling AVDD and AVEE and
> together with VDDI.
> 
> Also, AVEE power down needs to happen at least 150ms after entering
> sleep mode.
> 
> Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
> ---
>   drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 12 ++++++++----
>   1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
> index bb5489e4d7a9..0e66ee7a727d 100644
> --- a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
> +++ b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
> @@ -96,6 +96,9 @@ static int mantix_disable(struct drm_panel *panel)
>   	mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);
>   	mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);
>   
> +	/* T10 */
> +	mipi_dsi_msleep(&dsi_ctx, 150);
> +
>   	return dsi_ctx.accum_err;
>   }
>   
> @@ -103,15 +106,16 @@ static int mantix_unprepare(struct drm_panel *panel)
>   {
>   	struct mantix *ctx = panel_to_mantix(panel);
>   
> -	gpiod_set_value_cansleep(ctx->tp_rstn_gpio, 1);
> -	usleep_range(5000, 6000);
> -	gpiod_set_value_cansleep(ctx->reset_gpio, 1);
> -
>   	regulator_disable(ctx->avee);
>   	regulator_disable(ctx->avdd);
>   	/* T11 */
>   	usleep_range(5000, 6000);
>   	regulator_disable(ctx->vddi);
> +
> +	gpiod_set_value_cansleep(ctx->tp_rstn_gpio, 1);
> +	usleep_range(5000, 6000);
> +	gpiod_set_value_cansleep(ctx->reset_gpio, 1);
> +
>   	/* T14 */
>   	msleep(50);
>   
> 

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil

  reply	other threads:[~2026-01-06  8:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-05 20:24 [PATCH 0/5] drm/panel: mantix-mlaf057we51: Power sequence improvements Sebastian Krzyszkowiak via B4 Relay
2026-01-05 20:24 ` [PATCH 1/5] drm/panel: mantix: Enable DSI LPM Sebastian Krzyszkowiak via B4 Relay
2026-01-06  8:14   ` Neil Armstrong
2026-01-05 20:24 ` [PATCH 2/5] drm/panel: mantix: Improve power on sequence timings Sebastian Krzyszkowiak via B4 Relay
2026-01-06  8:14   ` Neil Armstrong
2026-01-05 20:24 ` [PATCH 3/5] drm/panel: mantix: Improve power off sequence Sebastian Krzyszkowiak via B4 Relay
2026-01-06  8:15   ` Neil Armstrong [this message]
2026-01-05 20:24 ` [PATCH 4/5] drm/panel: mantix: Drop bank 9 initialization Sebastian Krzyszkowiak via B4 Relay
2026-01-06  8:16   ` Neil Armstrong
2026-01-05 20:24 ` [PATCH 5/5] drm/panel: mantix: Don't turn on MIPI peripheral Sebastian Krzyszkowiak via B4 Relay
2026-01-06  8:16   ` Neil Armstrong
2026-01-13  9:06 ` [PATCH 0/5] drm/panel: mantix-mlaf057we51: Power sequence improvements Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0751b98-86d6-4088-a4c4-cfa77fe0c241@linaro.org \
    --to=neil.armstrong@linaro.org \
    --cc=agx@sigxcpu.org \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=kernel@puri.sm \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=sebastian.krzyszkowiak@puri.sm \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®