From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: James Clark <james.clark@arm.com>,
mathieu.poirier@linaro.org, coresight@lists.linaro.org
Cc: leo.yan@linaro.com, mike.leach@linaro.org,
Leo Yan <leo.yan@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] coresight: no-op refactor to make INSTP0 check more idiomatic
Date: Thu, 3 Feb 2022 12:10:13 +0000 [thread overview]
Message-ID: <30df2340-c3b6-a5f2-5e7e-32eb89a51b68@arm.com> (raw)
In-Reply-To: <20220203115336.119735-2-james.clark@arm.com>
On 03/02/2022 11:53, James Clark wrote:
> The spec says this:
>
> P0 tracing support field. The permitted values are:
> 0b00 Tracing of load and store instructions as P0 elements is not
> supported.
> 0b11 Tracing of load and store instructions as P0 elements is
> supported, so TRCCONFIGR.INSTP0 is supported.
>
> All other values are reserved.
>
> The value we are looking for is 0b11 so simplify this. The double read
> and && was a bit obfuscated.
>
> Suggested-by: Suzuki Poulose <suzuki.poulose@arm.com>
> Signed-off-by: James Clark <james.clark@arm.com>
Thanks, Queued.
Cheers
Suzuki
prev parent reply other threads:[~2022-02-03 12:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 11:53 [PATCH 0/1] " James Clark
2022-02-03 11:53 ` [PATCH 1/1] " James Clark
2022-02-03 12:10 ` Suzuki K Poulose [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30df2340-c3b6-a5f2-5e7e-32eb89a51b68@arm.com \
--to=suzuki.poulose@arm.com \
--cc=coresight@lists.linaro.org \
--cc=james.clark@arm.com \
--cc=leo.yan@linaro.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®