From: Eduard Zingerman <eddyz87@gmail.com>
To: Ihor Solodrai <ihor.solodrai@linux.dev>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>
Cc: Alan Maguire <alan.maguire@oracle.com>,
Emil Tsalapatis <emil@etsalapatis.com>,
Jiri Olsa <jolsa@kernel.org>, Song Liu <song@kernel.org>,
Tejun Heo <tj@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
sched-ext@lists.linux.dev
Subject: Re: [PATCH bpf-next v1 0/4] libbpf: Support kernel-side kfunc flavors
Date: Thu, 19 Nov 2026 10:50:59 -0700 [thread overview]
Message-ID: <323410cacd68268a607902c50ff565af1e69e1cf.camel@gmail.com> (raw)
In-Reply-To: <a54689c5-83d8-4a81-a8a2-ba971793d981@linux.dev>
On Wed, 2026-11-18 at 16:13 -0700, Ihor Solodrai wrote:
...
> > Maybe I have reading comprehension issues, but in order to decipher it
> > one has to:
> > - "kept old prototype" - figure out that two functions were declared
> > "scx_bpf_dsq_insert" and "scx_bpf_dsq_insert___compat"
> > - "bind old binaries to it and broke them" - figure out that existing
> > bpf programs referred to "scx_bpf_dsq_insert" and libbpf mechanics
> > didn't work as expected.
> > - "reversed the naming" - like a new function became ___compat or what
> > happened?
> > - "A ___v2 kfunc declared as vmlinux.h spells it ..."
> > Now there is a ___v2 in the picture.
> > - "... doesn't bind" - figure out that this refers to libbpf mechanics.
> > - "fixed a compat macro that silently dropped enq_flags because of this."
> > Incomprehensible w/o looking in the code.
>
> Your reading is a valid approach to understand the history in more
> details, and you are correct that the paragraph does not provide them.
>
> However IMO those details are unnecessary in the cover, but pointers
> are useful. Which is why I left this ai-generated paragraph be.
Examples are very helpful in cover letters, they save reviewers time
and make the changes easier to understand for people monitoring the
list.
next prev parent reply other threads:[~2026-11-19 17:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 19:21 Ihor Solodrai
2026-11-17 19:21 ` [PATCH bpf-next v1 1/4] libbpf: Fall back to kernel ___ flavors when resolving kfuncs Ihor Solodrai
2026-11-18 22:44 ` Eduard Zingerman
2026-11-17 19:21 ` [PATCH bpf-next v1 2/4] selftests/bpf: Test kfunc flavor resolution Ihor Solodrai
2026-11-17 19:21 ` [PATCH bpf-next v1 3/4] resolve_btfids: Reject kfunc families that libbpf can't disambiguate Ihor Solodrai
2026-11-18 22:59 ` Eduard Zingerman
2026-11-17 19:21 ` [PATCH bpf-next v1 4/4] docs/bpf: Describe how to change a kfunc's prototype Ihor Solodrai
2026-11-17 20:53 ` [PATCH bpf-next v1 0/4] libbpf: Support kernel-side kfunc flavors Tejun Heo
2026-11-18 21:12 ` Eduard Zingerman
2026-11-18 21:37 ` Ihor Solodrai
2026-11-18 22:11 ` Eduard Zingerman
2026-11-18 23:13 ` Ihor Solodrai
2026-11-19 17:50 ` Eduard Zingerman [this message]
2026-11-18 21:42 ` Eduard Zingerman
2026-11-18 21:48 ` Ihor Solodrai
2026-11-18 21:57 ` Eduard Zingerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=323410cacd68268a607902c50ff565af1e69e1cf.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=alan.maguire@oracle.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=emil@etsalapatis.com \
--cc=ihor.solodrai@linux.dev \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=memxor@gmail.com \
--cc=sched-ext@lists.linux.dev \
--cc=song@kernel.org \
--cc=tj@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®