From: Xiaoyao Li <xiaoyao.li@intel.com>
To: Binbin Wu <binbin.wu@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
seanjc@google.com, pbonzini@redhat.com,
dave.hansen@linux.intel.com, andrew.cooper3@citrix.com,
nik.borisov@suse.com, kas@kernel.org, rick.p.edgecombe@intel.com,
chao.gao@intel.com, tony.lindgren@linux.intel.com,
kishen.maloor@intel.com, dedekind1@gmail.com
Subject: Re: [PATCH v4 1/4] KVM: TDX: Track configurable CPUID bits allowed by KVM
Date: Thu, 24 Sep 2026 21:55:12 +0800 [thread overview]
Message-ID: <3278bae0-1a30-478f-8488-c762ac0246fa@intel.com> (raw)
In-Reply-To: <8bcba51e-2a3b-44b8-89cd-aebfd1e50cfd@linux.intel.com>
On 9/24/2026 7:41 PM, Binbin Wu wrote:
...
>>>> As for "features forced to zero when #VE is reduced", do you mean when TDX
>>>> module supports "#VE reduction" feature, the features becomes fixed0? or when
>>>> guest enables "reduce #VE", the guest see a 0 value even though the feature is
>>>> still configurable to host userspace and host userspace configure it to 1?
>>>
>>>
>>> #VE is reduced means the guest reduced the related #VE, i.e. TDCS.TD_CTRL.REDUCE_VE
>>> is 1 and the related bit in TDCS.FEATURE_PARAVIRT_CTRL is 0.
>>
>> I think "features forced to zero when #VE is reduced" doesn't matter at all
>> here.
>
> I think it still matters.
>
> If there is a feature that is virtualized by the TDX module itself, but KVM doesn't
> support it for non-TDX VMs, I think it should be allowed.
>
> These features can't be added to the allow list because neither TDX module nor
> KVM do the virtualization for them.
... <snip>
>> I think all the bits that are directly configurable but out of kvm_cpu_caps[]
>> and not supported by KVM fall into the last category. You can just list all of
>> them instead of my "for example".
>
> As I mentioned above, if there is a feature that is virtualized by the TDX module itself,
> but KVM doesn't support it for non-TDX VMs, it should be allowed. Although I don't have
> a concrete example. I think we still need to mention #VE reduction to some degree, but
> let me see how to simplify the description.
(This reply only concentrates on the discussion of "if there is a feature that
is virtualized by the TDX module itself")
If you are talking about the features related to #VE, I think there is no.
Because if TDX module itself can virtualize the feature, then it shouldn't be
#VE at all. #VE means it needs para-virt support from host VMM.
If you are talking about the features unrelated to #VE. I think it's just the
case I argued for in previous v3, that we can support a feature for TDX first
before non-TDX VMs. I think we all agreed that such case can happen and we
decided to support such case when there is a real case.
next prev parent reply other threads:[~2026-09-24 13:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 7:25 [PATCH v4 0/4] KVM: TDX: Validate directly configurable CPUID bits Binbin Wu
2026-09-17 7:25 ` [PATCH v4 1/4] KVM: TDX: Track configurable CPUID bits allowed by KVM Binbin Wu
2026-09-23 0:01 ` Edgecombe, Rick P
2026-09-23 0:14 ` Binbin Wu
2026-09-23 0:45 ` Edgecombe, Rick P
2026-09-23 0:57 ` Binbin Wu
2026-09-23 1:09 ` Edgecombe, Rick P
2026-09-23 1:17 ` Binbin Wu
2026-09-23 11:21 ` Xiaoyao Li
2026-09-23 14:25 ` Edgecombe, Rick P
2026-09-24 2:05 ` Xiaoyao Li
2026-09-24 6:36 ` Xiaoyao Li
2026-09-24 7:49 ` Binbin Wu
2026-09-24 9:30 ` Xiaoyao Li
2026-09-24 11:41 ` Binbin Wu
2026-09-24 13:55 ` Xiaoyao Li [this message]
2026-09-24 15:10 ` Binbin Wu
2026-09-24 14:33 ` Xiaoyao Li
2026-09-17 7:25 ` [PATCH v4 2/4] KVM: TDX: Report CORE_CAPABILITIES as configurable Binbin Wu
2026-09-22 21:11 ` Edgecombe, Rick P
2026-09-23 0:03 ` Binbin Wu
2026-09-24 6:44 ` Xiaoyao Li
2026-09-17 7:25 ` [PATCH v4 3/4] KVM: TDX: Filter configurable CPUID bits Binbin Wu
2026-09-23 0:16 ` Edgecombe, Rick P
2026-09-23 0:28 ` Binbin Wu
2026-09-23 0:34 ` Edgecombe, Rick P
2026-09-17 7:25 ` [PATCH v4 4/4] KVM: TDX: Validate userspace CPUID input for KVM_TDX_INIT_VM Binbin Wu
2026-09-23 0:16 ` Edgecombe, Rick P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3278bae0-1a30-478f-8488-c762ac0246fa@intel.com \
--to=xiaoyao.li@intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=binbin.wu@linux.intel.com \
--cc=chao.gao@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dedekind1@gmail.com \
--cc=kas@kernel.org \
--cc=kishen.maloor@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nik.borisov@suse.com \
--cc=pbonzini@redhat.com \
--cc=rick.p.edgecombe@intel.com \
--cc=seanjc@google.com \
--cc=tony.lindgren@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®