From: Krzysztof Kozlowski <krzk@kernel.org>
To: Zhu Yixin <yzhu@maxlinear.com>,
vkoul@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, p.zabel@pengutronix.de, kees@kernel.org,
dave.jiang@intel.com, av2082000@gmail.com,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: lgm-dma: Added intel,dma-sw-desc property.
Date: Fri, 8 Aug 2025 08:09:37 +0200 [thread overview]
Message-ID: <32a2ec88-b9b8-4c4d-9836-838702e4e136@kernel.org> (raw)
In-Reply-To: <20250808032243.3796335-1-yzhu@maxlinear.com>
On 08/08/2025 05:22, Zhu Yixin wrote:
> If the intel,dma-sw-desc property is present, it indicates that
> the DMA driver is responsible for managing the DMA engine, including
> handing the DMA descriptors.
> If this property is present, the system defaults to a mode where
> another hardware component takes control of the DMA engine.
> In this case, the hardware can generate and manage descriptors
> independently, without driver involvement.
>
> This property only takes effect on HDMA(DMAV3x).
>
> Signed-off-by: Zhu Yixin <yzhu@maxlinear.com>
Where is the changelog?
> ---
> Documentation/devicetree/bindings/dma/intel,ldma.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/intel,ldma.yaml b/Documentation/devicetree/bindings/dma/intel,ldma.yaml
> index d6bb553a2c6f..426168b8709e 100644
> --- a/Documentation/devicetree/bindings/dma/intel,ldma.yaml
> +++ b/Documentation/devicetree/bindings/dma/intel,ldma.yaml
> @@ -80,6 +80,12 @@ properties:
> if it is disabled, the DMA RX will still support programmable fixed burst size of 2,4,8,16.
> It only applies to RX DMA and memcopy DMA.
>
> + intel,dma-sw-desc:
> + type: boolean
> + description:
> + Indicates that the DMA driver should operate in software-managed mode.
> + If this property is not present, it implies that DMA descriptors are managed and generated by another hardware component that controls the DMA engine.
Nothing improved:
1. Still wrongly wrapped.
2. Still SW property.
I don't think you read the feedback. You need to describe hardware, not SW.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-08 6:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 3:22 Zhu Yixin
2025-08-08 3:22 ` [PATCH v2 2/3] dmaengine: lgm-dma: splitting CDMA and HDMA functions Zhu Yixin
2025-08-08 3:22 ` [PATCH v2 3/3] dmaengine: lgm-dma: Added Software management functions on HDMA Zhu Yixin
2025-08-08 6:11 ` Krzysztof Kozlowski
2025-08-15 6:51 ` Yi xin Zhu
2025-08-08 6:09 ` Krzysztof Kozlowski [this message]
2025-08-15 7:07 ` [PATCH v2 1/3] dt-bindings: lgm-dma: Added intel,dma-sw-desc property Yi xin Zhu
2025-08-15 8:32 ` Krzysztof Kozlowski
2025-08-15 10:06 ` Yi xin Zhu
2025-08-15 10:40 ` Krzysztof Kozlowski
2025-08-18 8:41 ` Yi xin Zhu
2025-08-24 10:26 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32a2ec88-b9b8-4c4d-9836-838702e4e136@kernel.org \
--to=krzk@kernel.org \
--cc=av2082000@gmail.com \
--cc=conor+dt@kernel.org \
--cc=dave.jiang@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=kees@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
--cc=yzhu@maxlinear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®