From: Krzysztof Kozlowski <krzk@kernel.org>
To: Zhu Yixin <yzhu@maxlinear.com>,
vkoul@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, p.zabel@pengutronix.de, kees@kernel.org,
dave.jiang@intel.com, av2082000@gmail.com,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] dmaengine: lgm-dma: Added Software management functions on HDMA.
Date: Fri, 8 Aug 2025 08:11:25 +0200 [thread overview]
Message-ID: <3f1a35fc-7fda-4179-948e-1a2acafd0f8a@kernel.org> (raw)
In-Reply-To: <20250808032243.3796335-3-yzhu@maxlinear.com>
On 08/08/2025 05:22, Zhu Yixin wrote:
> +
> +struct dw4_desc_sw {
> + struct virt_dma_desc vd;
> + struct ldma_chan *chan;
> + struct dw4_desc_hw *desc_hw;
> +};
> +
> +/**
> + * hdma TX need some sideband info to switch in dw0 and dw1
That's not a kerneldoc.
Please run standard kernel tools for static analysis, like coccinelle,
smatch and sparse, and fix reported warnings. Also please check for
warnings when building with W=1. Most of these commands (checks or W=1
build) can build specific targets, like some directory, to narrow the
scope to only your code. The code here looks like it needs a fix. Feel
free to get in touch if the warning is not clear.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-08 6:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 3:22 [PATCH v2 1/3] dt-bindings: lgm-dma: Added intel,dma-sw-desc property Zhu Yixin
2025-08-08 3:22 ` [PATCH v2 2/3] dmaengine: lgm-dma: splitting CDMA and HDMA functions Zhu Yixin
2025-08-08 3:22 ` [PATCH v2 3/3] dmaengine: lgm-dma: Added Software management functions on HDMA Zhu Yixin
2025-08-08 6:11 ` Krzysztof Kozlowski [this message]
2025-08-15 6:51 ` Yi xin Zhu
2025-08-08 6:09 ` [PATCH v2 1/3] dt-bindings: lgm-dma: Added intel,dma-sw-desc property Krzysztof Kozlowski
2025-08-15 7:07 ` Yi xin Zhu
2025-08-15 8:32 ` Krzysztof Kozlowski
2025-08-15 10:06 ` Yi xin Zhu
2025-08-15 10:40 ` Krzysztof Kozlowski
2025-08-18 8:41 ` Yi xin Zhu
2025-08-24 10:26 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f1a35fc-7fda-4179-948e-1a2acafd0f8a@kernel.org \
--to=krzk@kernel.org \
--cc=av2082000@gmail.com \
--cc=conor+dt@kernel.org \
--cc=dave.jiang@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=kees@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
--cc=yzhu@maxlinear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®