From: Paul Durrant <xadimgnik@gmail.com>
To: David Woodhouse <dwmw2@infradead.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Paul Durrant <pdurrant@amazon.com>,
Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org
Subject: Re: [PATCH v5 07/10] KVM: xen: allow vcpu_info to be mapped by fixed HVA
Date: Fri, 22 Sep 2023 16:49:49 +0100 [thread overview]
Message-ID: <34457a97-516f-4122-a9d7-920eb3b3c2e0@xen.org> (raw)
In-Reply-To: <8f61e1618f23e975f30e552c09787c5f82ee89f3.camel@infradead.org>
On 22/09/2023 16:44, David Woodhouse wrote:
> On Fri, 2023-09-22 at 15:00 +0000, Paul Durrant wrote:
>> From: Paul Durrant <pdurrant@amazon.com>
>>
>> If the guest does not explicitly set the GPA of vcpu_info structure in
>> memory then, for guests with 32 vCPUs or fewer, the vcpu_info embedded
>> in the shared_info page may be used. As described in a previous commit,
>> the shared_info page is an overlay at a fixed HVA within the VMM, so in
>> this case it also more optimal to activate the vcpu_info cache with a
>> fixed HVA to avoid unnecessary invalidation if the guest memory layout
>> is modified.
>>
>> Signed-off-by: Paul Durrant <pdurrant@amazon.com>
>
> But it should *only* be defined as an HVA in the case where it's the
> one in the shinfo. Otherwise, it's defined by its GPA.
>
> Which almost makes me want to see a sanity check that it precisely
> equals &shinfo->vcpu_info[vcpu->arch.xen.vcpu_id].
>
> Which brings me back around the circle again to wonder why we don't
> just *default* to it.... you hate me, don't you?
>
> Your previous set of patches did that, and it did end requiring that
> the VMM restore both VCPU_INFO and VCPU_ID for each vCPU *before*
> restoring the SHARED_INFO_HVA on resume, but wasn't that OK?
>
No. It was painful and overly complex, with too many corner cases that
were making my brain hurt. Given the pain of the last week, leaving the
default handling in the VMM is preferable. It means I don't need to
impose rules about attribute ordering and hence get caught by needing
one thread to wait for another inside the VMM. It's better and more
robust this way.
Paul
next prev parent reply other threads:[~2023-09-22 15:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 14:59 [PATCH v5 00/10] KVM: xen: update shared_info and vcpu_info handling Paul Durrant
2023-09-22 15:00 ` [PATCH v5 01/10] KVM: pfncache: add a map helper function Paul Durrant
2023-09-22 15:00 ` [PATCH v5 02/10] KVM: pfncache: add a mark-dirty helper Paul Durrant
2023-09-22 15:00 ` [PATCH v5 03/10] KVM: pfncache: add a helper to get the gpa Paul Durrant
2023-09-22 15:00 ` [PATCH v5 04/10] KVM: pfncache: base offset check on khva rather than gpa Paul Durrant
2023-09-22 15:00 ` [PATCH v5 05/10] KVM: pfncache: allow a cache to be activated with a fixed (userspace) HVA Paul Durrant
2023-09-22 15:00 ` [PATCH v5 06/10] KVM: xen: allow shared_info to be mapped by fixed HVA Paul Durrant
2023-09-23 7:07 ` David Woodhouse
2023-09-26 9:22 ` Paul Durrant
2023-09-22 15:00 ` [PATCH v5 07/10] KVM: xen: allow vcpu_info " Paul Durrant
2023-09-22 15:44 ` David Woodhouse
2023-09-22 15:49 ` Paul Durrant [this message]
2023-09-22 15:52 ` David Woodhouse
2023-09-22 16:10 ` David Woodhouse
2023-09-22 15:00 ` [PATCH v5 08/10] KVM: selftests / xen: map shared_info using HVA rather than GFN Paul Durrant
2023-09-22 15:00 ` [PATCH v5 09/10] KVM: selftests / xen: re-map vcpu_info using HVA rather than GPA Paul Durrant
2023-09-22 16:11 ` David Woodhouse
2023-09-22 15:00 ` [PATCH v5 10/10] KVM: xen: advertize the KVM_XEN_HVM_CONFIG_SHARED_INFO_HVA capability Paul Durrant
2023-09-22 15:37 ` [PATCH v5 00/10] KVM: xen: update shared_info and vcpu_info handling David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34457a97-516f-4122-a9d7-920eb3b3c2e0@xen.org \
--to=xadimgnik@gmail.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=pdurrant@amazon.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®