From: David Woodhouse <dwmw2@infradead.org>
To: Paul Durrant <paul@xen.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Paul Durrant <pdurrant@amazon.com>,
"H. Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org
Subject: Re: [PATCH v5 00/10] KVM: xen: update shared_info and vcpu_info handling
Date: Fri, 22 Sep 2023 16:37:13 +0100 [thread overview]
Message-ID: <d13e459e221f28fb1865eedea023e583a2277ab1.camel@infradead.org> (raw)
In-Reply-To: <20230922150009.3319-1-paul@xen.org>
[-- Attachment #1: Type: text/plain, Size: 2679 bytes --]
On Fri, 2023-09-22 at 14:59 +0000, Paul Durrant wrote:
> From: Paul Durrant <pdurrant@amazon.com>
>
> The following part of the original cover letter still applies...
>
> "Currently we treat the shared_info page as guest memory and the VMM
> informs KVM of its location using a GFN. However it is not guest memory as
> such; it's an overlay page. So we pointlessly invalidate and re-cache a
> mapping to the *same page* of memory every time the guest requests that
> shared_info be mapped into its address space. Let's avoid doing that by
> modifying the pfncache code to allow activation using a fixed userspace
> HVA as well as a GPA."
>
> However, this version of the series has dropped the other changes to try
> to handle the default vcpu_info location directly in KVM. With all the
> corner cases, it was getting sufficiently complex the functionality is
> better off staying in the VMM. So, instead of that code, two new patches
> have been added:
I think there's key information missing from this cover letter (and
since cover letters don't get preserved, it probably wants to end up in
one of the commits too).
This isn't *just* an optimisation; it's not just that we're pointlessly
invalidating and re-caching it. The problem is the time in *between*
those two, because we don't have atomic memslot updates (qv).
If we have to break apart a large memslot which contains the
shared_info GPA, then add back the two pieces and whatever we've
overlaid in the middle which broke it in two... there are long periods
of time when an interrupt might arrive and the shared_info GPA might
just be *absent*.
Using the HVA for the shinfo page makes a whole bunch of sense since
it's kind of supposed to be a xenheap page anyway and not defined by
the guest address it may — or may NOT — be mapped at. But more to the
point, using the HVA means that the kernel can continue to deliver
event channel interrupts (e.g. timer virqs, MSI pirqs from passthrough
devices, etc.) to it even when it *isn't* mapped.
We don't have the same problem for the vcpu_info because there's a per-
vcpu *shadow* of evtchn_pending_sel for that very purpose, which the
vCPU itself will OR into the real vcpu_info on the way into guest mode.
So since we have to stop all vCPUs before changing the memslots anyway,
the events can gather in that evtchn_pending_sel and it all works out
OK.
It would still be nice to have a way of atomically sticking an overlay
page over the middle of an existing memslot and breaking it apart, but
we can live without it. And even if we *did* get that, what you're
doing here makes a lot of sense anyway.
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5965 bytes --]
prev parent reply other threads:[~2023-09-22 15:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 14:59 Paul Durrant
2023-09-22 15:00 ` [PATCH v5 01/10] KVM: pfncache: add a map helper function Paul Durrant
2023-09-22 15:00 ` [PATCH v5 02/10] KVM: pfncache: add a mark-dirty helper Paul Durrant
2023-09-22 15:00 ` [PATCH v5 03/10] KVM: pfncache: add a helper to get the gpa Paul Durrant
2023-09-22 15:00 ` [PATCH v5 04/10] KVM: pfncache: base offset check on khva rather than gpa Paul Durrant
2023-09-22 15:00 ` [PATCH v5 05/10] KVM: pfncache: allow a cache to be activated with a fixed (userspace) HVA Paul Durrant
2023-09-22 15:00 ` [PATCH v5 06/10] KVM: xen: allow shared_info to be mapped by fixed HVA Paul Durrant
2023-09-23 7:07 ` David Woodhouse
2023-09-26 9:22 ` Paul Durrant
2023-09-22 15:00 ` [PATCH v5 07/10] KVM: xen: allow vcpu_info " Paul Durrant
2023-09-22 15:44 ` David Woodhouse
2023-09-22 15:49 ` Paul Durrant
2023-09-22 15:52 ` David Woodhouse
2023-09-22 16:10 ` David Woodhouse
2023-09-22 15:00 ` [PATCH v5 08/10] KVM: selftests / xen: map shared_info using HVA rather than GFN Paul Durrant
2023-09-22 15:00 ` [PATCH v5 09/10] KVM: selftests / xen: re-map vcpu_info using HVA rather than GPA Paul Durrant
2023-09-22 16:11 ` David Woodhouse
2023-09-22 15:00 ` [PATCH v5 10/10] KVM: xen: advertize the KVM_XEN_HVM_CONFIG_SHARED_INFO_HVA capability Paul Durrant
2023-09-22 15:37 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d13e459e221f28fb1865eedea023e583a2277ab1.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=pdurrant@amazon.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®